fix(gateway): tolerate transient pre-hello closes in CLI calls#54475
fix(gateway): tolerate transient pre-hello closes in CLI calls#54475ruanrrn wants to merge 5 commits into
Conversation
Greptile SummaryThis PR fixes a flaky CLI failure where one-shot gateway calls ( Changes:
Notes:
Confidence Score: 4/5
Prompt To Fix All With AIThis is a comment left during a code review.
Path: src/gateway/client.ts
Line: 523-528
Comment:
**String-based error detection is fragile**
The transient close detection relies on matching `err.message` against a hardcoded regex that must stay in sync with the error message template two hundred lines away:
```ts
// line 296 – error construction
this.flushPendingErrors(new Error(`gateway closed (${code}): ${reasonText}`));
// line 526 – detection regex
/^gateway closed \(1000\):\s*$/.test(err.message)
```
If the template on line 296 is ever changed (e.g. adding a suffix, changing the separator, or including `reasonText` differently for the empty-string case), the regex would silently stop matching and CLI callers would revert to the pre-fix behaviour — failing immediately on transient pre-hello closes — without any test failure in unrelated paths. The new tests in `client.test.ts` do guard this specific message, but only for the test scenario as written.
A more robust alternative would be to use a structured sentinel (e.g. a typed error subclass `GatewayPreHelloCloseError`, or a tagged `{ isPreHelloClose: true }` field) rather than pattern-matching on a human-readable message string. This would be immune to message-copy changes and would not require the regex to be kept in sync.
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "fix(gateway): tolerate transient pre-hel..." | Re-trigger Greptile |
012cb0d to
af48d50
Compare
af48d50 to
29473d1
Compare
|
Thanks for the context here. I swept through the related work, and this is now duplicate or superseded. Keep this PR open: current main and the latest release still reject the narrow pre-hello clean-close path, and this branch remains the canonical implementation candidate, but it is not merge-ready because it conflicts with main and still lacks inspectable real behavior proof. Canonical path: Close this PR as superseded by #85253. So I’m closing this here and keeping the remaining discussion on #85253. Review detailsBest possible solution: Close this PR as superseded by #85253. Do we have a high-confidence way to reproduce the issue? Yes for the narrow event sequence by source inspection: current main rejects an unsettled Is this the best way to solve the issue? Yes if refreshed: the PR keeps the fix in the gateway call/client layer, scopes suppression to pre-hello code 1000 with an empty reason, and preserves fatal behavior for other close cases. It still needs conflict resolution, changed-surface validation, and inspectable real CLI proof before merge. Security review: Security review cleared: The diff is limited to gateway close/error handling, tests, and changelog text, with no dependency, workflow, permission, package, install, or secret-handling changes found. What I checked:
Likely related people:
Codex review notes: model gpt-5.5, reasoning high; reviewed against 6d9b3887ea26. |
|
ProjectClownfish pushed a narrow repair to this branch so the original contributor path can stay canonical. Source PR: #54475 |
29473d1 to
6f5aea4
Compare
6f5aea4 to
e089d02
Compare
|
ClawSweeper PR egg 🎁 Pass real behavior proof to wake the egg and unlock a hatchable treat. Where did the egg go?
|
|
ClawSweeper applied the proposed close for this PR.
|
…26.6.8) (#1144) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/openclaw/openclaw](https://openclaw.ai) ([source](https://github.com/openclaw/openclaw)) | patch | `2026.6.6` → `2026.6.8` | --- ### Release Notes <details> <summary>openclaw/openclaw (ghcr.io/openclaw/openclaw)</summary> ### [`v2026.6.8`](https://github.com/openclaw/openclaw/blob/HEAD/CHANGELOG.md#202668) [Compare Source](openclaw/openclaw@v2026.6.6...v2026.6.8) ##### Highlights - Telegram and WhatsApp channel delivery are richer and less brittle: Telegram can send structured rich text with tables, lists, expandable blockquotes, prompt-preserving CLI backend delivery, retired native draft migration, and safer rich-media boundaries, while WhatsApp now honors configured ACP bindings. ([#​92679](openclaw/openclaw#92679), [#​84082](openclaw/openclaw#84082), [#​89421](openclaw/openclaw#89421), [#​92513](openclaw/openclaw#92513)) Thanks [@​obviyus](https://github.com/obviyus), [@​jzakirov](https://github.com/jzakirov), [@​spacegeologist](https://github.com/spacegeologist), and [@​TurboTheTurtle](https://github.com/TurboTheTurtle). - Agent and Gateway recovery is sharper across account-scoped DM sends, generated media completions, restart shutdown aborts, yielded subagent pauses, yielded cron media, heartbeat dedupe, session identity prompts, and unknown OpenAI agent selector rejection. ([#​92788](openclaw/openclaw#92788), [#​91246](openclaw/openclaw#91246), [#​91357](openclaw/openclaw#91357), [#​92631](openclaw/openclaw#92631), [#​92146](openclaw/openclaw#92146), [#​91287](openclaw/openclaw#91287), [#​92468](openclaw/openclaw#92468), [#​92510](openclaw/openclaw#92510)) Thanks [@​yetval](https://github.com/yetval), [@​TurboTheTurtle](https://github.com/TurboTheTurtle), [@​ooiuuii](https://github.com/ooiuuii), [@​openperf](https://github.com/openperf), [@​IWhatsskill](https://github.com/IWhatsskill), [@​ZengWen-DT](https://github.com/ZengWen-DT), and [@​zhangguiping-xydt](https://github.com/zhangguiping-xydt). - Provider/model handling expands and tightens with GLM-5.2, Claude Haiku 4.5 catalog rows, OpenRouter and Google Vertex provider-prefix normalization, managed SecretRef auth, bounded model browse discovery, storeless OpenAI Responses replay gating, and Claude 4.5 Copilot tool-streaming safety. ([#​92796](openclaw/openclaw#92796), [#​90116](openclaw/openclaw#90116), [#​92627](openclaw/openclaw#92627), [#​91218](openclaw/openclaw#91218), [#​90686](openclaw/openclaw#90686), [#​92247](openclaw/openclaw#92247), [#​90706](openclaw/openclaw#90706), [#​75393](openclaw/openclaw#75393)) Thanks [@​arkyu2077](https://github.com/arkyu2077), [@​liuhao1024](https://github.com/liuhao1024), [@​bymle](https://github.com/bymle), [@​rohitjavvadi](https://github.com/rohitjavvadi), [@​samson910022](https://github.com/samson910022), [@​snowzlm](https://github.com/snowzlm), and [@​Kailigithub](https://github.com/Kailigithub). - `/usage` and reply payload hooks now have a native full footer renderer, default template, fixed-decimal formatting, credential-aware limits, better partial-count handling, and warnings for broken templates instead of silent bad output. ([#​92657](openclaw/openclaw#92657), [#​89835](openclaw/openclaw#89835), [#​89629](openclaw/openclaw#89629)) Thanks [@​Marvinthebored](https://github.com/Marvinthebored). - UI and mobile flows are steadier: workspace files can collapse and start collapsed, WebChat backscroll survives streaming, the sidebar session picker remains interactive above the desktop workbench, reset soft args survive UI dispatch, stale dashboard session parent lineage is preserved, and iOS reconnects stale foreground gateways. ([#​92779](openclaw/openclaw#92779), [#​92622](openclaw/openclaw#92622), [#​92705](openclaw/openclaw#92705), [#​91353](openclaw/openclaw#91353), [#​90658](openclaw/openclaw#90658), [#​92552](openclaw/openclaw#92552)) Thanks [@​shakkernerd](https://github.com/shakkernerd), [@​TurboTheTurtle](https://github.com/TurboTheTurtle), [@​NianJiuZst](https://github.com/NianJiuZst), [@​zhouhe-xydt](https://github.com/zhouhe-xydt), [@​luoyanglang](https://github.com/luoyanglang), and [@​Solvely-Colin](https://github.com/Solvely-Colin). - Memory, state, and diagnostics recover cleaner: oversized OpenAI embedding batches split before 431s, QMD memory search stays available in transient mode, SQLite avoids WAL on NFS state volumes, stuck-session recovery scheduling no longer resets warning backoff, and Infinity chunk limits stay genuinely unbounded. ([#​92650](openclaw/openclaw#92650), [#​92618](openclaw/openclaw#92618), [#​92639](openclaw/openclaw#92639), [#​91247](openclaw/openclaw#91247), [#​92752](openclaw/openclaw#92752), [#​92735](openclaw/openclaw#92735)) Thanks [@​mushuiyu886](https://github.com/mushuiyu886), [@​TurboTheTurtle](https://github.com/TurboTheTurtle), [@​849261680](https://github.com/849261680), [@​gnanam1990](https://github.com/gnanam1990), and [@​yhterrance](https://github.com/yhterrance). ##### Changes - Providers/models: add GLM-5.2 support and Claude Haiku 4.5 catalog entries while keeping provider-qualified model IDs normalized across OpenRouter and Google Vertex paths. ([#​92796](openclaw/openclaw#92796), [#​90116](openclaw/openclaw#90116), [#​92627](openclaw/openclaw#92627), [#​91218](openclaw/openclaw#91218)) Thanks [@​arkyu2077](https://github.com/arkyu2077), [@​liuhao1024](https://github.com/liuhao1024), and [@​bymle](https://github.com/bymle). - Channel plugins: ship Telegram rich-message delivery and WhatsApp ACP binding support, including rich prompt handoff to CLI backends and transport fixtures for richer drafts. ([#​92679](openclaw/openclaw#92679), [#​92513](openclaw/openclaw#92513)) Thanks [@​obviyus](https://github.com/obviyus) and [@​TurboTheTurtle](https://github.com/TurboTheTurtle). - Agent commands: support `/btw` in CLI-backed sessions and keep CLI usage-error exits classified as usage failures instead of successful runs. ([#​92669](openclaw/openclaw#92669), [#​92162](openclaw/openclaw#92162)) Thanks [@​joshavant](https://github.com/joshavant) and [@​Pandah97](https://github.com/Pandah97). - Usage hooks: add built-in full footer rendering, default footer templates, per-turn usage state, credential-aware limits, and fixed-decimal formatting for usage-bar templates. ([#​92657](openclaw/openclaw#92657), [#​89835](openclaw/openclaw#89835), [#​89629](openclaw/openclaw#89629)) Thanks [@​Marvinthebored](https://github.com/Marvinthebored). - Docs and operator guidance: document node config examples, clarify before-install hook scope, correct agent default concurrency comments, refresh ZAI provider docs, and update channel/group docs for current Telegram and WhatsApp behavior. ([#​92677](openclaw/openclaw#92677), [#​92766](openclaw/openclaw#92766), [#​92695](openclaw/openclaw#92695)) Thanks [@​liuhao1024](https://github.com/liuhao1024), [@​sallyom](https://github.com/sallyom), and [@​ArielSmoliar](https://github.com/ArielSmoliar). ##### Fixes - Onboarding/skills: show the Homebrew install recommendation only on macOS and Linux, so FreeBSD and other unsupported platforms no longer get a misleading brew prompt. Fixes [#​68893](openclaw/openclaw#68893); carries forward [#​68894](openclaw/openclaw#68894), [#​68910](openclaw/openclaw#68910), [#​68941](openclaw/openclaw#68941), [#​68943](openclaw/openclaw#68943), [#​69002](openclaw/openclaw#69002), and [#​69545](openclaw/openclaw#69545). Thanks [@​yurivict](https://github.com/yurivict), [@​Sanjays2402](https://github.com/Sanjays2402), [@​Eruditi](https://github.com/Eruditi), [@​JustInCache](https://github.com/JustInCache), [@​nnish16](https://github.com/nnish16), and [@​Mlightsnow](https://github.com/Mlightsnow). - Channels and delivery: preserve account-scoped DM channel send policy, rich Telegram final replies, rich Telegram tables and lists, Telegram thread-create CLI remapping, Slack outbound `message_sent` hooks, contributed message-tool schema optionality, same-channel generated media completions, and channel chunking around surrogate pairs and Infinity limits. ([#​92788](openclaw/openclaw#92788), [#​92679](openclaw/openclaw#92679), [#​89421](openclaw/openclaw#89421), [#​89943](openclaw/openclaw#89943), [#​91137](openclaw/openclaw#91137), [#​91246](openclaw/openclaw#91246), [#​92735](openclaw/openclaw#92735)) Thanks [@​yetval](https://github.com/yetval), [@​obviyus](https://github.com/obviyus), [@​spacegeologist](https://github.com/spacegeologist), [@​rishitamrakar](https://github.com/rishitamrakar), [@​lundog](https://github.com/lundog), [@​TurboTheTurtle](https://github.com/TurboTheTurtle), and [@​yhterrance](https://github.com/yhterrance). - Auto-reply/groups: keep ordinary group text replies on automatic final-reply delivery while allowing `message(action=send)` for files, images, and other attachments to the same group or topic. Carries forward [#​43276](openclaw/openclaw#43276); refs [#​48004](openclaw/openclaw#48004). Thanks [@​NayukiChiba](https://github.com/NayukiChiba) and [@​ShakaRover](https://github.com/ShakaRover). - Auto-reply/skills: preserve multiline payloads for `/skill` and direct skill slash commands while keeping command-head normalization for aliases, colon syntax, and bot mentions. Fixes [#​79155](openclaw/openclaw#79155); carries forward [#​81305](openclaw/openclaw#81305). Thanks [@​web3blind](https://github.com/web3blind). - iMessage: normalize leading NUL sent-message echo prefixes while preserving interior NUL bytes and the leading attributedBody marker handling from [#​73942](openclaw/openclaw#73942). Carries forward [#​63581](openclaw/openclaw#63581). Thanks [@​drvoss](https://github.com/drvoss). - Discord: give generated auto-thread titles a 60-second timeout and 4,096-token reasoning-model output budget, clamped to the selected model output cap. ([#​64734](openclaw/openclaw#64734)) Thanks [@​hanamizuki](https://github.com/hanamizuki). - Agent, cron, and Gateway runtime: mark active main sessions before restart shutdown aborts, pause yielded subagent runs whose terminal also signals abort, preserve yielded media completions, de-duplicate main-session heartbeat events, expose session identity in runtime prompts, reject unknown OpenAI agent selectors, keep generated media completions and slash-command block replies in WebChat, preserve fresh post-compaction usage while clearing stale usage snapshots, and require admin privileges for HTTP session/model override surfaces. ([#​91357](openclaw/openclaw#91357), [#​92631](openclaw/openclaw#92631), [#​92146](openclaw/openclaw#92146), [#​91287](openclaw/openclaw#91287), [#​92468](openclaw/openclaw#92468), [#​92510](openclaw/openclaw#92510), [#​91246](openclaw/openclaw#91246), [#​50795](openclaw/openclaw#50795), [#​50845](openclaw/openclaw#50845), [#​82874](openclaw/openclaw#82874), [#​92651](openclaw/openclaw#92651), [#​92646](openclaw/openclaw#92646)) Thanks [@​ooiuuii](https://github.com/ooiuuii), [@​openperf](https://github.com/openperf), [@​IWhatsskill](https://github.com/IWhatsskill), [@​ZengWen-DT](https://github.com/ZengWen-DT), [@​zhangguiping-xydt](https://github.com/zhangguiping-xydt), [@​Hollychou924](https://github.com/Hollychou924), [@​leno23](https://github.com/leno23), and [@​TurboTheTurtle](https://github.com/TurboTheTurtle). - Agents/exec: default empty-success background completion notices on only for real chat channels, preserving explicit opt-outs and keeping generic providers silent while carrying forward the narrow UX intent from [#​39726](openclaw/openclaw#39726) and [#​46926](openclaw/openclaw#46926). Thanks [@​Sapientropic](https://github.com/Sapientropic) and [@​wenkang-xie](https://github.com/wenkang-xie). - Providers and model replay: preserve storeless OpenAI Responses replay compatibility, avoid eager tool streaming for Claude 4.5 in Copilot, honor profile auth for SecretRef model entries, bound model browsing, strip provider prefixes where runtimes need bare IDs, and surface nested embedding fetch failures. ([#​90706](openclaw/openclaw#90706), [#​75393](openclaw/openclaw#75393), [#​90686](openclaw/openclaw#90686), [#​92247](openclaw/openclaw#92247), [#​92627](openclaw/openclaw#92627), [#​91218](openclaw/openclaw#91218), [#​92628](openclaw/openclaw#92628)) Thanks [@​snowzlm](https://github.com/snowzlm), [@​Kailigithub](https://github.com/Kailigithub), [@​rohitjavvadi](https://github.com/rohitjavvadi), [@​samson910022](https://github.com/samson910022), [@​liuhao1024](https://github.com/liuhao1024), [@​bymle](https://github.com/bymle), and [@​mushuiyu886](https://github.com/mushuiyu886). - Memory, state, diagnostics, and config: split header-too-large embedding batches, keep QMD memory search enabled in transient mode, avoid SQLite WAL on NFS volumes, preserve recovery scheduling outside stuck-session warning backoff, and keep shell environment fallbacks contained in config write tests. ([#​92650](openclaw/openclaw#92650), [#​92618](openclaw/openclaw#92618), [#​92639](openclaw/openclaw#92639), [#​91247](openclaw/openclaw#91247), [#​92752](openclaw/openclaw#92752)) Thanks [@​mushuiyu886](https://github.com/mushuiyu886), [@​TurboTheTurtle](https://github.com/TurboTheTurtle), [@​849261680](https://github.com/849261680), and [@​gnanam1990](https://github.com/gnanam1990). - Workspace setup state: store setup completion outside the workspace dot directory using an OpenClaw-named root file, migrate valid legacy state forward, and avoid clobbering generic root `workspace-state.json` files for TigerFS-style dot-path compatibility. This Clownfish replacement carries forward the focused [#​53326](openclaw/openclaw#53326) fix idea because the original branch was closed and uneditable. ([#​53326](openclaw/openclaw#53326), [#​44783](openclaw/openclaw#44783), [#​39446](openclaw/openclaw#39446)) Thanks [@​1qh](https://github.com/1qh). - UI/mobile/TUI: preserve dashboard session parent lineage, WebChat backscroll, reset soft command args, sidebar session picker interactivity, collapsed workspace files, resolved `/model` confirmation refs, and stale foreground iOS Gateway reconnects. ([#​90658](openclaw/openclaw#90658), [#​92622](openclaw/openclaw#92622), [#​91353](openclaw/openclaw#91353), [#​92705](openclaw/openclaw#92705), [#​92779](openclaw/openclaw#92779), [#​92773](openclaw/openclaw#92773), [#​92552](openclaw/openclaw#92552)) Thanks [@​luoyanglang](https://github.com/luoyanglang), [@​TurboTheTurtle](https://github.com/TurboTheTurtle), [@​zhouhe-xydt](https://github.com/zhouhe-xydt), [@​NianJiuZst](https://github.com/NianJiuZst), [@​shakkernerd](https://github.com/shakkernerd), [@​NarahariRaghava](https://github.com/NarahariRaghava), and [@​Solvely-Colin](https://github.com/Solvely-Colin). - TUI: reload the active session after external `/new` or `/reset` session-change events so stale transcript and stream state clear promptly. Fixes [#​38966](openclaw/openclaw#38966); carries forward [#​40472](openclaw/openclaw#40472). Thanks [@​yizhanzjz](https://github.com/yizhanzjz) and [@​wsyjh8](https://github.com/wsyjh8). - Control UI: preserve Gateway Access tokens during same-normalized WebSocket URL edits and reload gateway-scoped tokens when switching endpoints. Fixes [#​41545](openclaw/openclaw#41545); repairs [#​42001](openclaw/openclaw#42001) with additional source PRs [#​41546](openclaw/openclaw#41546), [#​41552](openclaw/openclaw#41552), and [#​41718](openclaw/openclaw#41718). Thanks [@​wsyjh8](https://github.com/wsyjh8), [@​llagy0020](https://github.com/llagy0020), [@​llagy007](https://github.com/llagy007), [@​pingfanfan](https://github.com/pingfanfan), and [@​zheliu2](https://github.com/zheliu2). - Gateway CLI: tolerate a single transient clean WebSocket close before `hello-ok` so one-shot RPC calls reconnect instead of failing noisily, while repeated clean pre-hello closes still surface. Carries forward source PRs [#​54475](openclaw/openclaw#54475) and [#​54774](openclaw/openclaw#54774); [#​85253](openclaw/openclaw#85253) covered adjacent connect assembly diagnostics. Thanks [@​ruanrrn](https://github.com/ruanrrn). - Gateway/Linux: keep root-owned systemd user service lifecycle commands on root's user manager when a stale `SUDO_USER` remains in a root shell with root's user bus environment. Fixes [#​81410](openclaw/openclaw#81410). Thanks [@​Ericksza](https://github.com/Ericksza) and [@​ChuckClose-tech](https://github.com/ChuckClose-tech). - Release and test reliability: extend slow Gateway/full-suite watchdogs, split local full-suite shards when throttled, stabilize plugin auth marker fixtures, avoid brittle provider-ref error text, and keep QA Lab bootstrap selection assertions aligned with flow-only scenarios. ([#​92652](openclaw/openclaw#92652)) - macOS Peekaboo bridge: update the embedded Peekaboo package to 3.5.2 and route bundled-skill CLI commands through the OpenClaw app bridge so they inherit its Screen Recording and Accessibility grants. - Agent routing: route subagent RPC callbacks addressed to an agent-shaped `--to` target to the correct session key instead of falling back to the main session, so WeChat (and other channel) session-key callbacks reach the intended subagent session. ([#​90231](openclaw/openclaw#90231)) Thanks [@​zhangguiping-xydt](https://github.com/zhangguiping-xydt). - Cron: preserve model, fallback, thinking, timeout, light-context, unsafe-content, and tool allow-list overrides on implicit text payloads by promoting them to agent turns, while explicit system events still prune those fields. Fixes [#​28905](openclaw/openclaw#28905); carries forward [#​64060](openclaw/openclaw#64060) and [#​73946](openclaw/openclaw#73946). Thanks [@​liaoandi](https://github.com/liaoandi). - QQBot delivery: keep markdown table chunks self-contained across message boundaries by preserving table state across block deliveries, flushing unfinished table-row fragments as plain text, and detecting short pipe-terminated rows by column count so split rows are not sent as malformed markdown. ([#​92428](openclaw/openclaw#92428)) Thanks [@​sliverp](https://github.com/sliverp). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xMDEuMSIsInVwZGF0ZWRJblZlciI6IjQzLjEwMS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJ0eXBlL3BhdGNoIl19--> Reviewed-on: https://git.erwanleboucher.dev/eleboucher/homelab/pulls/1144
Summary
openclaw cron status/openclaw cron list --json) can fail withgateway closed (1000):when the first WebSocket connection closes with code1000and an empty reason beforehello-ok, even though the client would immediately reconnect and complete the handshake successfully.executeGatewayRequestWithScopes(...)now tracks whetherhello-okhas been seen and ignores only a pre-hello close with code1000and an empty reason;GatewayClient.connecttreats that same transient connect error as non-fatal so the existing reconnect logic can complete; added focused tests covering both the one-shot call path and the client reconnect behavior.(AI-assisted: drafted and iterated with an OpenClaw workspace agent; changes and tests were reviewed and verified by a human.)
Change Type (select all)
Scope (select all touched areas)
Linked Issue/PR
1000closes on CLI gateway callsRoot Cause / Regression History (if applicable)
executeGatewayRequestWithScopes) treated anyonCloseevent as terminal, even if it happened beforehello-ok. In some environments, the underlying WebSocket stack can emit a transient1000close with an empty reason during the initial handshake, whileGatewayClientreconnects and later completeshellosuccessfully.hello-okhad been seen and did not special-case this transient1000path.openclaw cron status/listwithgateway closed (1000):even though the gateway is reachable and the Control UI can talk to it.Regression Test Plan (if applicable)
src/gateway/call.test.ts: new test ensuringcallGateway({ method: "health" })waits through a transient pre-hello1000close and resolves successfully oncehello-okarrives.src/gateway/client.test.ts: new test ensuringGatewayClientsuppresses the spuriousgateway connect failed: ... (1000)log +onConnectErrorcallback when a pre-hello1000close is followed by a successful reconnect andhello-ok.1000+ empty-reason close should not fail early; it should wait for the reconnect and complete normally.onConnectErrorwhen the reconnect ultimately succeeds.GatewayClientconnect path. Unit-level tests against these two entry points are sufficient to prevent future regressions in this exact transient-close path without requiring heavier end-to-end scenarios.User-visible / Behavior Changes
callGateway/executeGatewayRequestWithScopesare more robust against a specific transient handshake pattern: a pre-hello WebSocket close with code1000and an empty reason.openclaw cron statusandopenclaw cron list --jsonshould no longer fail sporadically withgateway closed (1000):on otherwise healthy gateways.Security Impact (required)
Yes/No) NoYes/No) NoYes/No) NoYes/No) NoYes/No) NoIf any
Yes, explain risk + mitigation: N/ARepro + Verification
Environment
openclaw cron)Steps
openclaw cron statusoropenclaw cron list --jsonrepeatedly in an environment where the WebSocket stack occasionally emits a transient pre-hello1000+ empty-reason close.gateway closed (1000):even though the Control UI and direct WebSocket loopback remain healthy.Expected
1000+ empty-reason close, wait for the reconnect, and succeed normally when the gateway is healthy.Actual
gateway closed (1000):on the first handshake, despite the gateway being healthy and reconnects succeeding under the hood.Evidence
1000close pattern and confirm the corrected behavior)Human Verification (required)
What you personally verified (not just CI), and how:
corepack pnpm exec vitest run --config vitest.gateway.config.ts src/gateway/call.test.ts src/gateway/client.test.tson the patched branch.openclaw cron statusandopenclaw cron list --jsonno longer fail withgateway closed (1000):when the gateway is healthy.pre-hello + code 1000 + empty reasonpath is suppressed; other close codes or non-empty reasons still fail the call as before.pnpm build && pnpm check && pnpm testfor the entire monorepo; this PR focuses on gateway client + call behavior and is covered by targeted gateway tests.Review Conversations
Compatibility / Migration
Yes/No) YesYes/No) NoYes/No) NoIf yes, exact upgrade steps: N/A
Failure Recovery (if this breaks)
fbe47e1874(or the PR merge commit) to restore the priorexecuteGatewayRequestWithScopesandGatewayClient.connectbehavior.src/gateway/call.tssrc/gateway/client.tssrc/gateway/call.test.tssrc/gateway/client.test.ts1000close starts occurring in the wild, CLI callers might now see a timeout instead of an immediategateway closed (1000):error for that specific pattern.Risks and Mitigations
1000+ empty-reason close as transient, causing the CLI to wait for a reconnect that never meaningfully succeeds and eventually hit a timeout instead of failing immediately.pre-hello + code 1000 + empty reason. Any close with a reason, any non-1000code, or any close afterhello-okstill fails the call as before. Timeouts are unchanged, so a genuinely broken gateway still propagates as a failure rather than silently succeeding.GatewayClient.connectstring match for the transientgateway closed (1000):error.src/gateway/client.test.tsexercise this behavior explicitly; if the error message shape changes in the future, the tests should fail and force an update to the matching logic or a move to more structured error signaling.