feat(slack): add configurable thread implicit mentions#54414
feat(slack): add configurable thread implicit mentions#54414Alfie-longhui-Lin wants to merge 3 commits intoopenclaw:mainfrom
Conversation
Greptile SummaryThis PR adds a new The change is small, well-scoped, and backward-compatible:
One minor observation: Confidence Score: 5/5
Reviews (1): Last reviewed commit: "feat(slack): add configurable thread imp..." | Re-trigger Greptile |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 90f541830a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Need this! |
8f5bdc1 to
fc5e828
Compare
Summary
autoReplyOnParticipation, to control whether thread participation should continue to count as an implicit mention.false.Change Type (select all)
Scope (select all touched areas)
Linked Issue/PR
Root Cause / Regression History (if applicable)
requireMention.git blame, prior PR, issue, or refactor if known): reported in [Feature]: Add opt-out config for thread participation auto-reply (#29165) #31728.Regression Test Plan (if applicable)
extensions/slack/src/monitor.tool-result.test.tschannels.slack.thread.autoReplyOnParticipationis explicitly set tofalse.User-visible / Behavior Changes
channels.slack.thread.autoReplyOnParticipationtrue, so existing Slack behavior is preservedfalse, each Slack thread reply must explicitly mention the bot to trigger a responseSecurity Impact (required)
No)No)No)No)No)Yes, explain risk + mitigation:Repro + Verification
Environment
channels.slack.channels.C1.requireMention=trueSteps
requireMention: true.channels.slack.thread.autoReplyOnParticipation: false.Expected
autoReplyOnParticipation: false: non-mentioned thread replies should not trigger the bot.Actual
Evidence
Human Verification (required)
channels.slack.thread.autoReplyOnParticipation=falserequires an explicit mention for later thread repliesReview Conversations
Compatibility / Migration
Yes)Yes)No)Failure Recovery (if this breaks)
channels.slack.thread.autoReplyOnParticipationRisks and Mitigations
true, and tests cover both the default path and the explicit opt-out pathMade with Cursor