Greptile Summary

This PR correctly propagates the original run trigger (sourceTrigger) into overflow-compaction rebuilds so that cron-originated sessions properly suppress heartbeat prompt reinjection during compaction. The implementation is clean and well-scoped across three files.

Changes:

• compact.ts: adds sourceTrigger?: EmbeddedRunTrigger to CompactEmbeddedPiSessionParams and introduces shouldInjectHeartbeatPromptDuringCompaction, which gates heartbeat prompt injection on both isDefaultAgent and the existing shouldInjectHeartbeatPromptForTrigger policy lookup
• run.ts: threads params.trigger as sourceTrigger into the overflow compaction call — a single-line, targeted fix
• compact.hooks.test.ts: adds regression coverage for the new policy function; one test description is slightly misleading (see inline comment)

Issues found:

• P2 style: the second assertion in "preserves heartbeat prompt rebuilds for non-cron compaction" actually tests the isDefaultAgent: false guard path, not the non-cron scenario, and the false result contradicts the "preserves" framing in the test name

Confidence Score: 5/5

• Safe to merge — the logic change is minimal and correct, and is covered by regression tests.
• The production-code changes are small and precisely targeted: one new optional field on a params type, one small guard function, and one line in the overflow-compaction call site. The new function delegates to the already-tested shouldInjectHeartbeatPromptForTrigger policy and adds no branching risk. The only open item is a P2 test-description quality issue that does not affect runtime correctness.
• No files require special attention.

This is a comment left during a code review.
Path: src/agents/pi-embedded-runner/compact.hooks.test.ts
Line: 120-133

Comment:
**Misleading test description and assertion**

The second assertion in this test — `{ isDefaultAgent: false, sourceTrigger: "cron" }` → `false` — returns `false` because `isDefaultAgent` is `false`, not because the trigger is non-cron. It doesn't validate the "preserves heartbeat prompt rebuilds for non-cron compaction" claim stated in the test title, and actually contradicts the "preserves" framing (the heartbeat prompt is not injected here). Consider splitting this into its own test that describes what it actually covers:

```suggestion
  it("preserves heartbeat prompt rebuilds for non-cron compaction", () => {
    expect(
      compactTesting.shouldInjectHeartbeatPromptDuringCompaction({
        isDefaultAgent: true,
        sourceTrigger: "memory",
      }),
    ).toBe(true);
  });

  it("does not inject heartbeat prompt for non-default agents", () => {
    expect(
      compactTesting.shouldInjectHeartbeatPromptDuringCompaction({
        isDefaultAgent: false,
        sourceTrigger: "cron",
      }),
    ).toBe(false);
  });
```

How can I resolve this? If you propose a fix, please make it concise.

_{Reviews (1): Last reviewed commit: "fix(agents): preserve cron heartbeat sup..." | Re-trigger Greptile}

Follow-up pushed in f03453e368 to tighten the review nits:

• split the non-default-agent assertion into its own test so the description matches the behavior
• added an overflow-compaction regression that asserts sourceTrigger: "cron" is preserved end-to-end
• documented the conservative fallback when sourceTrigger is absent

That should cover both the wording nit and the missing regression-path coverage.