perf(ci): gate install smoke on changed-smoke#52458
Merged
vincentkoc merged 1 commit intomainfrom Mar 22, 2026
Merged
Conversation
openclaw-barnacle
bot
added
docs
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 769508d616
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+20
to
+21
| const CHANGED_SMOKE_SCOPE_RE = | ||
| /^(Dockerfile$|\.npmrc$|package\.json$|pnpm-lock\.yaml$|pnpm-workspace\.yaml$|scripts\/install\.sh$|scripts\/test-install-sh-docker\.sh$|scripts\/docker\/|extensions\/[^/]+\/package\.json$|\.github\/workflows\/install-smoke\.yml$|\.github\/actions\/setup-node-env\/action\.yml$)/; |
There was a problem hiding this comment.
The new CHANGED_SMOKE_SCOPE_RE is too narrow for the install-smoke workflow it gates: PRs that only change Docker build-context inputs (for example .dockerignore, patches/**, or plugin manifests like extensions/*/openclaw.plugin.json) currently produce run_changed_smoke=false, so install-smoke is skipped by .github/workflows/install-smoke.yml even though that job builds Dockerfile with context: . and validates matrix plugin discovery. This creates a blind spot where install/container regressions can merge without the smoke checks that previously ran for non-doc changes.
Useful? React with 👍 / 👎.
Contributor
Greptile SummaryThis PR gates
Confidence Score: 4/5
Prompt To Fix All With AIThis is a comment left during a code review.
Path: .github/workflows/install-smoke.yml
Line: 40-42
Comment:
**Draft-PR guard missing on `changed-smoke`**
`docs-scope` has an explicit draft guard (`if: github.event_name != 'pull_request' || !github.event.pull_request.draft`), so it is *skipped* for draft PRs. When a needed job is skipped, GitHub Actions still evaluates the dependent job's own `if`; here `needs.docs-scope.outputs.docs_only` becomes `''`, and `'' != 'true'` is `true`, so `changed-smoke` **runs** on every draft PR (including `converted_to_draft` events). This spins up a `blacksmith-16vcpu-ubuntu-2404` runner for a scope check that has no downstream effect because `install-smoke` is still guarded by the draft check.
Adding the same guard keeps the two gate jobs consistent:
```suggestion
changed-smoke:
needs: [docs-scope]
if: (github.event_name != 'pull_request' || !github.event.pull_request.draft) && needs.docs-scope.outputs.docs_only != 'true'
```
How can I resolve this? If you propose a fix, please make it concise.
---
This is a comment left during a code review.
Path: scripts/ci-changed-scope.mjs
Line: 9
Comment:
**`INSTALL_SMOKE_WORKFLOW_SCOPE_RE` is redundant**
`CHANGED_SMOKE_SCOPE_RE` (line 21) already includes `\.github\/workflows\/install-smoke\.yml$`, so the dedicated `INSTALL_SMOKE_WORKFLOW_SCOPE_RE` constant and the separate `if` block at lines 70-72 are both dead code — `runChangedSmoke` is always set to `true` for this path by the broader `CHANGED_SMOKE_SCOPE_RE` check that comes after it. The constant and the early check can safely be removed to avoid confusion about why the same path is guarded twice.
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "perf(ci): gate install smoke on changed-..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+40
to
+42
| changed-smoke: | ||
| needs: [docs-scope] | ||
| if: (github.event_name != 'pull_request' || !github.event.pull_request.draft) && needs.docs-scope.outputs.docs_only != 'true' | ||
| if: needs.docs-scope.outputs.docs_only != 'true' |
Contributor
There was a problem hiding this comment.
changed-smoke
docs-scope has an explicit draft guard (if: github.event_name != 'pull_request' || !github.event.pull_request.draft), so it is skipped for draft PRs. When a needed job is skipped, GitHub Actions still evaluates the dependent job's own if; here needs.docs-scope.outputs.docs_only becomes '', and '' != 'true' is true, so changed-smoke runs on every draft PR (including converted_to_draft events). This spins up a blacksmith-16vcpu-ubuntu-2404 runner for a scope check that has no downstream effect because install-smoke is still guarded by the draft check.
Adding the same guard keeps the two gate jobs consistent:
Suggested change
| changed-smoke: | |
| needs: [docs-scope] | |
| if: (github.event_name != 'pull_request' || !github.event.pull_request.draft) && needs.docs-scope.outputs.docs_only != 'true' | |
| if: needs.docs-scope.outputs.docs_only != 'true' | |
| changed-smoke: | |
| needs: [docs-scope] | |
| if: (github.event_name != 'pull_request' || !github.event.pull_request.draft) && needs.docs-scope.outputs.docs_only != 'true' |
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/install-smoke.yml
Line: 40-42
Comment:
**Draft-PR guard missing on `changed-smoke`**
`docs-scope` has an explicit draft guard (`if: github.event_name != 'pull_request' || !github.event.pull_request.draft`), so it is *skipped* for draft PRs. When a needed job is skipped, GitHub Actions still evaluates the dependent job's own `if`; here `needs.docs-scope.outputs.docs_only` becomes `''`, and `'' != 'true'` is `true`, so `changed-smoke` **runs** on every draft PR (including `converted_to_draft` events). This spins up a `blacksmith-16vcpu-ubuntu-2404` runner for a scope check that has no downstream effect because `install-smoke` is still guarded by the draft check.
Adding the same guard keeps the two gate jobs consistent:
```suggestion
changed-smoke:
needs: [docs-scope]
if: (github.event_name != 'pull_request' || !github.event.pull_request.draft) && needs.docs-scope.outputs.docs_only != 'true'
```
How can I resolve this? If you propose a fix, please make it concise.| const DOCS_PATH_RE = /^(docs\/|.*\.mdx?$)/; | ||
| const SKILLS_PYTHON_SCOPE_RE = /^(skills\/|pyproject\.toml$)/; | ||
| const CI_WORKFLOW_SCOPE_RE = /^\.github\/workflows\/ci\.yml$/; | ||
| const INSTALL_SMOKE_WORKFLOW_SCOPE_RE = /^\.github\/workflows\/install-smoke\.yml$/; |
Contributor
There was a problem hiding this comment.
INSTALL_SMOKE_WORKFLOW_SCOPE_RE is redundant
CHANGED_SMOKE_SCOPE_RE (line 21) already includes \.github\/workflows\/install-smoke\.yml$, so the dedicated INSTALL_SMOKE_WORKFLOW_SCOPE_RE constant and the separate if block at lines 70-72 are both dead code — runChangedSmoke is always set to true for this path by the broader CHANGED_SMOKE_SCOPE_RE check that comes after it. The constant and the early check can safely be removed to avoid confusion about why the same path is guarded twice.
Prompt To Fix With AI
This is a comment left during a code review.
Path: scripts/ci-changed-scope.mjs
Line: 9
Comment:
**`INSTALL_SMOKE_WORKFLOW_SCOPE_RE` is redundant**
`CHANGED_SMOKE_SCOPE_RE` (line 21) already includes `\.github\/workflows\/install-smoke\.yml$`, so the dedicated `INSTALL_SMOKE_WORKFLOW_SCOPE_RE` constant and the separate `if` block at lines 70-72 are both dead code — `runChangedSmoke` is always set to `true` for this path by the broader `CHANGED_SMOKE_SCOPE_RE` check that comes after it. The constant and the early check can safely be removed to avoid confusion about why the same path is guarded twice.
How can I resolve this? If you propose a fix, please make it concise.
frankekn
pushed a commit
to artwalker/openclaw
that referenced
this pull request
Mar 23, 2026
furaul
pushed a commit
to furaul/openclaw
that referenced
this pull request
Mar 24, 2026
alexey-pelykh
pushed a commit
to remoteclaw/remoteclaw
that referenced
this pull request
Mar 25, 2026
(cherry picked from commit 4bd90f2)
alexey-pelykh
added a commit
to remoteclaw/remoteclaw
that referenced
this pull request
Mar 25, 2026
* fix(ci): stop serializing push workflow runs (cherry picked from commit 0a20c5c) * test: harden path resolution test helpers (cherry picked from commit 1ad47b8) * Fix launcher startup regressions (openclaw#48501) * Fix launcher startup regressions * Fix CI follow-up regressions * Fix review follow-ups * Fix workflow audit shell inputs * Handle require resolve gaxios misses (cherry picked from commit 313e5bb) * refactor(scripts): move container setup entrypoints (cherry picked from commit 46ccbac) * perf(ci): gate install smoke on changed-smoke (openclaw#52458) (cherry picked from commit 4bd90f2) * Docs: prototype generated plugin SDK reference (openclaw#51877) * Chore: unblock synced main checks * Docs: add plugin SDK docs implementation plan * Docs: scaffold plugin SDK reference phase 1 * Docs: mark plugin SDK reference surfaces unstable * Docs: prototype generated plugin SDK reference * docs(plugin-sdk): replace generated reference with api baseline * docs(plugin-sdk): drop generated reference plan * docs(plugin-sdk): align api baseline flow with config docs --------- Co-authored-by: Onur <[email protected]> Co-authored-by: Vincent Koc <[email protected]> (cherry picked from commit 4f1e12a) * fix(ci): harden docker builds and unblock config docs (cherry picked from commit 9f08af1) * Docs: add config drift baseline statefile (openclaw#45891) * Docs: add config drift statefile generator * Docs: generate config drift baseline * CI: move config docs drift runner into workflow sanity * Docs: emit config drift baseline json * Docs: commit config drift baseline json * Docs: wire config baseline into release checks * Config: fix baseline drift walker coverage * Docs: regenerate config drift baselines (cherry picked from commit cbec476) * Release: add plugin npm publish workflow (openclaw#47678) * Release: add plugin npm publish workflow * Release: make plugin publish scope explicit (cherry picked from commit d41c9ad) * build: default to Node 24 and keep Node 22 compat (cherry picked from commit deada7e) * ci(android): use explicit flavor debug tasks (cherry picked from commit 0c2e6fe) * ci: harden pnpm sticky cache on PRs (cherry picked from commit 29b36f8) * CI: add built plugin singleton smoke (openclaw#48710) (cherry picked from commit 5a2a4ab) * chore: add code owners for npm release paths (cherry picked from commit 5c9fae5) * test add extension plugin sdk boundary guards (cherry picked from commit 77fb258) * ci: tighten cache docs and node22 gate (cherry picked from commit 797b6fe) * ci: add npm release workflow and CalVer checks (openclaw#42414) (thanks @onutc) (cherry picked from commit 8ba1b6e) * CI: add CLI startup memory regression check (cherry picked from commit c0e0115) * Add bad-barnacle label to prevent barnacle closures. (openclaw#51945) (cherry picked from commit c449a0a) * ci: speed up scoped workflow lanes (cherry picked from commit d17490f) * ci: restore PR pnpm cache fallback (cherry picked from commit e1d0545) * CI: guard gateway watch against duplicate runtime regressions (openclaw#49048) (cherry picked from commit f036ed2) * fix: correct domain reference in docker setup script * fix: adapt cherry-picks for fork TS strictness * fix: adapt cherry-picked tests for fork structure - Dockerfile test: OPENCLAW_ → REMOTECLAW_ ARG names - ci-changed-scope test: add missing runChangedSmoke field - doc-baseline test: rename to e2e (needs dist/ build artifacts) - extension boundary test: update baselines and expectations for fork * fix: adjust ci-changed-scope test for fork's narrower skills regex --------- Co-authored-by: Vincent Koc <[email protected]> Co-authored-by: Peter Steinberger <[email protected]> Co-authored-by: Tak Hoffman <[email protected]> Co-authored-by: Bob <[email protected]> Co-authored-by: Onur <[email protected]> Co-authored-by: Altay <[email protected]> Co-authored-by: Ayaan Zaidi <[email protected]> Co-authored-by: Onur Solmaz <[email protected]> Co-authored-by: Harold Hunt <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing