Skip to content

refactor(plugins): route Slack runtime through plugin sdk#51766

Merged
scoootscooob merged 1 commit intoopenclaw:mainfrom
scoootscooob:codex/slack-runtime-plugin-sdk
Mar 21, 2026
Merged

refactor(plugins): route Slack runtime through plugin sdk#51766
scoootscooob merged 1 commit intoopenclaw:mainfrom
scoootscooob:codex/slack-runtime-plugin-sdk

Conversation

@scoootscooob
Copy link
Copy Markdown
Contributor

Summary

  • route src/plugins/runtime/runtime-slack-ops.runtime.ts through src/plugin-sdk/slack.ts
  • remove the stale Slack entry from the plugin-extension import boundary inventory
  • reduce the remaining grandfathered direct imports from 5 to 4

Testing

  • pnpm lint:plugins:no-extension-imports
  • pnpm test -- src/plugin-sdk/runtime-api-guardrails.test.ts
  • pnpm test -- extensions/slack/src/channel.test.ts
  • node --import tsx - <<'EON'
    import { createRuntimeSlack } from './src/plugins/runtime/runtime-slack.ts';
    const runtime = createRuntimeSlack();
    console.log(JSON.stringify({
    hasListGroups: typeof runtime.listDirectoryGroupsLive === 'function',
    hasListPeers: typeof runtime.listDirectoryPeersLive === 'function',
    hasProbe: typeof runtime.probeSlack === 'function',
    hasResolveChannel: typeof runtime.resolveChannelAllowlist === 'function',
    hasResolveUser: typeof runtime.resolveUserAllowlist === 'function',
    hasSend: typeof runtime.sendMessageSlack === 'function',
    hasMonitor: typeof runtime.monitorSlackProvider === 'function',
    hasAction: typeof runtime.handleSlackAction === 'function'
    }, null, 2));
    EON

@openclaw-barnacle openclaw-barnacle bot added size: XS maintainer Maintainer-authored PR labels Mar 21, 2026
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Mar 21, 2026

Greptile Summary

This is a clean architectural refactor that routes the Slack runtime operations through the plugin SDK boundary (src/plugin-sdk/slack.ts) instead of importing directly from the extension (extensions/slack/runtime-api.js). No runtime behavior changes — plugin-sdk/slack.ts already re-exports the same 8 symbols from the same underlying source.

  • src/plugins/runtime/runtime-slack-ops.runtime.ts: single-line import path change; all required symbols verified present in plugin-sdk/slack.ts
  • test/fixtures/plugin-extension-import-boundary-inventory.json: correctly removes the now-resolved Slack entry, reducing the grandfathered direct-import count from 5 to 4

Confidence Score: 5/5

  • Safe to merge — pure re-routing through the plugin SDK with no behavioral changes.
  • All 8 imported symbols are confirmed present in plugin-sdk/slack.ts (re-exported from the same extensions/slack/runtime-api.js origin), the inventory fixture is correctly updated, and the change is a one-line diff with no logic modifications.
  • No files require special attention.

Last reviewed commit: "refactor: route Slac..."

@scoootscooob scoootscooob self-assigned this Mar 21, 2026
@scoootscooob scoootscooob merged commit 6516cfa into openclaw:main Mar 21, 2026
40 checks passed
mrosmarin added a commit to mrosmarin/openclaw that referenced this pull request Mar 21, 2026
* main: (516 commits)
  fix: use content hash for memory flush dedup instead of compactionCount (openclaw#30115) (openclaw#34222)
  fix(tts): add matrix to VOICE_BUBBLE_CHANNELS (openclaw#37080)
  feat(memory): pluggable system prompt section for memory plugins (openclaw#40126)
  fix: detect nvm services from installed command (openclaw#51146)
  fix: handle Linux nvm CA env before startup (openclaw#51146) (thanks @GodsBoy)
  refactor: route Telegram runtime through plugin sdk (openclaw#51772)
  refactor: route iMessage runtime through plugin sdk (openclaw#51770)
  refactor: route Slack runtime through plugin sdk (openclaw#51766)
  refactor(doctor): extract provider and shared config helpers (openclaw#51753)
  Fix Discord `/codex_resume` picker expiration (openclaw#51260)
  fix(ci): remove duplicate embedding default export
  fix(ci): restore embedding defaults and plugin boundaries
  fix: compaction safeguard summary budget (openclaw#27727)
  web UI: fix context notice using accumulated inputTokens instead of prompt snapshot (openclaw#51721)
  fix(status): skip cold-start status probes
  refactor(doctor): extract telegram provider warnings (openclaw#51704)
  fix(telegram): default fresh setups to mention-gated groups
  docs(changelog): note telegram doctor first-run guidance
  fix(doctor): add telegram first-run guidance
  fix(doctor): suppress telegram fresh-install group warning
  ...
JohnJAS pushed a commit to JohnJAS/openclaw that referenced this pull request Mar 22, 2026
pholpaphankorn pushed a commit to pholpaphankorn/openclaw that referenced this pull request Mar 22, 2026
frankekn pushed a commit to artwalker/openclaw that referenced this pull request Mar 23, 2026
furaul pushed a commit to furaul/openclaw that referenced this pull request Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer Maintainer-authored PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant