Skip to content

test: refresh plugin import boundary baseline#51434

Merged
scoootscooob merged 1 commit intoopenclaw:mainfrom
scoootscooob:codex/plugin-boundary-baseline
Mar 21, 2026
Merged

test: refresh plugin import boundary baseline#51434
scoootscooob merged 1 commit intoopenclaw:mainfrom
scoootscooob:codex/plugin-boundary-baseline

Conversation

@scoootscooob
Copy link
Copy Markdown
Contributor

Summary

Describe the problem and fix in 2-5 bullets:

  • Problem: the plugin import-boundary tripwire baseline still expected src/plugins/runtime/runtime-matrix.ts to import extensions/matrix/runtime-api.js directly.
  • Why it matters: runtime-matrix.ts already routes through runtime-matrix-boundary.ts, so the stale baseline made CI fail even though the code now follows the intended plugin boundary direction.
  • What changed: removed the stale Matrix entry from test/fixtures/plugin-extension-import-boundary-inventory.json.
  • What did NOT change (scope boundary): this does not relax the tripwire rule or change plugin runtime behavior; it only refreshes the checked-in inventory to match current architecture.

Change Type (select all)

  • Bug fix
  • Feature
  • Refactor
  • Docs
  • Security hardening
  • Chore/infra

Scope (select all touched areas)

  • Gateway / orchestration
  • Skills / tool execution
  • Auth / tokens
  • Memory / storage
  • Integrations
  • API / contracts
  • UI / DX
  • CI/CD / infra

Linked Issue/PR

User-visible / Behavior Changes

None.

Security Impact (required)

  • New permissions/capabilities? (No)
  • Secrets/tokens handling changed? (No)
  • New/changed network calls? (No)
  • Command/tool execution surface changed? (No)
  • Data access scope changed? (No)
  • If any Yes, explain risk + mitigation:

Repro + Verification

Environment

  • OS: macOS
  • Runtime/container: Node 22 / pnpm
  • Model/provider: not applicable
  • Integration/channel (if any): plugin runtime boundary inventory
  • Relevant config (redacted): none

Steps

  1. Run pnpm lint:plugins:no-extension-imports on current main.
  2. Observe the stale baseline entry for src/plugins/runtime/runtime-matrix.ts.
  3. Refresh the inventory by removing the outdated Matrix entry and rerun the lint.

Expected

  • The import-boundary lint should match the actual current src/plugins/** inventory.

Actual

  • Before this patch, the baseline still expected a Matrix direct extension import that no longer exists.

Evidence

Attach at least one:

  • Failing test/log before + passing after
  • Trace/log snippets
  • Screenshot/recording
  • Perf numbers (if relevant)

Human Verification (required)

What you personally verified (not just CI), and how:

  • Verified scenarios:
    • pnpm lint:plugins:no-extension-imports
    • full pre-commit gate via scripts/committer, including pnpm check
  • Edge cases checked:
    • confirmed src/plugins/runtime/runtime-matrix.ts now imports ./runtime-matrix-boundary.js, not extensions/matrix/runtime-api.js
    • confirmed the tripwire still reports the remaining intentional boundary entries and matches baseline
  • What you did not verify:
    • full remote GitHub Actions matrix

Review Conversations

  • I replied to or resolved every bot review conversation I addressed in this PR.
  • I left unresolved only the conversations that still need reviewer or maintainer judgment.

If a bot review conversation is addressed by this PR, resolve that conversation yourself. Do not leave bot review conversation cleanup for maintainers.

Compatibility / Migration

  • Backward compatible? (Yes)
  • Config/env changes? (No)
  • Migration needed? (No)
  • If yes, exact upgrade steps:

Failure Recovery (if this breaks)

  • How to disable/revert this change quickly: revert commit 7705b7bdcf278d61db306269627c2973f6f0907e
  • Files/config to restore:
    • test/fixtures/plugin-extension-import-boundary-inventory.json
  • Known bad symptoms reviewers should watch for:
    • the tripwire reporting a new unexpected or missing plugin boundary entry after merge

Risks and Mitigations

List only real risks for this PR. Add/remove entries as needed. If none, write None.

  • Risk: the inventory could drift again if plugin runtime boundary changes land without refreshing the fixture.
    • Mitigation: this PR restores the fixture to match current architecture, and the tripwire will keep surfacing future drift.

@openclaw-barnacle openclaw-barnacle bot added size: XS maintainer Maintainer-authored PR labels Mar 21, 2026
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Mar 21, 2026

Greptile Summary

This chore PR removes a single stale entry from the plugin import-boundary tripwire baseline (test/fixtures/plugin-extension-import-boundary-inventory.json). The removed entry expected src/plugins/runtime/runtime-matrix.ts to directly import extensions/matrix/runtime-api.js, but that import was already replaced by a boundary-respecting indirection through runtime-matrix-boundary.ts in an earlier PR. The fixture now accurately reflects the current state of src/plugins/** imports.

  • Removed the stale runtime-matrix.ts → extensions/matrix/runtime-api.js entry from the inventory baseline.
  • Confirmed that src/plugins/runtime/runtime-matrix.ts now imports only from ./runtime-matrix-boundary.js, never directly from the extension.
  • No tripwire logic, plugin runtime behavior, or other files were changed.
  • The remaining seven entries in the fixture are untouched and still valid.

Confidence Score: 5/5

  • This PR is safe to merge — it removes a single stale fixture entry with no behavior or logic changes.
  • The change is a one-entry JSON deletion that brings a checked-in test fixture back in sync with code that was already refactored. The source file (runtime-matrix.ts) has been verified to no longer contain the direct extension import, the remaining fixture entries are untouched, and there is no risk of relaxing the tripwire rule itself.
  • No files require special attention.

Last reviewed commit: "test: refresh plugin..."

@scoootscooob scoootscooob merged commit 43513cd into openclaw:main Mar 21, 2026
27 of 39 checks passed
JohnJAS pushed a commit to JohnJAS/openclaw that referenced this pull request Mar 22, 2026
pholpaphankorn pushed a commit to pholpaphankorn/openclaw that referenced this pull request Mar 22, 2026
frankekn pushed a commit to artwalker/openclaw that referenced this pull request Mar 23, 2026
furaul pushed a commit to furaul/openclaw that referenced this pull request Mar 24, 2026
Interstellar-code pushed a commit to Interstellar-code/operator1 that referenced this pull request Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer Maintainer-authored PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant