Greptile Summary

This PR reverts a one-line regression introduced in commit 91104ac740 that narrowed the Azure URL guard from isAzure (covering both *.openai.azure.com and *.services.ai.azure.com) to isAzureOpenAi (only *.openai.azure.com), causing Azure AI Foundry endpoints to fall back to resolveProviderApi(compatibility) instead of always using "openai-responses". The fix and the corresponding test update are correct.

• Core fix (onboard-custom.ts line 689): isAzureOpenAi → isAzure restores "openai-responses" for all Azure-hosted URLs, including Azure AI Foundry (*.services.ai.azure.com).
• Dead variable: const isAzureOpenAi on line 622 is now unused and should be removed.
• Test description: The updated test case is titled "keeps selected compatibility for Azure AI Foundry URLs" but actually verifies the opposite — the compatibility param is overridden; the name should be updated to reflect this.

Confidence Score: 4/5

• Safe to merge — correct targeted revert of a regression with a matching test update; only minor cleanup items remain.
• The change is a minimal, well-understood revert of a single variable reference. The regression root cause is clearly identified and the fix directly addresses it. The only gaps are a leftover unused isAzureOpenAi variable and a misleading test name, neither of which affects runtime behaviour.
• No files require special attention beyond cleaning up the unused isAzureOpenAi variable in src/commands/onboard-custom.ts.

This is a comment left during a code review.
Path: src/commands/onboard-custom.ts
Line: 622

Comment:
**Unused variable after revert**

`isAzureOpenAi` is now declared but never referenced anywhere in the function after the change on line 689 switched back to `isAzure`. This is dead code and should be removed to avoid potential lint warnings and confusion for future readers.

```suggestion
  const isAzure = isAzureUrl(baseUrl);
  const resolvedBaseUrl = isAzure ? transformAzureConfigUrl(baseUrl) : baseUrl;
```

How can I resolve this? If you propose a fix, please make it concise.

---

This is a comment left during a code review.
Path: src/commands/onboard-custom.test.ts
Line: 497

Comment:
**Misleading test description**

The test name says "keeps selected compatibility for Azure AI Foundry URLs", but the test passes `compatibility: "openai"` and then asserts `api` is `"openai-responses"` — i.e., the compatibility is **not** kept; it is overridden. A more accurate description would be something like `"overrides compatibility with openai-responses for Azure AI Foundry URLs"`.

```suggestion
  it("overrides compatibility with openai-responses for Azure AI Foundry URLs", () => {
```

How can I resolve this? If you propose a fix, please make it concise.

_{Last reviewed commit: "fix(onboard): restor..."}

Closing as duplicate; this was superseded by #50535.