Skip to content

Slack: remove duplicate directory imports#49935

Merged
scoootscooob merged 1 commit intoopenclaw:mainfrom
scoootscooob:codex/fix-slack-duplicate-directory-import
Mar 18, 2026
Merged

Slack: remove duplicate directory imports#49935
scoootscooob merged 1 commit intoopenclaw:mainfrom
scoootscooob:codex/fix-slack-duplicate-directory-import

Conversation

@scoootscooob
Copy link
Copy Markdown
Contributor

Summary

  • remove the duplicate Slack directory helper imports from ./runtime-api.js
  • keep the direct ./directory-config.js import path that the merged fix already uses

Validation

  • pnpm test -- extensions/slack/src/channel.test.ts

Context

Pulling latest main after #49930 showed extensions/slack/src/channel.ts importing listSlackDirectoryPeersFromConfig and listSlackDirectoryGroupsFromConfig twice, which caused a parse failure before the Slack tests could run.

@openclaw-barnacle openclaw-barnacle bot added channel: slack Channel integration: slack size: XS maintainer Maintainer-authored PR labels Mar 18, 2026
@scoootscooob scoootscooob merged commit 656679e into openclaw:main Mar 18, 2026
33 of 43 checks passed
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Mar 18, 2026

Greptile Summary

This PR removes duplicate imports of listSlackDirectoryGroupsFromConfig and listSlackDirectoryPeersFromConfig from extensions/slack/src/channel.ts. After merging #49930, these two functions were being imported twice — once from ./directory-config.js (the correct canonical source) and once from ./runtime-api.js (the duplicate). The duplicate caused a parse failure that prevented Slack tests from running. The fix correctly retains only the ./directory-config.js import path.

  • Removes two redundant named imports from the ./runtime-api.js import block in channel.ts
  • No functional logic is changed; this is purely a cleanup of a duplicate-import artifact introduced by a prior merge

Confidence Score: 5/5

  • This PR is safe to merge — it is a minimal, targeted removal of duplicate import lines with no logic changes.
  • The change is a two-line removal of duplicate named imports that caused a parse failure. The correct imports from ./directory-config.js are retained, the ./runtime-api.js import block loses only the redundant entries, and no runtime behavior is affected. The fix is trivially verifiable by inspection.
  • No files require special attention.

Last reviewed commit: "Slack: remove duplic..."

livingghost pushed a commit to livingghost/openclaw that referenced this pull request Mar 18, 2026
livingghost pushed a commit to livingghost/openclaw that referenced this pull request Mar 18, 2026
livingghost pushed a commit to livingghost/openclaw that referenced this pull request Mar 18, 2026
brandontyler pushed a commit to brandontyler/clawdbot that referenced this pull request Mar 19, 2026
udftd pushed a commit to udftd/openclaw that referenced this pull request Mar 20, 2026
fuller-stack-dev pushed a commit to fuller-stack-dev/openclaw that referenced this pull request Mar 20, 2026
fuller-stack-dev pushed a commit to fuller-stack-dev/openclaw that referenced this pull request Mar 20, 2026
pholpaphankorn pushed a commit to pholpaphankorn/openclaw that referenced this pull request Mar 22, 2026
fugue1987 pushed a commit to fugue1987/openclaw that referenced this pull request Mar 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

channel: slack Channel integration: slack maintainer Maintainer-authored PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant