Greptile Summary

This PR bumps DEFAULT_HANDSHAKE_TIMEOUT_MS from 3 s to 10 s and removes the VITEST-only guard on OPENCLAW_TEST_HANDSHAKE_TIMEOUT_MS, allowing the override to be used in any environment. Both changes are straightforward and address real-world reliability issues caused by a busy event loop tripping the too-short 3 s timeout.

• Timeout increase (3 s → 10 s): Reasonable headroom for slow/loaded environments; low risk of resource exhaustion since WS handshakes are expected to be short-lived regardless.
• VITEST gate removal: Correct — the env-var override is now legitimately useful outside test runs. The only style concern is that OPENCLAW_TEST_HANDSHAKE_TIMEOUT_MS still carries a _TEST_ prefix that may confuse production operators looking for a tunable knob; consider a follow-up rename to OPENCLAW_HANDSHAKE_TIMEOUT_MS (keeping the old name as a fallback for backward compatibility).

Confidence Score: 5/5

• Safe to merge — minimal, targeted change with no logic regressions.
• The diff touches a single constants file, increases a timeout value, and removes an overly-restrictive env-var guard. No functional regressions are introduced; the only note is a cosmetic naming concern with the env var that can be addressed in a follow-up.
• No files require special attention.

This is a comment left during a code review.
Path: src/gateway/server-constants.ts
Line: 26-31

Comment:
**`_TEST_` in env var name is misleading for production use**

Now that the VITEST gate is removed and this override is intended for production users too, the name `OPENCLAW_TEST_HANDSHAKE_TIMEOUT_MS` still carries a `_TEST_` prefix that strongly implies it is a test-only knob. A user scanning their environment variables or reading docs may skip it for production tuning precisely because of that name.

Consider introducing a production-facing name (e.g. `OPENCLAW_HANDSHAKE_TIMEOUT_MS`) in a follow-up. Backward compatibility could be preserved by checking both, falling back to the old name:

```ts
if (process.env.OPENCLAW_HANDSHAKE_TIMEOUT_MS || process.env.OPENCLAW_TEST_HANDSHAKE_TIMEOUT_MS) {
  const parsed = Number(
    process.env.OPENCLAW_HANDSHAKE_TIMEOUT_MS ?? process.env.OPENCLAW_TEST_HANDSHAKE_TIMEOUT_MS
  );
  if (Number.isFinite(parsed) && parsed > 0) {
    return parsed;
  }
}
```

This is non-blocking for the current fix, but worth tracking.

How can I resolve this? If you propose a fix, please make it concise.

_{Last reviewed commit: 2792f8b}