Skip to content

CI: rename startup-memory to build-smoke#49041

Merged
Takhoffman merged 1 commit intomainfrom
codex/build-smoke-rename
Mar 17, 2026
Merged

CI: rename startup-memory to build-smoke#49041
Takhoffman merged 1 commit intomainfrom
codex/build-smoke-rename

Conversation

@Takhoffman
Copy link
Copy Markdown
Contributor

@Takhoffman Takhoffman commented Mar 17, 2026 •
edited
Loading

Summary

Describe the problem and fix in 2–5 bullets:

  • Problem: the CI smoke lane is still named startup-memory, which no longer matches its broader role.
  • Why it matters: the current name is misleading when discussing or extending post-build smoke coverage.
  • What changed: renamed the workflow job key and displayed check name from startup-memory to build-smoke in .github/workflows/ci.yml.
  • What did NOT change (scope boundary): this PR does not add or modify smoke behavior, test scripts, build outputs, or any runtime logic.

Change Type (select all)

  • Bug fix
  • Feature
  • Refactor
  • Docs
  • Security hardening
  • Chore/infra

Scope (select all touched areas)

  • Gateway / orchestration
  • Skills / tool execution
  • Auth / tokens
  • Memory / storage
  • Integrations
  • API / contracts
  • UI / DX
  • CI/CD / infra

Linked Issue/PR

User-visible / Behavior Changes

None.

Security Impact (required)

  • New permissions/capabilities? (Yes/No) No
  • Secrets/tokens handling changed? (Yes/No) No
  • New/changed network calls? (Yes/No) No
  • Command/tool execution surface changed? (Yes/No) No
  • Data access scope changed? (Yes/No) No
  • If any Yes, explain risk + mitigation:

Repro + Verification

Environment

  • OS: macOS
  • Runtime/container: local git worktree
  • Model/provider: N/A
  • Integration/channel (if any): GitHub Actions workflow config
  • Relevant config (redacted): none

Steps

  1. Check .github/workflows/ci.yml on main and locate the startup-memory job.
  2. Apply the rename so the job key and surfaced name are both build-smoke.
  3. Confirm the diff is limited to that rename.

Expected

  • The workflow exposes the lane as build-smoke and no other behavior changes are introduced.

Actual

  • The rename is isolated to .github/workflows/ci.yml.

Evidence

Attach at least one:

  • Failing test/log before + passing after
  • Trace/log snippets
  • Screenshot/recording
  • Perf numbers (if relevant)

Human Verification (required)

What you personally verified (not just CI), and how:

  • Verified scenarios: inspected the workflow diff and confirmed only the job key/name rename is present.
  • Edge cases checked: confirmed no additional scripts, steps, or unrelated files changed on this branch.
  • What you did not verify: I did not validate branch-protection status-check configuration; maintainers will need to coordinate that separately if startup-memory is currently required.

Review Conversations

  • I replied to or resolved every bot review conversation I addressed in this PR.
  • I left unresolved only the conversations that still need reviewer or maintainer judgment.

If a bot review conversation is addressed by this PR, resolve that conversation yourself. Do not leave bot review conversation cleanup for maintainers.

Compatibility / Migration

  • Backward compatible? (Yes/No) No
  • Config/env changes? (Yes/No) No
  • Migration needed? (Yes/No) Yes
  • If yes, exact upgrade steps: update any required-status-check or automation references from startup-memory to build-smoke before relying on the renamed check.

Failure Recovery (if this breaks)

  • How to disable/revert this change quickly: revert this PR to restore the old check name.
  • Files/config to restore: .github/workflows/ci.yml
  • Known bad symptoms reviewers should watch for: branch protection or automation waiting on startup-memory after the rename lands.

Risks and Mitigations

List only real risks for this PR. Add/remove entries as needed. If none, write None.

  • Risk: required status checks or automations may still reference startup-memory.
    • Mitigation: coordinate status-check and automation updates at the same time as merge, or defer merge until those references are updated.

@openclaw-barnacle openclaw-barnacle bot added size: XS maintainer Maintainer-authored PR labels Mar 17, 2026
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Mar 17, 2026

Greptile Summary

This PR renames the CI job from startup-memory to build-smoke in .github/workflows/ci.yml, updating both the job ID (line 307) and its name: field (line 308). The change is minimal and correctly scoped — the job is not referenced as a needs dependency in any other job or workflow file, so no cascading updates are required within the repository.

  • The job itself is unchanged; it still builds the project, runs CLI smoke tests, and checks startup memory via pnpm test:startup:memory.
  • Related files (scripts/check-cli-startup-memory.mjs, package.json, source files) retain startup-memory references appropriately since the underlying scripts are out of scope for this rename.
  • As noted in the PR description, if startup-memory is currently a required status check in GitHub branch-protection rules, that setting will need to be updated to build-smoke after merging — this is a GitHub UI concern and cannot be addressed in code.

Confidence Score: 5/5

  • This PR is safe to merge — it is a purely cosmetic CI job rename with no functional impact on the build or test logic.
  • The change touches exactly two lines in one file, renaming a job ID and its display name. The job has no dependents within the workflow, and no other workflow files reference the old name. The only external concern (branch-protection status checks) is called out in the PR description itself.
  • No files require special attention.

Last reviewed commit: 01e308a

@Takhoffman Takhoffman force-pushed the codex/build-smoke-rename branch from 01e308a to 5d3faa8 Compare March 17, 2026 14:30
@aisle-research-bot
Copy link
Copy Markdown

aisle-research-bot bot commented Mar 17, 2026 •
edited
Loading

🔒 Aisle Security Analysis

We found 1 potential security issue(s) in this PR:

# Severity Title
1 🔵 Low Potential required status check bypass due to GitHub Actions job rename (startup-memory → build-smoke)

1. 🔵 Potential required status check bypass due to GitHub Actions job rename (startup-memory → build-smoke)

Property Value
Severity Low
CWE CWE-693
Location .github/workflows/ci.yml:307-310

Description

The GitHub Actions CI workflow renames a job id and display name from startup-memory to build-smoke.

Why this matters:

  • In GitHub branch protection, required status checks are matched by check-run name (commonly in the form CI / <job name>).
  • Changing the job name: (and/or relying on the job id when name is absent) changes the check context that branch protection expects.
  • If branch protection rules were configured to require CI / startup-memory, this change would make that required check disappear, potentially allowing merges without running what was previously a required CI gate.

What the renamed job actually does (i.e., likely a meaningful gate):

  • Checks out the repo and sets up a Node environment
  • Builds distributable artifacts (pnpm build)
  • Runs CLI smoke tests (node openclaw.mjs --help, node openclaw.mjs status ...)
  • Runs a startup memory regression check (pnpm test:startup:memory)

Vulnerable change:

-  startup-memory:
-    name: "startup-memory"
+  build-smoke:
+    name: "build-smoke"

This is a common CI policy footgun: it is safe only if all branch protection / required checks are updated accordingly (or the display name remains stable).

Recommendation

Ensure branch protection and any external automation still require the intended CI gate.

Options:

  1. Keep the check-run name stable (recommended if startup-memory is required today) while changing only the job id:
build-smoke:
  name: "startup-memory"  # preserves required status check name
  ...

  1. If the rename is intentional, update branch protection rules to require the new check name (likely CI / build-smoke) and verify that CI / startup-memory is removed only after confirming the new required check is enforced.

  2. Add a lightweight guard step/documentation to prevent accidental renames of required checks (e.g., a comment or a dedicated "required checks" section).

Analyzed PR: #49041 at commit 5d3faa8

Last updated on: 2026-03-17T14:38:06Z

@Takhoffman Takhoffman merged commit 7cd0acf into main Mar 17, 2026
33 of 38 checks passed
@Takhoffman Takhoffman deleted the codex/build-smoke-rename branch March 17, 2026 14:53
nikolaisid pushed a commit to nikolaisid/openclaw that referenced this pull request Mar 18, 2026
@Takhoffman @nikolaisid
CI: rename startup memory smoke (openclaw#49041)
388dd36
@alexey-pelykh alexey-pelykh mentioned this pull request Mar 23, 2026
Closed
ralyodio pushed a commit to ralyodio/openclaw that referenced this pull request Apr 3, 2026
@Takhoffman @ralyodio
CI: rename startup memory smoke (openclaw#49041)
411eb1b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

maintainer Maintainer-authored PR size: XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Takhoffman