Greptile Summary

This PR extracts deriveSessionTitle into its own session-title.ts module and extends the precedence chain to include entry.label and entry.origin?.label before falling back to firstUserMessage. This directly addresses the described bug where heartbeat polls (whose first user message was "heartbeat") could overwrite a session's user-assigned label as the displayed title.

Key observations:

• Behavior change is intentional and correct: adding label/origin.label above firstUserMessage ensures persisted labels are not stomped by transcript-derived content. The SessionEntry type and SessionOrigin type both carry the label?: string field, so the new access paths are fully type-safe.
• Backward compatibility is preserved: session-utils.ts keeps both the internal import (used at line 961) and a public export { deriveSessionTitle } re-export, so all existing call sites continue to work unchanged.
• Test consolidation is clean: session-title.test.ts covers all six precedence levels, whitespace trimming, truncation, word-boundary behaviour, and the sessionId fallback. The session-utils.test.ts compatibility test (expect(deriveSessionTitle).toBe(deriveSessionTitleDirect)) correctly validates the re-export via reference equality.
• Minor: The test case "falls back to sessionId prefix without date when updatedAt missing" passes updatedAt: 0 (not undefined). The test is functionally correct — 0 is treated as falsy — but the name is slightly misleading and was carried over from the old suite.

Confidence Score: 5/5

• Safe to merge — clean refactor with backward-compatible re-export, correct type usage, and thorough test coverage for the expanded precedence chain.
• The extraction is mechanical and correct. The new label/origin.label precedence levels are type-safe (both fields exist on SessionEntry/SessionOrigin), intentional (documented in PR description as the bug fix), and well-tested. The only finding is a minor test-description wording issue that does not affect correctness.
• No files require special attention.

This is a comment left during a code review.
Path: src/gateway/session-title.test.ts
Line: 86-96

Comment:
**Misleading test name: "missing" vs. explicitly zero**

The description says `"falls back to sessionId prefix without date when updatedAt missing"`, but `updatedAt` is explicitly set to `0`, not absent (`undefined`). The `SessionEntry` type declares `updatedAt: number` (required), so `undefined` is not a valid value here — the intent is to cover the **falsy-zero** case. Consider renaming for clarity:

```suggestion
  test("falls back to sessionId prefix without date when updatedAt is zero", () => {
    const entry = {
      sessionId: "abcd1234-5678-90ef-ghij-klmnopqrstuv",
      updatedAt: 0,
    } as SessionEntry;
    const result = deriveSessionTitle(entry);
    expect(result).toBe("abcd1234");
  });
```

(This was also the description in the original test copied from `session-utils.test.ts`, so this is a good opportunity to clean it up.)

How can I resolve this? If you propose a fix, please make it concise.

_{Last reviewed commit: 0605ae3}

Thanks for the context here. I did a careful shell check against current main, and the useful part of this older PR is already implemented there.

Close: the central label-preserving derived-title fix is already on current main through #98841, while this older branch’s helper extraction and origin-label fallback are broader stale leftovers rather than necessary remaining work.

Root-cause cluster
Relationship: superseded
Canonical: #98841
Summary: The merged sibling PR is the canonical current-main fix for the session-label derived-title fallback gap, so this older PR is superseded for the central bug.

Members:

• canonical: fix(gateway): include session label in deriveSessionTitle fallback chain #98841 - Merged the focused current-main label fallback fix and closed the related label display issue.
• fixed_by_candidate: [Bug]: Control UI session names can disappear even though label is still persisted #98742 - The issue describes persisted session labels being hidden by derived-title/display-name precedence and was closed when the focused PR merged.
• partial_overlap: TUI /sessions list: gateway-injected inbound metadata block used as session title (shows 'untrusted metadata' for all sessions) #39722 - Shares the gateway session-title surface but centers on inbound metadata stripping and display-name precedence rather than explicit label precedence alone.
• partial_overlap: [Feature]: Improve session derived titles to show conversation core content, not just first user message #81781 - Shares derived-title code but asks for broader title quality from summaries or later messages, which remains separate product work.
• superseded: fix: preserve labeled session titles during heartbeat polls #46209 - Older closed branch attempted similar heartbeat-label title work and has been overtaken by the merged focused fix.

Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything.

So I’m closing this older PR as already covered on main rather than keeping a mostly-duplicated branch open.

Updated the branch against current main and adjusted the title precedence to address the review risk:

• explicit entry.label now wins before transcript-derived titles
• auto-populated entry.origin?.label stays behind firstUserMessage, so unlabeled inbound DMs keep transcript-derived summaries instead of regressing to contact/conversation labels
• deriveSessionTitle remains extracted into session-title.ts with focused tests, while session-utils.ts keeps a compatibility re-export

GitHub Actions are running on the refreshed head.

Applied the review suggestion by renaming the zero timestamp case to describe the actual updatedAt: 0 input. No behavior change.

I also rebased the branch onto current main and kept the session-title tests isolated in src/gateway/session-title.test.ts with only the compatibility re-export check left in src/gateway/session-utils.test.ts.

Validation:

• pnpm test src/gateway/session-title.test.ts src/gateway/session-utils.test.ts
• git diff --check upstream/main...HEAD

Follow-up status:

• Real behavior proof now passes after adding the accepted structured proof fields.
• The remaining current failure is checks-node-auto-reply-reply-dispatch, specifically ACP dispatch tests in src/auto-reply/reply/dispatch-from-config.test.ts.
• I reproduced that same focused shard failure locally on current upstream/main with pnpm test src/auto-reply/reply/dispatch-from-config.test.ts, so it appears unrelated to this session-title test refactor.

I’m keeping this PR scoped to session-title derivation and will not expand it into the unrelated auto-reply ACP failure unless maintainers request that explicitly.

Ready for maintainer review/merge. Status recap against current HEAD 0d90c8d8:

• Mergeable / clean, CI green, no unresolved review threads.
• Both bot findings are addressed in code and resolved:
  • Greptile P2 (test name) — the zero-timestamp test now reads "omits date from sessionId fallback when updatedAt is zero".
  • Codex P2 (precedence) — firstUserMessage sits ahead of auto-populated origin.label, so unlabeled inbound DMs still get transcript-derived titles. Only explicit entry.label outranks the first user message.

Precedence at HEAD: displayName → subject → explicit label → firstUserMessage → origin.label → sessionId prefix.

@codex review

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: 0d90c8d8ce

ClawSweeper applied the proposed close for this PR.

• Action: closed this PR.
• Close reason: mostly implemented on main.
• Evidence: durable ClawSweeper review.