chore: fix formatting drift in extension sources#48758
Merged
jalehman merged 1 commit intoopenclaw:mainfrom Mar 17, 2026
Merged
chore: fix formatting drift in extension sources#48758jalehman merged 1 commit intoopenclaw:mainfrom
jalehman merged 1 commit intoopenclaw:mainfrom
Conversation
Contributor
Greptile SummaryThis PR applies
Confidence Score: 5/5
Last reviewed commit: e7f293e |
nikolaisid
pushed a commit
to nikolaisid/openclaw
that referenced
this pull request
Mar 18, 2026
Maple778
added a commit
to Maple778/openclaw
that referenced
this pull request
Mar 19, 2026
Pattern from PR openclaw#48758 The revised proposal addresses the [CRITICAL] issue by correctly reordering the export statements according to the `oxfmt` style guide (Parent imports before local imports). It addresses the [MAJOR] issue by explicitly formatting the long grouped export block (lines 28-38) onto multiple lines to satisfy max-width constraints, and reordering local exports to place star exports at the bottom. The logic remains semantically identical.
Maple778
added a commit
to Maple778/openclaw
that referenced
this pull request
Mar 19, 2026
Pattern from PR openclaw#48758 The revised proposal addresses the validation feedback by strictly correcting the typo identified in the CRITICAL issue, merging the SDK imports as requested in the MAJOR issue, and ensuring the line width remains within standard limits (approx. 100 chars) to satisfy the MINOR issue regarding line width constraints. The resulting code is cleaner, follows the `oxfmt` style guide, and resolves the CI failures.
Maple778
added a commit
to Maple778/openclaw
that referenced
this pull request
Mar 19, 2026
Pattern from PR openclaw#48758 The previous proposal was rejected because it introduced speculative imports (`Provider`, `To`) that were not present in the original file, creating a risk of 'unused import' errors. The validation feedback correctly identified that the root cause is the *ordering* of existing imports, specifically the violation of `oxfmt` grouping rules (External before Internal). I have addressed this by removing the speculative additions and strictly sorting the existing imports according to standard TypeScript/`oxfmt` conventions: 1) External/Type imports, 2) Internal imports (grouped by source), 3) Local relative imports. The export block remains untouched as it was correctly placed.
Maple778
added a commit
to Maple778/openclaw
that referenced
this pull request
Mar 19, 2026
…smatch Pattern from PR openclaw#48758 The validation issues highlighted a discrepancy in the import statement for `openclaw/plugin-sdk/provider-web-search`. The MAJOR issue correctly identified that the previous proposal incorrectly represented the state of `withTrustedWebToolsEndpoint`, showing it as added when it should have been moved/reordered. The MINOR issue emphasized that the fix relies on alphabetical sorting of imports. To address this, the 'Direct Fix' has been revised to accurately reflect the 'Old Code' (including `withTrustedWebToolsEndpoint`) and the 'New Code' (where it is moved to the top of the list alphabetically). The fix correctly splits the single-line import into a multi-line import to satisfy the `oxfmt` line width constraint.
Maple778
added a commit
to Maple778/openclaw
that referenced
this pull request
Mar 19, 2026
Fixed import ordering in multiple files to comply with oxfm style guide: - extensions/qwen-portal-auth/index.ts: Merged SDK imports - src/plugin-sdk/compat.ts: Moved export to correct position - src/plugins/provider-self-hosted-setup.ts: Reordered type imports alphabetically - extensions/firecrawl/src/firecrawl-client.ts: Moved import to top of block All changes follow alphabetical import ordering as required by oxfmt. No semantic changes—only import reordering. Pattern from PRs openclaw#48758, openclaw#49470, openclaw#48998
sbezludny
pushed a commit
to sbezludny/openclaw
that referenced
this pull request
Mar 27, 2026
alexey-pelykh
pushed a commit
to remoteclaw/remoteclaw
that referenced
this pull request
Mar 28, 2026
(cherry picked from commit 61ccc5b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR fixes source formatting drift in the extension files and contract test that are currently failing the repository's
oxfmt --checkgate onmain.Why
These formatting errors are unrelated to feature work, but they cause CI noise and can block otherwise valid PRs from landing.
Changes
oxfmtTesting
pnpm format:checkAll matched files use the correct format.