Skip to content

chore: fix formatting drift in extension sources#48758

Merged
jalehman merged 1 commit intoopenclaw:mainfrom
jalehman:codex/formatting-fixes
Mar 17, 2026
Merged

chore: fix formatting drift in extension sources#48758
jalehman merged 1 commit intoopenclaw:mainfrom
jalehman:codex/formatting-fixes

Conversation

@jalehman
Copy link
Copy Markdown
Contributor

What

This PR fixes source formatting drift in the extension files and contract test that are currently failing the repository's oxfmt --check gate on main.

Why

These formatting errors are unrelated to feature work, but they cause CI noise and can block otherwise valid PRs from landing.

Changes

  • Reordered imports to match oxfmt
  • Applied formatter line wrapping fixes
  • Fixed extension source formatting drift
  • Fixed plugin contract test formatting

Testing

  • pnpm format:check
  • Expected: All matched files use the correct format.

@openclaw-barnacle openclaw-barnacle bot added channel: discord Channel integration: discord channel: imessage Channel integration: imessage channel: signal Channel integration: signal channel: slack Channel integration: slack channel: telegram Channel integration: telegram channel: whatsapp-web Channel integration: whatsapp-web size: S maintainer Maintainer-authored PR labels Mar 17, 2026
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Mar 17, 2026

Greptile Summary

This PR applies oxfmt formatter fixes across 13 extension source files and one contract test, resolving CI formatting gate failures on main. All changes are non-functional.

  • Import reordering: openclaw/plugin-sdk/* imports are moved before relative ../../../src/... imports to match oxfmt ordering conventions across discord, google, imessage, signal, slack, telegram, and whatsapp extensions.
  • Line wrapping: Two chained await expressions in extensions/imessage/src/channel.ts are split across multiple lines to satisfy the formatter's line-length limit.
  • Import consolidation: A multi-line named import in src/plugins/contracts/loader.contract.test.ts is collapsed to a single line where it fits within the line-length limit.

Confidence Score: 5/5

  • This PR is safe to merge — all changes are purely cosmetic formatter fixes with no functional impact.
  • Every change is a mechanical import reorder or line-wrap produced by oxfmt. No logic, behaviour, or API surface was modified. The stated goal (passing pnpm format:check) is fully consistent with the diff.
  • No files require special attention.

Last reviewed commit: e7f293e

@jalehman jalehman merged commit 61ccc5b into openclaw:main Mar 17, 2026
32 of 51 checks passed
@jalehman jalehman deleted the codex/formatting-fixes branch March 17, 2026 05:43
nikolaisid pushed a commit to nikolaisid/openclaw that referenced this pull request Mar 18, 2026
Maple778 added a commit to Maple778/openclaw that referenced this pull request Mar 19, 2026
Pattern from PR openclaw#48758

The revised proposal addresses the [CRITICAL] issue by correctly reordering the export statements according to the `oxfmt` style guide (Parent imports before local imports). It addresses the [MAJOR] issue by explicitly formatting the long grouped export block (lines 28-38) onto multiple lines to satisfy max-width constraints, and reordering local exports to place star exports at the bottom. The logic remains semantically identical.
Maple778 added a commit to Maple778/openclaw that referenced this pull request Mar 19, 2026
Pattern from PR openclaw#48758

The revised proposal addresses the validation feedback by strictly correcting the typo identified in the CRITICAL issue, merging the SDK imports as requested in the MAJOR issue, and ensuring the line width remains within standard limits (approx. 100 chars) to satisfy the MINOR issue regarding line width constraints. The resulting code is cleaner, follows the `oxfmt` style guide, and resolves the CI failures.
Maple778 added a commit to Maple778/openclaw that referenced this pull request Mar 19, 2026
Pattern from PR openclaw#48758

The previous proposal was rejected because it introduced speculative imports (`Provider`, `To`) that were not present in the original file, creating a risk of 'unused import' errors. The validation feedback correctly identified that the root cause is the *ordering* of existing imports, specifically the violation of `oxfmt` grouping rules (External before Internal). I have addressed this by removing the speculative additions and strictly sorting the existing imports according to standard TypeScript/`oxfmt` conventions: 1) External/Type imports, 2) Internal imports (grouped by source), 3) Local relative imports. The export block remains untouched as it was correctly placed.
Maple778 added a commit to Maple778/openclaw that referenced this pull request Mar 19, 2026
…smatch

Pattern from PR openclaw#48758

The validation issues highlighted a discrepancy in the import statement for `openclaw/plugin-sdk/provider-web-search`. The MAJOR issue correctly identified that the previous proposal incorrectly represented the state of `withTrustedWebToolsEndpoint`, showing it as added when it should have been moved/reordered. The MINOR issue emphasized that the fix relies on alphabetical sorting of imports. To address this, the 'Direct Fix' has been revised to accurately reflect the 'Old Code' (including `withTrustedWebToolsEndpoint`) and the 'New Code' (where it is moved to the top of the list alphabetically). The fix correctly splits the single-line import into a multi-line import to satisfy the `oxfmt` line width constraint.
Maple778 added a commit to Maple778/openclaw that referenced this pull request Mar 19, 2026
Fixed import ordering in multiple files to comply with oxfm style guide:
- extensions/qwen-portal-auth/index.ts: Merged SDK imports
- src/plugin-sdk/compat.ts: Moved export to correct position
- src/plugins/provider-self-hosted-setup.ts: Reordered type imports alphabetically
- extensions/firecrawl/src/firecrawl-client.ts: Moved import to top of block

All changes follow alphabetical import ordering as required by oxfmt.
No semantic changes—only import reordering.

Pattern from PRs openclaw#48758, openclaw#49470, openclaw#48998
sbezludny pushed a commit to sbezludny/openclaw that referenced this pull request Mar 27, 2026
alexey-pelykh pushed a commit to remoteclaw/remoteclaw that referenced this pull request Mar 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

channel: discord Channel integration: discord channel: imessage Channel integration: imessage channel: signal Channel integration: signal channel: slack Channel integration: slack channel: telegram Channel integration: telegram channel: whatsapp-web Channel integration: whatsapp-web maintainer Maintainer-authored PR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant