fix(windows): add windowsHide to all Windows spawn resolution paths#48320
fix(windows): add windowsHide to all Windows spawn resolution paths#48320TerminalsandCoffee wants to merge 1 commit intoopenclaw:mainfrom
Conversation
The direct and shell-fallback resolution paths in the plugin SDK's Windows spawn resolver were missing windowsHide: true, causing visible cmd.exe console windows to flash on every ACP spawn on Windows desktop. Closes openclaw#40340 Co-Authored-By: Claude Opus 4.6 <[email protected]>
Greptile SummaryThis PR closes a Windows UX regression where every ACP spawn would flash a visible
Confidence Score: 5/5
Last reviewed commit: 8d36db3 |
|
I reviewed this change and the implementation looks sound. The patch fills the two missing Windows resolution outcomes in I also checked the surrounding call sites, and the resolved The tests line up with the change: there’s a new direct- From a code and scope perspective, this looks reasonable to land. |
Summary
windowsHide: trueto thedirectandshell-fallbackresolution paths insrc/plugin-sdk/windows-spawn.tsnode-entrypoint,exe-entrypoint) already set itwindowsHidefrom the resolution, so the fix propagates automatically.exeresolution assertingwindowsHide: truewindowsHide: truewindowsHide: trueto rawspawn()calls in test files to prevent console flash during test runs on WindowsRoot Cause
resolveWindowsSpawnProgramCandidate()only setwindowsHide: truefornode-entrypointandexe-entrypointresolutions. Thedirectpath (e.g..exefiles resolved on Windows) and theshell-fallbackpath (unresolved.cmdwrappers) leftwindowsHideasundefined, causing every ACP spawn to flash a visiblecmd.execonsole window.Test plan
pnpm vitest run extensions/acpx/src/runtime-internals/process.test.ts— 15/15 passingsets windowsHide on direct exe resolution on windowsfalls back to shell modenow assertswindowsHide: truewindowsHideis ignored on non-Windows platformsCloses #40340
🤖 Generated with Claude Code