fix(ui): avoid tmp dir fs.constants access at import time#48202
Closed
7inspire wants to merge 1 commit intoopenclaw:mainfrom
Closed
fix(ui): avoid tmp dir fs.constants access at import time#482027inspire wants to merge 1 commit intoopenclaw:mainfrom
7inspire wants to merge 1 commit intoopenclaw:mainfrom
Conversation
Contributor
Greptile SummaryThis PR fixes a browser-side blank-screen crash (issue #48062) caused by
Confidence Score: 5/5
Last reviewed commit: 3a54b1a |
19 tasks
Member
|
merged in 412811e, author credited in changelog. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tmp-openclaw-dirfs.constantsat module scopeWhy
Issue #48062 reports that the Control UI can render a blank screen because:
src/infra/tmp-openclaw-dir.tsreadsfs.constants.W_OK/X_OKat module scopenode:fsis externalized, so evaluatingfs.constantsat import time crashes before the UI mountsChanges
src/infra/tmp-openclaw-dir.tsTMP_DIR_ACCESS_MODEconstant with a lazygetTmpDirAccessMode()helperaccessSync(...)call sitesThis keeps Node runtime behavior the same while preventing browser-side import-time evaluation from crashing the bundle.
Validation
pnpm exec vitest run src/infra/tmp-openclaw-dir.test.tspnpm exec oxfmt --check src/infra/tmp-openclaw-dir.tsCloses #48062