Skip to content

Browser: support non-Chrome existing-session profiles via userDataDir#48170

Merged
velvet-shark merged 4 commits intomainfrom
codex/non-chrome-existing-session
Mar 16, 2026
Merged

Browser: support non-Chrome existing-session profiles via userDataDir#48170
velvet-shark merged 4 commits intomainfrom
codex/non-chrome-existing-session

Conversation

@velvet-shark
Copy link
Copy Markdown
Member

Summary

  • Problem: existing-session always spawned chrome-devtools-mcp with Chrome-only auto-connect defaults, so the built-in user attach flow could not target Brave, Edge, or other Chromium-based browsers.
  • Why it matters: users with a non-Chrome primary browser had no supported way to use profile="user" or other existing-session profiles even when remote debugging was enabled.
  • What changed: added browser.profiles.<name>.userDataDir, threaded it through existing-session profile resolution and Chrome MCP session creation, validated it during profile creation/availability checks, updated CLI/browser status output, and refreshed doctor/docs/tool messaging for Chromium-based browsers.
  • What did NOT change (scope boundary): default Chrome auto-connect behavior stays intact when userDataDir is unset, and managed Playwright/browser launch flows are unchanged.

Change Type (select all)

  • Bug fix
  • Feature
  • Refactor
  • Docs
  • Security hardening
  • Chore/infra

Scope (select all touched areas)

  • Gateway / orchestration
  • Skills / tool execution
  • Auth / tokens
  • Memory / storage
  • Integrations
  • API / contracts
  • UI / DX
  • CI/CD / infra

Linked Issue/PR

  • Closes #
  • Related #

User-visible / Behavior Changes

  • browser.profiles.<name>.userDataDir is now supported for driver: "existing-session" profiles.
  • openclaw browser create-profile --driver existing-session --user-data-dir <path> now stores and validates the configured Chromium user data directory.
  • Browser status output surfaces the configured userDataDir for existing-session profiles.
  • Browser doctor and browser-tool messaging now refer to Chromium-based browsers where appropriate instead of assuming Google Chrome only.

Security Impact (required)

  • New permissions/capabilities? (Yes/No) No
  • Secrets/tokens handling changed? (Yes/No) No
  • New/changed network calls? (Yes/No) No
  • Command/tool execution surface changed? (Yes/No) No
  • Data access scope changed? (Yes/No) No
  • If any Yes, explain risk + mitigation:

Repro + Verification

Environment

  • OS: macOS
  • Runtime/container: local dev checkout, pnpm
  • Model/provider: N/A
  • Integration/channel (if any): browser existing-session via Chrome DevTools MCP
  • Relevant config (redacted): browser.profiles.brave-live = { driver = "existing-session", attachOnly = true, userDataDir = "~/Library/Application Support/BraveSoftware/Brave-Browser" }

Steps

  1. Configure or create an existing-session browser profile with userDataDir pointing at a Chromium browser profile directory.
  2. Start the target browser with remote debugging enabled.
  3. Run browser status/doctor flows or attach through the existing-session path.

Expected

  • MCP attach reads DevToolsActivePort from the configured profile directory and works for Brave/Edge/other Chromium-based browsers.
  • Existing Chrome users without userDataDir continue using default auto-connect behavior.

Actual

  • Matches expected with the new config path.

Evidence

  • Failing test/log before + passing after
  • Trace/log snippets
  • Screenshot/recording
  • Perf numbers (if relevant)

Human Verification (required)

What you personally verified (not just CI), and how:

  • Verified scenarios: added and ran focused tests for MCP arg building, resolved-profile plumbing, profile creation/validation, status routes/CLI output, doctor messaging, and existing-session server-context calls; also ran pnpm build and pnpm check on the full repo.
  • Edge cases checked: userDataDir is rejected for non-existing-session profiles, missing directories fail early with a targeted error, and changing userDataDir participates in existing-session refresh/reconnect logic.
  • What you did not verify: live attach against every Chromium fork on a real browser process.

Review Conversations

  • I replied to or resolved every bot review conversation I addressed in this PR.
  • I left unresolved only the conversations that still need reviewer or maintainer judgment.

Compatibility / Migration

  • Backward compatible? (Yes/No) Yes
  • Config/env changes? (Yes/No) Yes
  • Migration needed? (Yes/No) No
  • If yes, exact upgrade steps:

Failure Recovery (if this breaks)

  • How to disable/revert this change quickly: remove userDataDir from the affected profile to fall back to default Chrome auto-connect behavior, or revert this PR.
  • Files/config to restore: browser.profiles.<name>.userDataDir
  • Known bad symptoms reviewers should watch for: unexpected validation errors for non-existing-session profiles, or existing-session profiles not reconnecting after a userDataDir change.

Risks and Mitigations

  • Risk: a configured path may not exist or may point at the wrong browser profile.
    • Mitigation: validate on profile creation and availability checks, and surface the configured path in status output/doctor guidance.
  • Risk: existing-session MCP sessions might not refresh when only userDataDir changes.
    • Mitigation: include userDataDir in resolved profile change detection so reconcile logic restarts the session.

@openclaw-barnacle openclaw-barnacle bot added docs Improvements or additions to documentation gateway Gateway runtime cli CLI command changes commands Command implementations agents Agent runtime and tooling size: L maintainer Maintainer-authored PR labels Mar 16, 2026
@velvet-shark velvet-shark self-assigned this Mar 16, 2026
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Mar 16, 2026

Greptile Summary

This PR adds userDataDir support to existing-session browser profiles so that Chrome DevTools MCP can attach to Brave, Edge, and other Chromium-based browsers, not just the default Google Chrome install. The change is well-scoped: default Chrome auto-connect behaviour is untouched, userDataDir is validated on both creation and attach, it participates in reconcile-triggered session restarts, and all 34 changed files consistently thread the new field from config through every MCP call site.

One logic bug to address before merging:

  • resolveProfile in src/browser/config.ts stores the raw userDataDir string without expanding ~ (it calls .trim() but not resolveUserPath). profiles-service.ts correctly calls resolveUserPath when creating a profile via CLI or API, but a user who manually edits their config file — as the documentation examples in docs/tools/browser.md and docs/gateway/configuration-reference.md both demonstrate with "~/Library/Application Support/BraveSoftware/Brave-Browser" — will receive an immediate "Browser user data directory not found" error at attach time, because Node's fs.existsSync and child-process argument arrays do not expand ~. The fix is to call resolveUserPath inside resolveProfile in config.ts before assigning userDataDir.

Confidence Score: 3/5

  • Safe to merge after fixing the ~ path expansion gap in resolveProfile; all other plumbing is correct and well-tested.
  • The feature is well-architected and thoroughly tested via the CLI path. The single blocking issue — ~ not being expanded in resolveProfile in config.ts — would silently break any user who manually edits their config with the ~/… syntax shown in the docs, causing a confusing "directory not found" error on first attach. Everything else (MCP arg building, session caching/refresh, validation, doctor, CLI output) looks correct. Score is 3 rather than 4 because the bug directly contradicts the documentation examples and affects a likely common configuration pattern.
  • src/browser/config.ts — the userDataDir field in resolveProfile needs resolveUserPath applied before assignment.
Prompt To Fix All With AI
This is a comment left during a code review.
Path: src/browser/config.ts
Line: 329

Comment:
**`~` not expanded in resolved profile — breaks manually-configured paths**

`resolveProfile` stores the raw trimmed string, so a `userDataDir` value like `"~/Library/Application Support/BraveSoftware/Brave-Browser"` is not expanded. Node's `fs.existsSync` and the child-process args array both receive the literal `~` character, so the availability check in `server-context.availability.ts` will always throw `"Browser user data directory not found"`, and chrome-devtools-mcp will receive an unresolved path.

The CLI path correctly calls `resolveUserPath` in `profiles-service.ts` before saving, so profiles created with `--user-data-dir` work fine. But both docs examples (`docs/tools/browser.md` and `docs/gateway/configuration-reference.md`) show `~/Library/...` in the raw config, so any user who edits their config manually will hit this.

```suggestion
      userDataDir: resolveUserPath(profile.userDataDir?.trim() || "") || undefined,
```

`resolveUserPath` already handles the empty-string case (returns `""`), so the `|| undefined` coercion is still correct. You'll also need to import `resolveUserPath` from `"../utils.js"` in `config.ts`.

How can I resolve this? If you propose a fix, please make it concise.

Last reviewed commit: 7a3e914

@@ -328,6 +329,7 @@ export function resolveProfile(
cdpUrl: "",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~ not expanded in resolved profile — breaks manually-configured paths

resolveProfile stores the raw trimmed string, so a userDataDir value like "~/Library/Application Support/BraveSoftware/Brave-Browser" is not expanded. Node's fs.existsSync and the child-process args array both receive the literal ~ character, so the availability check in server-context.availability.ts will always throw "Browser user data directory not found", and chrome-devtools-mcp will receive an unresolved path.

The CLI path correctly calls resolveUserPath in profiles-service.ts before saving, so profiles created with --user-data-dir work fine. But both docs examples (docs/tools/browser.md and docs/gateway/configuration-reference.md) show ~/Library/... in the raw config, so any user who edits their config manually will hit this.

Suggested change
cdpUrl: "",
userDataDir: resolveUserPath(profile.userDataDir?.trim() || "") || undefined,

resolveUserPath already handles the empty-string case (returns ""), so the || undefined coercion is still correct. You'll also need to import resolveUserPath from "../utils.js" in config.ts.

Prompt To Fix With AI
This is a comment left during a code review.
Path: src/browser/config.ts
Line: 329

Comment:
**`~` not expanded in resolved profile — breaks manually-configured paths**

`resolveProfile` stores the raw trimmed string, so a `userDataDir` value like `"~/Library/Application Support/BraveSoftware/Brave-Browser"` is not expanded. Node's `fs.existsSync` and the child-process args array both receive the literal `~` character, so the availability check in `server-context.availability.ts` will always throw `"Browser user data directory not found"`, and chrome-devtools-mcp will receive an unresolved path.

The CLI path correctly calls `resolveUserPath` in `profiles-service.ts` before saving, so profiles created with `--user-data-dir` work fine. But both docs examples (`docs/tools/browser.md` and `docs/gateway/configuration-reference.md`) show `~/Library/...` in the raw config, so any user who edits their config manually will hit this.

```suggestion
      userDataDir: resolveUserPath(profile.userDataDir?.trim() || "") || undefined,
```

`resolveUserPath` already handles the empty-string case (returns `""`), so the `|| undefined` coercion is still correct. You'll also need to import `resolveUserPath` from `"../utils.js"` in `config.ts`.

How can I resolve this? If you propose a fix, please make it concise.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7a3e9142f5

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines 230 to 231
async function getSession(profileName: string, userDataDir?: string): Promise<ChromeMcpSession> {
let session = sessions.get(profileName);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Include userDataDir in Chrome MCP session cache key

getSession accepts userDataDir but still caches/reuses sessions only by profileName, so changing browser.profiles.<name>.userDataDir can leave the old MCP process attached and serving requests for the previous browser profile. This is user-visible because some routes (for example tab list/focus/close flows) call reachability/tab APIs without first running ensureBrowserAvailable() reconciliation, which means actions can be applied to the wrong live browser session until another code path forces a reset.

Useful? React with 👍 / 👎.

@velvet-shark
Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@velvet-shark velvet-shark force-pushed the codex/non-chrome-existing-session branch from 543bd73 to cf879bf Compare March 16, 2026 13:18
@aisle-research-bot
Copy link
Copy Markdown

aisle-research-bot bot commented Mar 16, 2026

🔒 Aisle Security Analysis

We found 1 potential security issue(s) in this PR:

# Severity Title
1 🔵 Low Local filesystem path disclosure via configured Chrome MCP userDataDir

1. 🔵 Local filesystem path disclosure via configured Chrome MCP userDataDir

Property Value
Severity Low
CWE CWE-200
Location src/browser/routes/basic.ts:98-121

Description

The browser API now exposes the configured Chromium userDataDir (often an absolute path containing usernames/home directories) to callers, and also embeds it into error messages.

This creates an information disclosure risk and a local path existence oracle (via validation errors) if these endpoints/errors are reachable by untrusted clients.

Observed exposures:

  • Status endpoint (GET /) returns the configured userDataDir even when the browser is not running:
    • This can reveal OS username, home directory layout, and other sensitive path details.
  • Attach/connect errors include the raw userDataDir in the error message (propagated to HTTP responses via toBrowserErrorResponse).
  • Profile creation validates existence and returns the full resolved path in the error, enabling probing for which directories exist on the host.

Vulnerable code (status response includes the path):

res.json({// ...
  userDataDir: profileState?.running?.userDataDir ?? profileCtx.profile.userDataDir ?? null,// ...
});

Additional relevant code paths:

  • src/browser/chrome-mcp.ts includes userDataDir in BrowserProfileUnavailableError message.
  • src/browser/profiles-service.ts throws browser user data directory not found: ${normalizedUserDataDir}.

Recommendation

Redact or avoid returning local paths to API clients.

Options:

  1. Do not return userDataDir over the API by default; return a boolean instead:
res.json({// ...
  hasUserDataDir: Boolean(profileState?.running?.userDataDir ?? profileCtx.profile.userDataDir),
});
  1. If you must return it for diagnostics, redact to a safe display form (e.g., shortenHomePath or basename-only) and consider gating behind an admin/debug flag.

  2. Remove the raw path from user-facing error messages and log it only server-side:

const targetLabel = userDataDir ? "the configured Chromium user data dir" : "Google Chrome's default profile";
throw new BrowserProfileUnavailableError(
  `Chrome MCP existing-session attach failed for profile "${profileName}". ` +
  `Make sure ${targetLabel} is running locally with remote debugging enabled.`,
);
  1. For profile creation validation, return a generic message (e.g., "userDataDir not found") instead of echoing the full filesystem path.

Analyzed PR: #48170 at commit e490035

Last updated on: 2026-03-16T14:30:41Z

@velvet-shark velvet-shark force-pushed the codex/non-chrome-existing-session branch from cf879bf to e490035 Compare March 16, 2026 13:20
@velvet-shark velvet-shark merged commit 7deb543 into main Mar 16, 2026
27 of 35 checks passed
@velvet-shark velvet-shark deleted the codex/non-chrome-existing-session branch March 16, 2026 13:21
@velvet-shark
Copy link
Copy Markdown
Member Author

Merged in 7deb543:
7deb543

Prepared head SHA:
e490035

mrosmarin added a commit to mrosmarin/openclaw that referenced this pull request Mar 16, 2026
* main: (71 commits)
  Gateway tests: share ordered client teardown helper
  Gateway tests: centralize mock responses provider setup
  test: fix stale web search and boot-md contracts
  Gateway: simplify startup and stabilize mock responses tests
  feat(skills): preserve all skills in prompt via compact fallback before dropping (openclaw#47553)
  Docs: document deferred channel startup opt-in
  Gateway: gate deferred channel startup behind opt-in
  Gateway: defer full channel plugins until after listen
  Plugins: share channel plugin id resolution
  docs(config): refresh generated baseline
  fix(android): lazy-init node runtime after onboarding
  test: mock telegram native command reply pipeline
  test: update discord subagent hook mocks
  fix: normalize discord commands allowFrom auth
  fix(local-storage): improve VITEST environment check for localStorage access
  Browser: support non-Chrome existing-session profiles via userDataDir (openclaw#48170)
  fix(android): shrink chat image attachments
  fix(android): preserve chat message identity on refresh
  fix(android): reduce chat recomposition churn
  test: remove stale synology zod mock
  ...
vincentkoc pushed a commit to vincentkoc/openclaw that referenced this pull request Mar 17, 2026
…openclaw#48170)

Merged via squash.

Prepared head SHA: e490035
Co-authored-by: velvet-shark <[email protected]>
Co-authored-by: velvet-shark <[email protected]>
Reviewed-by: @velvet-shark
jonBoone added a commit to jonBoone/openclaw that referenced this pull request Mar 17, 2026
* refactor: make setup the primary wizard surface

* test: move setup surface coverage

* docs: prefer setup wizard command

* fix: follow up shared interactive regressions (openclaw#47715)

* fix(plugins): resolve lazy runtime from package root

* fix(daemon): accept 'Last Result' schtasks key variant on Windows (openclaw#47726)

Some Windows locales/versions emit 'Last Result' instead of 'Last Run Result' in schtasks output, causing gateway status to falsely report 'Runtime: unknown'. Fall back to the shorter key when the canonical key is absent.

* fix: accept schtasks Last Result key on Windows (openclaw#47844) (thanks @MoerAI)

* refactor(plugins): move auth profile hooks into providers

* fix: resume orphaned subagent sessions after SIGUSR1 reload

Closes openclaw#47711

After a SIGUSR1 gateway reload aborts in-flight subagent LLM calls, the gateway now scans for orphaned sessions and sends a synthetic resume message to restart their work. Also makes the deferral timeout configurable via gateway.reload.deferralTimeoutMs (default: 5 minutes, up from 90s).

* fix: address Greptile review feedback

- Remove unrelated pnpm-lock.yaml changes
- Move abortedLastRun flag clearing to AFTER successful resume
  (prevents permanent session loss on transient gateway failures)
- Use dynamic import for orphan recovery module to avoid startup
  memory overhead
- Add test assertion that flag is preserved on resume failure

* fix: add retry with exponential backoff for orphan recovery

Addresses Codex review feedback — if recovery fails (e.g. gateway
still booting), retries up to 3 times with exponential backoff
(5s → 10s → 20s) before giving up.

* fix: address all review comments on PR openclaw#47719 + implement resume context and config idempotency guard

* fix: address 6 review comments on PR openclaw#47719

1. [P1] Treat remap failures as resume failures — if replaceSubagentRunAfterSteer
   returns false, do NOT clear abortedLastRun, increment failed count.

2. [P2] Count scan-level exceptions as retryable failures — set result.failed > 0
   in the outer catch block so scheduleOrphanRecovery retry logic triggers.

3. [P2] Persist resumed-session dedupe across recovery retries — accept
   resumedSessionKeys as a parameter; scheduleOrphanRecovery lifts the Set to
   its own scope and passes it through retries.

4. [Greptile] Use typed config accessors instead of raw structural cast for TLS
   check in lifecycle.ts.

5. [Greptile] Forward gateway.reload.deferralTimeoutMs to deferGatewayRestartUntilIdle
   in scheduleGatewaySigusr1Restart so user-configured value is not silently ignored.

6. [Greptile] Same as openclaw#4 — already addressed by the typed config fix.

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

* fix: land SIGUSR1 orphan recovery regressions (openclaw#47719) (thanks @joeykrug)

* refactor: move channel messaging hooks into plugins

* fix: stabilize windows parallels smoke harness

* refactor(plugins): move provider onboarding auth into plugins

* docs: restore onboard as canonical setup command

* docs: restore onboard docs references

* refactor: move channel capability diagnostics into plugins

* refactor: split slack block action handling

* refactor: split plugin interactive dispatch adapters

* refactor: unify reply content checks

* refactor: extract discord shared interactive mapper

* refactor: unify telegram interactive button resolution

* build: add land gate parity script

* test: fix setup wizard smoke mocks

* docs: sync config baseline

* Status: split heartbeat summary helpers

* Security: trim audit policy import surfaces

* Security: lazy-load deep skill audit helpers

* Security: lazy-load audit config snapshot IO

* Config: keep native command defaults off heavy channel registry

* Status: split lightweight gateway agent list

* refactor(plugins): simplify provider auth choice metadata

* test: add openshell sandbox e2e smoke

* feishu: add structured card actions and interactive approval flows (openclaw#47873)

* feishu: add structured card actions and interactive approval flows

* feishu: address review fixes and test-gate regressions

* feishu: hold inflight card dedup until completion

* feishu: restore fire-and-forget bot menu handling

* feishu: format card interaction helpers

* Feishu: add changelog entry for card interactions

* Feishu: add changelog entry for ACP session binding

* build: remove land gate script

* Status: lazy-load tailscale and memory scan deps

* Tests: fix Feishu full registration mock

* Tests: cover plugin capability matrix

* Gateway: import normalizeAgentId in hooks

* fix: recover bonjour advertiser from ciao announce loops

* fix: preserve loopback gateway scopes for local auth

* Status: lazy-load summary session helpers

* Status: lazy-load security audit commands

* refactor: move channel delivery and ACP seams into plugins

* Security: split audit runtime surfaces

* Tests: add channel actions contract helper

* Tests: add channel plugin contract helper

* Tests: add Slack channel contract suite

* Tests: add Mattermost channel contract suite

* Tests: add Telegram channel contract suite

* Tests: add Discord channel contract suite

* fix(session): preserve external channel route when webchat views session (openclaw#47745)

When a Telegram/WhatsApp/iMessage session was viewed or messaged from the
dashboard/webchat, resolveLastChannelRaw() unconditionally returned 'webchat'
for any isDirectSessionKey() or isMainSessionKey() match, overwriting the
persisted external delivery route.

This caused subagent completion events to be delivered to the webchat/dashboard
instead of the original channel (Telegram, WhatsApp, etc.), silently dropping
messages for the channel user.

Fix: only allow webchat to own routing when no external delivery route has been
established (no persisted external lastChannel, no external channel hint in the
session key). If an external route exists, webchat is treated as admin/monitoring
access and must not mutate the delivery route.

Updated/added tests to document the correct behaviour.

Fixes openclaw#47745

* fix: address bot nit on session route preservation (openclaw#47797) (thanks @brokemac79)

* Tests: add plugin contract suites

* Tests: add plugin contract registry

* Tests: add global plugin contract suite

* Tests: add global actions contract suite

* Tests: add global setup contract suite

* Tests: add global status contract suite

* Tests: replace local channel contracts

* refactor(plugins): move onboarding auth metadata to manifests

* refactor: move remaining channel seams into plugins

* refactor: add plugin-owned outbound adapters

* fix: scope localStorage settings key by basePath to prevent cross-deployment conflicts

- Add settingsKeyForGateway() function similar to tokenSessionKeyForGateway()
- Use scoped key format: openclaw.control.settings.v1:https://example.com/gateway-a
- Add migration from legacy static key on load
- Fixes openclaw#47481

* Tests: add provider contract suites

* Tests: add provider contract registry

* Tests: add global provider contract suite

* Tests: add global web search contract suite

* fix: stabilize ci gate

* Tests: add provider registry contract suite

* Tests: relax provider auth hint contract

* !refactor(browser): remove Chrome extension path and add MCP doctor migration (openclaw#47893)

* Browser: replace extension path with Chrome MCP

* Browser: clarify relay stub and doctor checks

* Docs: mark browser MCP migration as breaking

* Browser: reject unsupported profile drivers

* Browser: accept clawd alias on profile create

* Doctor: narrow legacy browser driver migration

* feishu: harden media support and align capability docs (openclaw#47968)

* feishu: harden media support and action surface

* feishu: format media action changes

* feishu: fix review follow-ups

* fix: scope Feishu target aliases to Feishu (openclaw#47968) (thanks @Takhoffman)

* fix: make docs i18n use gpt-5.4 overrides

* docs: regenerate zh-CN onboarding references

* Tests: tighten provider wizard contracts

* Tests: add plugin loader contract suite

* refactor: remove dock shim and move session routing into plugins

* Plugins: add provider runtime contracts

* GitHub Copilot: move runtime tests to provider contracts

* Z.ai: move runtime tests to provider contracts

* Anthropic: move runtime tests to provider contracts

* Google: move runtime tests to provider contracts

* OpenAI: move runtime tests to provider contracts

* Qwen Portal: move runtime tests to provider contracts

* fix(core): restore outbound fallbacks and gate checks

* style(core): normalize rebase fallout

* fix: accept sandbox plugin id hints

* Plugins: capture tool registrations in test registry

* Plugins: cover Firecrawl tool ownership

* Firecrawl: drop local registration contract test

* Plugins: add provider catalog contracts

* Plugins: narrow provider runtime contracts

* refactor(plugin-sdk): use scoped core imports for bundled channels

* fix: unblock ci gates

* Plugins: add provider wizard contracts

* fix: unblock docs and registry checks

* refactor: finish plugin-owned channel runtime seams

* refactor(plugin-sdk): clean shared core imports

* Plugins: add provider auth contracts

* Plugins: dedupe routing imports in channel adapters

* Plugins: add provider discovery contracts

* fix: stop bonjour before re-advertising

* Plugins: extend provider discovery contracts

* docs: codify macOS parallels discord smoke

* refactor: move session lifecycle and outbound fallbacks into plugins

* refactor(plugins): derive compat provider ids from manifests

* Plugins: cover catalog discovery providers

* Tests: type auth contract prompt mocks

* fix: mount CLI auth dirs in docker live tests

* refactor: route shared channel sdk imports through plugin seams

* Plugins: add auth choice contracts

* Plugins: restore routing seams and discovery fixtures

* fix: harden bonjour retry recovery

* Runtime: lazy-load channel runtime singletons

* refactor: tighten plugin sdk channel seams

* refactor: route remaining channel imports through plugin sdk

* refactor(plugins): finish provider auth boundary cleanup

* fix(infra): wire gaxios-fetch-compat shim to prevent node-fetch crash on Node.js 25

* fix(infra): also wire gaxios-fetch-compat shim into src/index.ts (gateway entry)

* fix: keep gaxios compat off the package root (openclaw#47914) (thanks @pdd-cli)

* refactor: shrink public channel plugin sdk surfaces

* refactor: add private channel sdk bridges

* fix: restore effective setup wizard lazy import

* docs: add frontmatter to parallels discord skill

* fix: retry runtime postbuild skill copy races

* Gateway: lazily resolve channel runtime

* Gateway: cover lazy channel runtime resolution

* Plugins: add Claude marketplace registry installs (openclaw#48058)

* Changelog: note Claude marketplace plugin support

* Plugins: add Claude marketplace installs

* E2E: cover marketplace plugin installs in Docker

* UI: keep thinking helpers browser-safe

* Infra: restore check after gaxios compat

* Docs: refresh generated config baseline

* docs: reorder unreleased changelog entries

* fix: split browser-safe thinking helpers

* fix(macos): restore debug build helpers (openclaw#48046)

* Docs: add Claude marketplace plugin install guidance

* Channels: expand contract suites

* Channels: add contract surface coverage

* Channels: centralize outbound payload contracts

* Channels: centralize group policy contracts

* Channels: centralize inbound context contracts

* Tests: add contract runner

* Tests: harden WhatsApp inbound contract cleanup

* Tests: add extension test runner

* Runtime: lazy-load Discord channel ops

* Docs: use placeholders for marketplace plugin examples

* Release: trim generated docs from npm pack

* Runtime: lazy-load Telegram and Slack channel ops

* Tests: detect changed extensions

* Tests: cover changed extension detection

* Docs: add extension test workflow

* CI: add changed extension test lane

* BlueBubbles: lazy-load channel runtime paths

* Plugin SDK: restore scoped imports for bundled channels

* Plugin SDK: consolidate shared channel exports

* Channels: fix surface contract plugin lookup

* Status: stabilize startup memory probes

* Media: avoid slow auth misses in auto-detect

* Tests: scope Codex bundle loader fixture

* Tests: isolate bundle surface fixtures

* feat(telegram): add configurable silent error replies (openclaw#19776)

Port and complete openclaw#19776 on top of the current Telegram extension layout.

Adds a default-off `channels.telegram.silentErrorReplies` setting. When enabled, Telegram bot replies marked as errors are delivered silently across the regular bot reply flow, native/slash command replies, and fallback sends.

Thanks @auspic7 

Co-authored-by: Myeongwon Choi <[email protected]>
Co-authored-by: ImLukeF <[email protected]>

* fix(ui): auto load Usage tab data on navigation

* fix(telegram): keep silent error fallback replies quiet

* test(gateway): restore agent request route mock

* Cron: isolate active-model delivery tests

* Tests: align media auth fixture with selection checks

* Plugins: preserve lazy runtime provider resolution

* Bootstrap: report nested entry import misses

* fix(channels): parse bundled targets without plugin registry

* test(telegram): cover shared parsing without registry

* Plugin SDK: split setup and sandbox subpaths

* Providers: centralize setup defaults and helper boundaries

* Plugins: decouple bundled web search discovery

* Plugin SDK: update entrypoint metadata

* Secrets: honor caller env during runtime validation

* Tests: align Docker cache checks with non-root images

* Plugin SDK: keep root alias reflection lazy

* Providers: scope compat resolution to owning plugins

* Plugin SDK: add narrow setup subpaths

* Plugin SDK: update entrypoint metadata

* fix(slack): harden bolt import interop (openclaw#45953)

* fix(slack): harden bolt import interop

* fix(slack): simplify bolt interop resolver

* fix(slack): harden startup bolt interop

* fix(slack): place changelog entry at section end

---------

Co-authored-by: Ubuntu <[email protected]>
Co-authored-by: Altay <[email protected]>

* Tests: fix green check typing regressions

* Plugins: avoid booting bundled providers for catalog hooks

* fix: bypass telegram runtime proxy during health checks

* fix: align telegram probe test mock

* test: remove stale synology zod mock

* fix(android): reduce chat recomposition churn

* fix(android): preserve chat message identity on refresh

* fix(android): shrink chat image attachments

* Browser: support non-Chrome existing-session profiles via userDataDir (openclaw#48170)

Merged via squash.

Prepared head SHA: e490035
Co-authored-by: velvet-shark <[email protected]>
Co-authored-by: velvet-shark <[email protected]>
Reviewed-by: @velvet-shark

* fix(local-storage): improve VITEST environment check for localStorage access

* fix: normalize discord commands allowFrom auth

* test: update discord subagent hook mocks

* test: mock telegram native command reply pipeline

* fix(android): lazy-init node runtime after onboarding

* docs(config): refresh generated baseline

* Plugins: share channel plugin id resolution

* Gateway: defer full channel plugins until after listen

* Gateway: gate deferred channel startup behind opt-in

* Docs: document deferred channel startup opt-in

* feat(skills): preserve all skills in prompt via compact fallback before dropping (openclaw#47553)

* feat(skills): add compact format fallback for skill catalog truncation

When the full-format skill catalog exceeds the character budget,
applySkillsPromptLimits now tries a compact format (name + location
only, no description) before binary-searching for the largest fitting
prefix. This preserves full model awareness of registered skills in
the common overflow case.

Three-tier strategy:
1. Full format fits → use as-is
2. Compact format fits → switch to compact, keep all skills
3. Compact still too large → binary search largest compact prefix

Other changes:
- escapeXml() utility for safe XML attribute values
- formatSkillsCompact() emits same XML structure minus <description>
- Compact char-budget check reserves 150 chars for the warning line
  the caller prepends, preventing prompt overflow at the boundary
- 13 tests covering all tiers, edge cases, and budget reservation
- docs/.generated/config-baseline.json: fix pre-existing oxfmt issue

* docs: document compact skill prompt fallback

---------

Co-authored-by: Frank Yang <[email protected]>

* Gateway: simplify startup and stabilize mock responses tests

* test: fix stale web search and boot-md contracts

* Gateway tests: centralize mock responses provider setup

* Gateway tests: share ordered client teardown helper

* Infra: ignore ciao probing cancellations

* Docs: repair unreleased changelog attribution

* Docs: normalize unreleased changelog refs

* Channels: ignore enabled-only disabled plugin config

* perf: reduce status json startup memory

* perf: lazy-load status route startup helpers

* Plugins: stage local bundled runtime tree

* Build: share root dist chunks across tsdown entries

* fix(logging): make logger import browser-safe

* fix(changelog): add entry for Control UI logger import fix (openclaw#48469)

* fix(changelog): note Control UI logger import fix

* fix(changelog): attribute Control UI logger fix entry

* fix(changelog): credit original Control UI fix author

* Plugins: remove public extension-api surface (openclaw#48462)

* Plugins: remove public extension-api surface

* Plugins: fix loader setup routing follow-ups

* CI: ignore non-extension helper dirs in extension-fast

* Docs: note extension-api removal as breaking

* fix(ui): language dropdown selection not persisting after refresh (openclaw#48019)

Merged via squash.

Prepared head SHA: 06c8258
Co-authored-by: git-jxj <[email protected]>
Co-authored-by: altaywtf <[email protected]>
Reviewed-by: @altaywtf

* fix(plugins): late-binding subagent runtime for non-gateway load paths (openclaw#46648)

Merged via squash.

Prepared head SHA: 4474265
Co-authored-by: jalehman <[email protected]>
Co-authored-by: jalehman <[email protected]>
Reviewed-by: @jalehman

* fix: enable auto-scroll during assistant response streaming

Fix auto-scroll behavior when AI assistant streams responses in the web UI.
Previously, the viewport would remain at the sent message position and users
had to manually click a badge to see streaming responses.

Fixes openclaw#14959

Changes:
- Reset chat scroll state before sending message to ensure viewport readiness
- Force scroll to bottom after message send to position viewport correctly
- Detect streaming start (chatStream: null -> string) and trigger auto-scroll
- Ensure smooth scroll-following during entire streaming response

Co-Authored-By: Claude Opus 4.6 <[email protected]>

* fix(ui): align chatStream lifecycle type with nullable state

* fix(whatsapp): restore implicit reply mentions for LID identities (openclaw#48494)

Threads selfLid from the Baileys socket through the inbound WhatsApp
pipeline and adds LID-format matching to the implicit mention check
in group gating, so reply-to-bot detection works when WhatsApp sends
the quoted sender in @lid format.

Also fixes the device-suffix stripping regex (was a silent no-op).

Closes openclaw#23029

Co-authored-by: sparkyrider <[email protected]>
Reviewed-by: @ademczuk

* fix(compaction): stabilize toolResult trim/prune flow in safeguard (openclaw#44133)

Merged via squash.

Prepared head SHA: ec789c6
Co-authored-by: SayrWolfridge <[email protected]>
Co-authored-by: jalehman <[email protected]>
Reviewed-by: @jalehman

* Fix launcher startup regressions (openclaw#48501)

* Fix launcher startup regressions

* Fix CI follow-up regressions

* Fix review follow-ups

* Fix workflow audit shell inputs

* Handle require resolve gaxios misses

* fix: remove orphaned tool_result blocks during compaction (openclaw#15691) (openclaw#16095)

Merged via squash.

Prepared head SHA: b772432
Co-authored-by: claw-sylphx <[email protected]>
Co-authored-by: jalehman <[email protected]>
Reviewed-by: @jalehman

* docs: rename onboarding user-facing wizard copy

Co-authored-by: Tak <[email protected]>

* fix(plugins): keep built plugin loading on one module graph (openclaw#48595)

* Plugins: stabilize global catalog contracts

* Channels: add global threading and directory contracts

* Tests: improve extension runner discovery

* CI: run global contract lane

* Plugins: speed up auth-choice contracts

* Plugins: fix catalog contract mocks

* refactor: move provider catalogs into extensions

* refactor: route bundled channel setup helpers through private sdk bridges

* test: fix check contract type drift

* Tests: lock plugin slash commands to one runtime graph

* Tests: cover Discord provider plugin registry

* Tests: pin loader command activation semantics

* Tests: cover Telegram plugin auth on real registry

* refactor(slack): share setup helpers

* refactor(whatsapp): reuse shared normalize helpers

* Tlon: lazy-load channel runtime paths

* Tests: document Discord plugin auth gating

* feat(plugins): add speech provider registration

* docs(plugins): document capability ownership model

* fix: detect Ollama "prompt too long" as context overflow error (openclaw#34019)

Merged via squash.

Prepared head SHA: 825a402
Co-authored-by: lishuaigit <[email protected]>
Co-authored-by: jalehman <[email protected]>
Reviewed-by: @jalehman

* agent: preemptive context overflow detection during tool loops (openclaw#29371)

Merged via squash.

Prepared head SHA: 19661b8
Co-authored-by: keshav55 <[email protected]>
Co-authored-by: jalehman <[email protected]>
Reviewed-by: @jalehman

---------

Co-authored-by: Peter Steinberger <[email protected]>
Co-authored-by: MoerAI <[email protected]>
Co-authored-by: Joey Krug <[email protected]>
Co-authored-by: bot_apk <[email protected]>
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: Vincent Koc <[email protected]>
Co-authored-by: Tak Hoffman <[email protected]>
Co-authored-by: brokemac79 <[email protected]>
Co-authored-by: ObitaBot <[email protected]>
Co-authored-by: Prompt Driven <[email protected]>
Co-authored-by: Nimrod Gutman <[email protected]>
Co-authored-by: Gustavo Madeira Santana <[email protected]>
Co-authored-by: Myeongwon Choi <[email protected]>
Co-authored-by: Myeongwon Choi <[email protected]>
Co-authored-by: ImLukeF <[email protected]>
Co-authored-by: 郑耀宏 <[email protected]>
Co-authored-by: Ayaan Zaidi <[email protected]>
Co-authored-by: huntharo <[email protected]>
Co-authored-by: Yauheni Shauchenka <[email protected]>
Co-authored-by: Ubuntu <[email protected]>
Co-authored-by: Altay <[email protected]>
Co-authored-by: Radek Sienkiewicz <[email protected]>
Co-authored-by: velvet-shark <[email protected]>
Co-authored-by: Val Alexander <[email protected]>
Co-authored-by: Hung-Che Lo <[email protected]>
Co-authored-by: Frank Yang <[email protected]>
Co-authored-by: git-jxj <[email protected]>
Co-authored-by: git-jxj <[email protected]>
Co-authored-by: altaywtf <[email protected]>
Co-authored-by: Josh Lehman <[email protected]>
Co-authored-by: jalehman <[email protected]>
Co-authored-by: Jaewon Hwang <[email protected]>
Co-authored-by: Claude Opus 4.6 <[email protected]>
Co-authored-by: sparkyrider <[email protected]>
Co-authored-by: sparkyrider <[email protected]>
Co-authored-by: Sayr Wolfridge <[email protected]>
Co-authored-by: SayrWolfridge <[email protected]>
Co-authored-by: Clayton Shaw <[email protected]>
Co-authored-by: claw-sylphx <[email protected]>
Co-authored-by: Tak <[email protected]>
Co-authored-by: lishuaigit <[email protected]>
Co-authored-by: lishuaigit <[email protected]>
Co-authored-by: Keshav Rao <[email protected]>
Co-authored-by: keshav55 <[email protected]>
nikolaisid pushed a commit to nikolaisid/openclaw that referenced this pull request Mar 18, 2026
…openclaw#48170)

Merged via squash.

Prepared head SHA: e490035
Co-authored-by: velvet-shark <[email protected]>
Co-authored-by: velvet-shark <[email protected]>
Reviewed-by: @velvet-shark
artemgetmann pushed a commit to artemgetmann/openclaw that referenced this pull request Mar 24, 2026
…openclaw#48170)

Merged via squash.

Prepared head SHA: e490035
Co-authored-by: velvet-shark <[email protected]>
Co-authored-by: velvet-shark <[email protected]>
Reviewed-by: @velvet-shark

(cherry picked from commit 7deb543)
artemgetmann pushed a commit to artemgetmann/openclaw that referenced this pull request Mar 24, 2026
…openclaw#48170)

Merged via squash.

Prepared head SHA: e490035
Co-authored-by: velvet-shark <[email protected]>
Co-authored-by: velvet-shark <[email protected]>
Reviewed-by: @velvet-shark

(cherry picked from commit 7deb543)
alexey-pelykh pushed a commit to remoteclaw/remoteclaw that referenced this pull request Mar 26, 2026
…openclaw#48170)

Merged via squash.

Prepared head SHA: e490035
Co-authored-by: velvet-shark <[email protected]>
Co-authored-by: velvet-shark <[email protected]>
Reviewed-by: @velvet-shark

(cherry picked from commit 7deb543)
sbezludny pushed a commit to sbezludny/openclaw that referenced this pull request Mar 27, 2026
…openclaw#48170)

Merged via squash.

Prepared head SHA: e490035
Co-authored-by: velvet-shark <[email protected]>
Co-authored-by: velvet-shark <[email protected]>
Reviewed-by: @velvet-shark
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agents Agent runtime and tooling cli CLI command changes commands Command implementations docs Improvements or additions to documentation gateway Gateway runtime maintainer Maintainer-authored PR size: L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant