fix: locale dropdown resets to English after page refresh#48094
Open
vipurkumar wants to merge 1 commit intoopenclaw:mainfrom
Open
fix: locale dropdown resets to English after page refresh#48094vipurkumar wants to merge 1 commit intoopenclaw:mainfrom
vipurkumar wants to merge 1 commit intoopenclaw:mainfrom
Conversation
Replace .value property binding on <select> with ?selected attribute binding on each <option>. The .value binding evaluated before async locale translations loaded, causing the dropdown to show "English" after refresh despite the UI being correctly translated. Fixes openclaw#48015 Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Contributor
Greptile SummaryThis PR fixes a stale dropdown display bug where the language selector showed "English" after a page refresh even though the correct non-English locale was loaded and applied to the UI. The root cause is that Changes:
Confidence Score: 5/5
Last reviewed commit: 84833d5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.valueproperty binding on the<select>evaluatedi18n.getLocale()before async locale translations finished loading, returning the fallback"en".valueon<select>with?selectedattribute binding on each<option>, which Lit re-evaluates reactively when the i18n subscription triggers a re-render after translations loadFixes #48015
AI Disclosure
Test plan
pnpm test— existing tests should pass🤖 Generated with Claude Code