feishu: add structured card actions and interactive approval flows by Takhoffman · Pull Request #47873 · openclaw/openclaw

Takhoffman · 2026-03-16T04:09:49Z

Summary

Describe the problem and fix in 2–5 bullets:

Problem: Feishu card callbacks only flowed through ad hoc text extraction, so interactive cards could not safely carry structured actions or robust callback context.
Why it matters: card-driven UX was brittle, hard to extend, and required users to fall back to raw typed commands for actions that should be clickable.
What changed: added a structured Feishu card interaction envelope and callback decoder/router, shipped approval-confirm cards and a quick-action launcher card, wired launcher opening into Feishu bot menu events, preserved legacy fallback behavior, and added stale/wrong-context/token-dedup safeguards.
What did NOT change (scope boundary): no polls/vote cards, no generic modal framework, no search/admin workflows, and no broader channel capability expansion beyond the implemented approval and launcher flows.

Change Type (select all)

Scope (select all touched areas)

Linked Issue/PR

Closes #
Related #

User-visible / Behavior Changes

List user-visible changes (including defaults/config).
If none, write None.

Feishu card callbacks now support structured button, quick-command, and metadata actions with context validation.
Users can open a Feishu quick-action launcher card from supported bot menu events instead of typing raw commands.
Destructive/confirm-style actions now use an approval card flow before dispatching /new or /reset.
Legacy text-like card payload behavior remains available as a fallback.
Stale, malformed, duplicate, or wrong-context interactions now degrade safely with a user-visible notice or no-op.

Security Impact (required)

New permissions/capabilities? (Yes/No) No
Secrets/tokens handling changed? (Yes/No) No
New/changed network calls? (Yes/No) No
Command/tool execution surface changed? (Yes/No) No
Data access scope changed? (Yes/No) No
If any Yes, explain risk + mitigation:

Repro + Verification

Environment

OS: macOS
Runtime/container: local Node/Vitest worktree run
Model/provider: N/A
Integration/channel (if any): Feishu
Relevant config (redacted): default Feishu test harness / mocked Feishu runtime

Steps

Trigger a supported Feishu bot menu event such as quick-actions.
Open the quick-action launcher card and click a quick action or a confirm-gated action.
Exercise invalid, stale, duplicate, or wrong-context callback payloads through tests.

Expected

Structured callbacks route correctly, DM callbacks stay DM-scoped, confirm flows preserve callback context, and malformed/stale/wrong-context/duplicate callbacks do not execute unsafe actions.

Actual

Verified by targeted and adjacent Feishu test suites passing after the change.

Evidence

Attach at least one:

Failing test/log before + passing after
Trace/log snippets
Screenshot/recording
Perf numbers (if relevant)

Human Verification (required)

What you personally verified (not just CI), and how:

Verified scenarios: structured callback decoding, quick command routing, approval-card generation, DM callback preservation, duplicate-token suppression, bot-menu launcher open path, and launcher failure fallback to legacy /menu handling.
Edge cases checked: legacy text-like fallback, malformed payload rejection, stale payload rejection, wrong-user rejection, wrong-conversation rejection, cancel path, and launcher send failure.
What you did not verify: live Feishu UI interaction against a real workspace/account.

Review Conversations

I replied to or resolved every bot review conversation I addressed in this PR.
I left unresolved only the conversations that still need reviewer or maintainer judgment.

If a bot review conversation is addressed by this PR, resolve that conversation yourself. Do not leave bot review conversation cleanup for maintainers.

Compatibility / Migration

Backward compatible? (Yes/No) Yes
Config/env changes? (Yes/No) No
Migration needed? (Yes/No) No
If yes, exact upgrade steps:

Failure Recovery (if this breaks)

How to disable/revert this change quickly: revert commit 508978a00d or switch callers back to the legacy synthetic /menu and text-only card-action path.
Files/config to restore: extensions/feishu/src/card-action.ts, extensions/feishu/src/monitor.account.ts, and the new card-interaction / card-ux-* helpers.
Known bad symptoms reviewers should watch for: quick-action menu clicks doing nothing, DM launcher actions being treated like group commands, duplicate approval cards, or missing fallback when launcher send fails.

Risks and Mitigations

List only real risks for this PR. Add/remove entries as needed. If none, write None.

Risk: structured callback envelope fields could drift from handler expectations in later edits.
- Mitigation: dedicated decode/routing tests assert envelope validation, callback scoping, and approval-card context propagation.
Risk: Feishu callback retries or double taps could replay actions.
- Mitigation: callback tokens are deduplicated before approval-card emission or command dispatch.

greptile-apps · 2026-03-16T04:13:51Z

Greptile Summary

This PR adds a structured Feishu card interaction system — a versioned envelope format, callback decoder/router, approval-confirm card flow, and quick-action launcher card — wired into the existing bot-menu and card-action event handlers with a full legacy fallback. The architecture is well-layered and the test coverage is broad.

Key observations:

timestamp type annotation is incorrect (number vs actual string) in the application.bot.menu_v6 handler cast inside monitor.account.ts. The integration test itself passes a string literal, confirming the mismatch. No runtime crash today (only string interpolation is performed), but arithmetic comparisons on the field would silently misbehave.
Module-level token dedup map (processedCardActionTokens) is not reset between test runs. vi.clearAllMocks() only resets mock state, not module-level singletons. In Vitest watch mode, tokens used in a prior run remain claimed, causing every subsequent re-execution to short-circuit as "duplicate" and potentially yield incorrect test results.
buildButton is copy-pasted verbatim in both card-ux-approval.ts and card-ux-launcher.ts. Extracting it (and the shared context-builder pattern) to a small internal helper would remove the duplication.
The routing condition on line 217 of card-action.ts (envelope.a === FEISHU_APPROVAL_CONFIRM_ACTION || envelope.k === "quick") is effectively just envelope.k === "quick" since confirm buttons always carry that kind — the first clause is redundant.

Confidence Score: 4/5

Safe to merge with minor cleanup; no logic or security issues, only a type annotation inaccuracy and test-isolation risk.
The core interaction protocol, approval flow, and launcher are correctly implemented and well-tested. The type mismatch for timestamp does not cause a runtime failure. The module-level token map is a test-isolation concern rather than a production bug. No security, auth, or data-scope changes are present.
extensions/feishu/src/monitor.account.ts (timestamp type), extensions/feishu/src/card-action.ts (global dedup state visibility in tests).

Comments Outside Diff (1)

extensions/feishu/src/monitor.account.ts, line 515-522 (link)

timestamp typed as number but Feishu sends a string

The local cast for the bot-menu event types timestamp as number, but the Feishu API delivers it as a millisecond-epoch string (e.g. "1700000000000"). The integration test in monitor.bot-menu.test.ts (line 119) confirms this by passing the field as a string literal. The value is only used in string-template interpolation here, so there's no runtime crash, but the type is misleading and would cause silent bugs if arithmetic (e.g. comparing timestamps) is added later.

Prompt To Fix With AI

This is a comment left during a code review.
Path: extensions/feishu/src/monitor.account.ts
Line: 515-522

Comment:
**`timestamp` typed as `number` but Feishu sends a string**

The local cast for the bot-menu event types `timestamp` as `number`, but the Feishu API delivers it as a millisecond-epoch string (e.g. `"1700000000000"`). The integration test in `monitor.bot-menu.test.ts` (line 119) confirms this by passing the field as a string literal. The value is only used in string-template interpolation here, so there's no runtime crash, but the type is misleading and would cause silent bugs if arithmetic (e.g. comparing timestamps) is added later.



How can I resolve this? If you propose a fix, please make it concise.

Prompt To Fix All With AI

This is a comment left during a code review.
Path: extensions/feishu/src/monitor.account.ts
Line: 515-522

Comment:
**`timestamp` typed as `number` but Feishu sends a string**

The local cast for the bot-menu event types `timestamp` as `number`, but the Feishu API delivers it as a millisecond-epoch string (e.g. `"1700000000000"`). The integration test in `monitor.bot-menu.test.ts` (line 119) confirms this by passing the field as a string literal. The value is only used in string-template interpolation here, so there's no runtime crash, but the type is misleading and would cause silent bugs if arithmetic (e.g. comparing timestamps) is added later.

```suggestion
        const event = data as {
          event_key?: string;
          timestamp?: string | number;
          operator?: {
            operator_name?: string;
            operator_id?: { open_id?: string; user_id?: string; union_id?: string };
          };
        };
```

How can I resolve this? If you propose a fix, please make it concise.

---

This is a comment left during a code review.
Path: extensions/feishu/src/card-action.ts
Line: 33-41

Comment:
**Module-level token cache leaks state across test runs**

`processedCardActionTokens` is a module-level singleton. `vi.clearAllMocks()` in `beforeEach` does not reset it. In Vitest watch mode (or any run that reuses the same module instance), tokens from a previous run (e.g. `tok1`–`tok9`) are still present in the map, causing every subsequent re-execution of those tests to silently skip the handler as a "duplicate" and produce unexpected failures.

Consider exporting a `resetProcessedCardActionTokens` (test-only) helper, or restructuring the map so it can be injected — making the dedup state per-instance rather than per-module. Alternatively, the test suite can import the module through `vi.resetModules()` between runs to guarantee isolation.

How can I resolve this? If you propose a fix, please make it concise.

---

This is a comment left during a code review.
Path: extensions/feishu/src/card-ux-launcher.ts
Line: 13-27

Comment:
**`buildButton` helper duplicated between `card-ux-launcher.ts` and `card-ux-approval.ts`**

`buildButton` is copy-pasted verbatim in both `card-ux-launcher.ts` (lines 13–27) and `card-ux-approval.ts` (lines 10–24). Similarly, the interaction-context builder (here `buildInteractionContext`) is structurally equivalent to the inline `context` object in `createApprovalCard`. Extracting these to a shared internal helper (e.g. `card-ux-shared.ts`) would eliminate the duplication and ensure future changes are only needed in one place.

How can I resolve this? If you propose a fix, please make it concise.

_{Last reviewed commit: 508978a}

extensions/feishu/src/card-action.ts

extensions/feishu/src/card-ux-launcher.ts

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 508978a00d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

extensions/feishu/src/card-action.ts

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6392e168f5

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

extensions/feishu/src/card-action.ts

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e8868b2461

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

extensions/feishu/src/monitor.account.ts

…penclaw#47873) * feishu: add structured card actions and interactive approval flows * feishu: address review fixes and test-gate regressions * feishu: hold inflight card dedup until completion * feishu: restore fire-and-forget bot menu handling * feishu: format card interaction helpers * Feishu: add changelog entry for card interactions * Feishu: add changelog entry for ACP session binding

@MoerAI

* refactor: make setup the primary wizard surface * test: move setup surface coverage * docs: prefer setup wizard command * fix: follow up shared interactive regressions (openclaw#47715) * fix(plugins): resolve lazy runtime from package root * fix(daemon): accept 'Last Result' schtasks key variant on Windows (openclaw#47726) Some Windows locales/versions emit 'Last Result' instead of 'Last Run Result' in schtasks output, causing gateway status to falsely report 'Runtime: unknown'. Fall back to the shorter key when the canonical key is absent. * fix: accept schtasks Last Result key on Windows (openclaw#47844) (thanks @MoerAI) * refactor(plugins): move auth profile hooks into providers * fix: resume orphaned subagent sessions after SIGUSR1 reload Closes openclaw#47711 After a SIGUSR1 gateway reload aborts in-flight subagent LLM calls, the gateway now scans for orphaned sessions and sends a synthetic resume message to restart their work. Also makes the deferral timeout configurable via gateway.reload.deferralTimeoutMs (default: 5 minutes, up from 90s). * fix: address Greptile review feedback - Remove unrelated pnpm-lock.yaml changes - Move abortedLastRun flag clearing to AFTER successful resume (prevents permanent session loss on transient gateway failures) - Use dynamic import for orphan recovery module to avoid startup memory overhead - Add test assertion that flag is preserved on resume failure * fix: add retry with exponential backoff for orphan recovery Addresses Codex review feedback — if recovery fails (e.g. gateway still booting), retries up to 3 times with exponential backoff (5s → 10s → 20s) before giving up. * fix: address all review comments on PR openclaw#47719 + implement resume context and config idempotency guard * fix: address 6 review comments on PR openclaw#47719 1. [P1] Treat remap failures as resume failures — if replaceSubagentRunAfterSteer returns false, do NOT clear abortedLastRun, increment failed count. 2. [P2] Count scan-level exceptions as retryable failures — set result.failed > 0 in the outer catch block so scheduleOrphanRecovery retry logic triggers. 3. [P2] Persist resumed-session dedupe across recovery retries — accept resumedSessionKeys as a parameter; scheduleOrphanRecovery lifts the Set to its own scope and passes it through retries. 4. [Greptile] Use typed config accessors instead of raw structural cast for TLS check in lifecycle.ts. 5. [Greptile] Forward gateway.reload.deferralTimeoutMs to deferGatewayRestartUntilIdle in scheduleGatewaySigusr1Restart so user-configured value is not silently ignored. 6. [Greptile] Same as openclaw#4 — already addressed by the typed config fix. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> * fix: land SIGUSR1 orphan recovery regressions (openclaw#47719) (thanks @joeykrug) * refactor: move channel messaging hooks into plugins * fix: stabilize windows parallels smoke harness * refactor(plugins): move provider onboarding auth into plugins * docs: restore onboard as canonical setup command * docs: restore onboard docs references * refactor: move channel capability diagnostics into plugins * refactor: split slack block action handling * refactor: split plugin interactive dispatch adapters * refactor: unify reply content checks * refactor: extract discord shared interactive mapper * refactor: unify telegram interactive button resolution * build: add land gate parity script * test: fix setup wizard smoke mocks * docs: sync config baseline * Status: split heartbeat summary helpers * Security: trim audit policy import surfaces * Security: lazy-load deep skill audit helpers * Security: lazy-load audit config snapshot IO * Config: keep native command defaults off heavy channel registry * Status: split lightweight gateway agent list * refactor(plugins): simplify provider auth choice metadata * test: add openshell sandbox e2e smoke * feishu: add structured card actions and interactive approval flows (openclaw#47873) * feishu: add structured card actions and interactive approval flows * feishu: address review fixes and test-gate regressions * feishu: hold inflight card dedup until completion * feishu: restore fire-and-forget bot menu handling * feishu: format card interaction helpers * Feishu: add changelog entry for card interactions * Feishu: add changelog entry for ACP session binding * build: remove land gate script * Status: lazy-load tailscale and memory scan deps * Tests: fix Feishu full registration mock * Tests: cover plugin capability matrix * Gateway: import normalizeAgentId in hooks * fix: recover bonjour advertiser from ciao announce loops * fix: preserve loopback gateway scopes for local auth * Status: lazy-load summary session helpers * Status: lazy-load security audit commands * refactor: move channel delivery and ACP seams into plugins * Security: split audit runtime surfaces * Tests: add channel actions contract helper * Tests: add channel plugin contract helper * Tests: add Slack channel contract suite * Tests: add Mattermost channel contract suite * Tests: add Telegram channel contract suite * Tests: add Discord channel contract suite * fix(session): preserve external channel route when webchat views session (openclaw#47745) When a Telegram/WhatsApp/iMessage session was viewed or messaged from the dashboard/webchat, resolveLastChannelRaw() unconditionally returned 'webchat' for any isDirectSessionKey() or isMainSessionKey() match, overwriting the persisted external delivery route. This caused subagent completion events to be delivered to the webchat/dashboard instead of the original channel (Telegram, WhatsApp, etc.), silently dropping messages for the channel user. Fix: only allow webchat to own routing when no external delivery route has been established (no persisted external lastChannel, no external channel hint in the session key). If an external route exists, webchat is treated as admin/monitoring access and must not mutate the delivery route. Updated/added tests to document the correct behaviour. Fixes openclaw#47745 * fix: address bot nit on session route preservation (openclaw#47797) (thanks @brokemac79) * Tests: add plugin contract suites * Tests: add plugin contract registry * Tests: add global plugin contract suite * Tests: add global actions contract suite * Tests: add global setup contract suite * Tests: add global status contract suite * Tests: replace local channel contracts * refactor(plugins): move onboarding auth metadata to manifests * refactor: move remaining channel seams into plugins * refactor: add plugin-owned outbound adapters * fix: scope localStorage settings key by basePath to prevent cross-deployment conflicts - Add settingsKeyForGateway() function similar to tokenSessionKeyForGateway() - Use scoped key format: openclaw.control.settings.v1:https://example.com/gateway-a - Add migration from legacy static key on load - Fixes openclaw#47481 * Tests: add provider contract suites * Tests: add provider contract registry * Tests: add global provider contract suite * Tests: add global web search contract suite * fix: stabilize ci gate * Tests: add provider registry contract suite * Tests: relax provider auth hint contract * !refactor(browser): remove Chrome extension path and add MCP doctor migration (openclaw#47893) * Browser: replace extension path with Chrome MCP * Browser: clarify relay stub and doctor checks * Docs: mark browser MCP migration as breaking * Browser: reject unsupported profile drivers * Browser: accept clawd alias on profile create * Doctor: narrow legacy browser driver migration * feishu: harden media support and align capability docs (openclaw#47968) * feishu: harden media support and action surface * feishu: format media action changes * feishu: fix review follow-ups * fix: scope Feishu target aliases to Feishu (openclaw#47968) (thanks @Takhoffman) * fix: make docs i18n use gpt-5.4 overrides * docs: regenerate zh-CN onboarding references * Tests: tighten provider wizard contracts * Tests: add plugin loader contract suite * refactor: remove dock shim and move session routing into plugins * Plugins: add provider runtime contracts * GitHub Copilot: move runtime tests to provider contracts * Z.ai: move runtime tests to provider contracts * Anthropic: move runtime tests to provider contracts * Google: move runtime tests to provider contracts * OpenAI: move runtime tests to provider contracts * Qwen Portal: move runtime tests to provider contracts * fix(core): restore outbound fallbacks and gate checks * style(core): normalize rebase fallout * fix: accept sandbox plugin id hints * Plugins: capture tool registrations in test registry * Plugins: cover Firecrawl tool ownership * Firecrawl: drop local registration contract test * Plugins: add provider catalog contracts * Plugins: narrow provider runtime contracts * refactor(plugin-sdk): use scoped core imports for bundled channels * fix: unblock ci gates * Plugins: add provider wizard contracts * fix: unblock docs and registry checks * refactor: finish plugin-owned channel runtime seams * refactor(plugin-sdk): clean shared core imports * Plugins: add provider auth contracts * Plugins: dedupe routing imports in channel adapters * Plugins: add provider discovery contracts * fix: stop bonjour before re-advertising * Plugins: extend provider discovery contracts * docs: codify macOS parallels discord smoke * refactor: move session lifecycle and outbound fallbacks into plugins * refactor(plugins): derive compat provider ids from manifests * Plugins: cover catalog discovery providers * Tests: type auth contract prompt mocks * fix: mount CLI auth dirs in docker live tests * refactor: route shared channel sdk imports through plugin seams * Plugins: add auth choice contracts * Plugins: restore routing seams and discovery fixtures * fix: harden bonjour retry recovery * Runtime: lazy-load channel runtime singletons * refactor: tighten plugin sdk channel seams * refactor: route remaining channel imports through plugin sdk * refactor(plugins): finish provider auth boundary cleanup * fix(infra): wire gaxios-fetch-compat shim to prevent node-fetch crash on Node.js 25 * fix(infra): also wire gaxios-fetch-compat shim into src/index.ts (gateway entry) * fix: keep gaxios compat off the package root (openclaw#47914) (thanks @pdd-cli) * refactor: shrink public channel plugin sdk surfaces * refactor: add private channel sdk bridges * fix: restore effective setup wizard lazy import * docs: add frontmatter to parallels discord skill * fix: retry runtime postbuild skill copy races * Gateway: lazily resolve channel runtime * Gateway: cover lazy channel runtime resolution * Plugins: add Claude marketplace registry installs (openclaw#48058) * Changelog: note Claude marketplace plugin support * Plugins: add Claude marketplace installs * E2E: cover marketplace plugin installs in Docker * UI: keep thinking helpers browser-safe * Infra: restore check after gaxios compat * Docs: refresh generated config baseline * docs: reorder unreleased changelog entries * fix: split browser-safe thinking helpers * fix(macos): restore debug build helpers (openclaw#48046) * Docs: add Claude marketplace plugin install guidance * Channels: expand contract suites * Channels: add contract surface coverage * Channels: centralize outbound payload contracts * Channels: centralize group policy contracts * Channels: centralize inbound context contracts * Tests: add contract runner * Tests: harden WhatsApp inbound contract cleanup * Tests: add extension test runner * Runtime: lazy-load Discord channel ops * Docs: use placeholders for marketplace plugin examples * Release: trim generated docs from npm pack * Runtime: lazy-load Telegram and Slack channel ops * Tests: detect changed extensions * Tests: cover changed extension detection * Docs: add extension test workflow * CI: add changed extension test lane * BlueBubbles: lazy-load channel runtime paths * Plugin SDK: restore scoped imports for bundled channels * Plugin SDK: consolidate shared channel exports * Channels: fix surface contract plugin lookup * Status: stabilize startup memory probes * Media: avoid slow auth misses in auto-detect * Tests: scope Codex bundle loader fixture * Tests: isolate bundle surface fixtures * feat(telegram): add configurable silent error replies (openclaw#19776) Port and complete openclaw#19776 on top of the current Telegram extension layout. Adds a default-off `channels.telegram.silentErrorReplies` setting. When enabled, Telegram bot replies marked as errors are delivered silently across the regular bot reply flow, native/slash command replies, and fallback sends. Thanks @auspic7 Co-authored-by: Myeongwon Choi <[email protected]> Co-authored-by: ImLukeF <[email protected]> * fix(ui): auto load Usage tab data on navigation * fix(telegram): keep silent error fallback replies quiet * test(gateway): restore agent request route mock * Cron: isolate active-model delivery tests * Tests: align media auth fixture with selection checks * Plugins: preserve lazy runtime provider resolution * Bootstrap: report nested entry import misses * fix(channels): parse bundled targets without plugin registry * test(telegram): cover shared parsing without registry * Plugin SDK: split setup and sandbox subpaths * Providers: centralize setup defaults and helper boundaries * Plugins: decouple bundled web search discovery * Plugin SDK: update entrypoint metadata * Secrets: honor caller env during runtime validation * Tests: align Docker cache checks with non-root images * Plugin SDK: keep root alias reflection lazy * Providers: scope compat resolution to owning plugins * Plugin SDK: add narrow setup subpaths * Plugin SDK: update entrypoint metadata * fix(slack): harden bolt import interop (openclaw#45953) * fix(slack): harden bolt import interop * fix(slack): simplify bolt interop resolver * fix(slack): harden startup bolt interop * fix(slack): place changelog entry at section end --------- Co-authored-by: Ubuntu <[email protected]> Co-authored-by: Altay <[email protected]> * Tests: fix green check typing regressions * Plugins: avoid booting bundled providers for catalog hooks * fix: bypass telegram runtime proxy during health checks * fix: align telegram probe test mock * test: remove stale synology zod mock * fix(android): reduce chat recomposition churn * fix(android): preserve chat message identity on refresh * fix(android): shrink chat image attachments * Browser: support non-Chrome existing-session profiles via userDataDir (openclaw#48170) Merged via squash. Prepared head SHA: e490035 Co-authored-by: velvet-shark <[email protected]> Co-authored-by: velvet-shark <[email protected]> Reviewed-by: @velvet-shark * fix(local-storage): improve VITEST environment check for localStorage access * fix: normalize discord commands allowFrom auth * test: update discord subagent hook mocks * test: mock telegram native command reply pipeline * fix(android): lazy-init node runtime after onboarding * docs(config): refresh generated baseline * Plugins: share channel plugin id resolution * Gateway: defer full channel plugins until after listen * Gateway: gate deferred channel startup behind opt-in * Docs: document deferred channel startup opt-in * feat(skills): preserve all skills in prompt via compact fallback before dropping (openclaw#47553) * feat(skills): add compact format fallback for skill catalog truncation When the full-format skill catalog exceeds the character budget, applySkillsPromptLimits now tries a compact format (name + location only, no description) before binary-searching for the largest fitting prefix. This preserves full model awareness of registered skills in the common overflow case. Three-tier strategy: 1. Full format fits → use as-is 2. Compact format fits → switch to compact, keep all skills 3. Compact still too large → binary search largest compact prefix Other changes: - escapeXml() utility for safe XML attribute values - formatSkillsCompact() emits same XML structure minus <description> - Compact char-budget check reserves 150 chars for the warning line the caller prepends, preventing prompt overflow at the boundary - 13 tests covering all tiers, edge cases, and budget reservation - docs/.generated/config-baseline.json: fix pre-existing oxfmt issue * docs: document compact skill prompt fallback --------- Co-authored-by: Frank Yang <[email protected]> * Gateway: simplify startup and stabilize mock responses tests * test: fix stale web search and boot-md contracts * Gateway tests: centralize mock responses provider setup * Gateway tests: share ordered client teardown helper * Infra: ignore ciao probing cancellations * Docs: repair unreleased changelog attribution * Docs: normalize unreleased changelog refs * Channels: ignore enabled-only disabled plugin config * perf: reduce status json startup memory * perf: lazy-load status route startup helpers * Plugins: stage local bundled runtime tree * Build: share root dist chunks across tsdown entries * fix(logging): make logger import browser-safe * fix(changelog): add entry for Control UI logger import fix (openclaw#48469) * fix(changelog): note Control UI logger import fix * fix(changelog): attribute Control UI logger fix entry * fix(changelog): credit original Control UI fix author * Plugins: remove public extension-api surface (openclaw#48462) * Plugins: remove public extension-api surface * Plugins: fix loader setup routing follow-ups * CI: ignore non-extension helper dirs in extension-fast * Docs: note extension-api removal as breaking * fix(ui): language dropdown selection not persisting after refresh (openclaw#48019) Merged via squash. Prepared head SHA: 06c8258 Co-authored-by: git-jxj <[email protected]> Co-authored-by: altaywtf <[email protected]> Reviewed-by: @altaywtf * fix(plugins): late-binding subagent runtime for non-gateway load paths (openclaw#46648) Merged via squash. Prepared head SHA: 4474265 Co-authored-by: jalehman <[email protected]> Co-authored-by: jalehman <[email protected]> Reviewed-by: @jalehman * fix: enable auto-scroll during assistant response streaming Fix auto-scroll behavior when AI assistant streams responses in the web UI. Previously, the viewport would remain at the sent message position and users had to manually click a badge to see streaming responses. Fixes openclaw#14959 Changes: - Reset chat scroll state before sending message to ensure viewport readiness - Force scroll to bottom after message send to position viewport correctly - Detect streaming start (chatStream: null -> string) and trigger auto-scroll - Ensure smooth scroll-following during entire streaming response Co-Authored-By: Claude Opus 4.6 <[email protected]> * fix(ui): align chatStream lifecycle type with nullable state * fix(whatsapp): restore implicit reply mentions for LID identities (openclaw#48494) Threads selfLid from the Baileys socket through the inbound WhatsApp pipeline and adds LID-format matching to the implicit mention check in group gating, so reply-to-bot detection works when WhatsApp sends the quoted sender in @lid format. Also fixes the device-suffix stripping regex (was a silent no-op). Closes openclaw#23029 Co-authored-by: sparkyrider <[email protected]> Reviewed-by: @ademczuk * fix(compaction): stabilize toolResult trim/prune flow in safeguard (openclaw#44133) Merged via squash. Prepared head SHA: ec789c6 Co-authored-by: SayrWolfridge <[email protected]> Co-authored-by: jalehman <[email protected]> Reviewed-by: @jalehman * Fix launcher startup regressions (openclaw#48501) * Fix launcher startup regressions * Fix CI follow-up regressions * Fix review follow-ups * Fix workflow audit shell inputs * Handle require resolve gaxios misses * fix: remove orphaned tool_result blocks during compaction (openclaw#15691) (openclaw#16095) Merged via squash. Prepared head SHA: b772432 Co-authored-by: claw-sylphx <[email protected]> Co-authored-by: jalehman <[email protected]> Reviewed-by: @jalehman * docs: rename onboarding user-facing wizard copy Co-authored-by: Tak <[email protected]> * fix(plugins): keep built plugin loading on one module graph (openclaw#48595) * Plugins: stabilize global catalog contracts * Channels: add global threading and directory contracts * Tests: improve extension runner discovery * CI: run global contract lane * Plugins: speed up auth-choice contracts * Plugins: fix catalog contract mocks * refactor: move provider catalogs into extensions * refactor: route bundled channel setup helpers through private sdk bridges * test: fix check contract type drift * Tests: lock plugin slash commands to one runtime graph * Tests: cover Discord provider plugin registry * Tests: pin loader command activation semantics * Tests: cover Telegram plugin auth on real registry * refactor(slack): share setup helpers * refactor(whatsapp): reuse shared normalize helpers * Tlon: lazy-load channel runtime paths * Tests: document Discord plugin auth gating * feat(plugins): add speech provider registration * docs(plugins): document capability ownership model * fix: detect Ollama "prompt too long" as context overflow error (openclaw#34019) Merged via squash. Prepared head SHA: 825a402 Co-authored-by: lishuaigit <[email protected]> Co-authored-by: jalehman <[email protected]> Reviewed-by: @jalehman * agent: preemptive context overflow detection during tool loops (openclaw#29371) Merged via squash. Prepared head SHA: 19661b8 Co-authored-by: keshav55 <[email protected]> Co-authored-by: jalehman <[email protected]> Reviewed-by: @jalehman --------- Co-authored-by: Peter Steinberger <[email protected]> Co-authored-by: MoerAI <[email protected]> Co-authored-by: Joey Krug <[email protected]> Co-authored-by: bot_apk <[email protected]> Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: Vincent Koc <[email protected]> Co-authored-by: Tak Hoffman <[email protected]> Co-authored-by: brokemac79 <[email protected]> Co-authored-by: ObitaBot <[email protected]> Co-authored-by: Prompt Driven <[email protected]> Co-authored-by: Nimrod Gutman <[email protected]> Co-authored-by: Gustavo Madeira Santana <[email protected]> Co-authored-by: Myeongwon Choi <[email protected]> Co-authored-by: Myeongwon Choi <[email protected]> Co-authored-by: ImLukeF <[email protected]> Co-authored-by: 郑耀宏 <[email protected]> Co-authored-by: Ayaan Zaidi <[email protected]> Co-authored-by: huntharo <[email protected]> Co-authored-by: Yauheni Shauchenka <[email protected]> Co-authored-by: Ubuntu <[email protected]> Co-authored-by: Altay <[email protected]> Co-authored-by: Radek Sienkiewicz <[email protected]> Co-authored-by: velvet-shark <[email protected]> Co-authored-by: Val Alexander <[email protected]> Co-authored-by: Hung-Che Lo <[email protected]> Co-authored-by: Frank Yang <[email protected]> Co-authored-by: git-jxj <[email protected]> Co-authored-by: git-jxj <[email protected]> Co-authored-by: altaywtf <[email protected]> Co-authored-by: Josh Lehman <[email protected]> Co-authored-by: jalehman <[email protected]> Co-authored-by: Jaewon Hwang <[email protected]> Co-authored-by: Claude Opus 4.6 <[email protected]> Co-authored-by: sparkyrider <[email protected]> Co-authored-by: sparkyrider <[email protected]> Co-authored-by: Sayr Wolfridge <[email protected]> Co-authored-by: SayrWolfridge <[email protected]> Co-authored-by: Clayton Shaw <[email protected]> Co-authored-by: claw-sylphx <[email protected]> Co-authored-by: Tak <[email protected]> Co-authored-by: lishuaigit <[email protected]> Co-authored-by: lishuaigit <[email protected]> Co-authored-by: Keshav Rao <[email protected]> Co-authored-by: keshav55 <[email protected]>

…penclaw#47873) * feishu: add structured card actions and interactive approval flows * feishu: address review fixes and test-gate regressions * feishu: hold inflight card dedup until completion * feishu: restore fire-and-forget bot menu handling * feishu: format card interaction helpers * Feishu: add changelog entry for card interactions * Feishu: add changelog entry for ACP session binding

openclaw-barnacle bot added channel: feishu Channel integration: feishu size: XL maintainer Maintainer-authored PR labels Mar 16, 2026

greptile-apps bot reviewed Mar 16, 2026

View reviewed changes

extensions/feishu/src/card-action.ts Outdated Show resolved Hide resolved

extensions/feishu/src/card-ux-launcher.ts Outdated Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Mar 16, 2026

View reviewed changes

extensions/feishu/src/card-action.ts Outdated Show resolved Hide resolved

Takhoffman requested a review from a team as a code owner March 16, 2026 04:41

openclaw-barnacle bot added the cli CLI command changes label Mar 16, 2026

chatgpt-codex-connector bot reviewed Mar 16, 2026

View reviewed changes

extensions/feishu/src/card-action.ts Outdated Show resolved Hide resolved

Takhoffman added 3 commits March 15, 2026 23:58

feishu: add structured card actions and interactive approval flows

0a374c5

feishu: address review fixes and test-gate regressions

e88915a

feishu: hold inflight card dedup until completion

e8868b2

Takhoffman force-pushed the codex/feishu-card-interactions branch from 89bfadc to e8868b2 Compare March 16, 2026 05:05

openclaw-barnacle bot removed the cli CLI command changes label Mar 16, 2026

chatgpt-codex-connector bot reviewed Mar 16, 2026

View reviewed changes

extensions/feishu/src/monitor.account.ts Outdated Show resolved Hide resolved

Takhoffman added 4 commits March 16, 2026 00:25

feishu: restore fire-and-forget bot menu handling

2e7b0c6

feishu: format card interaction helpers

eaf696a

Feishu: add changelog entry for card interactions

89da2be

Feishu: add changelog entry for ACP session binding

4b7dde4

Takhoffman merged commit fa62231 into main Mar 16, 2026
26 of 34 checks passed

Takhoffman deleted the codex/feishu-card-interactions branch March 16, 2026 06:07

github-actions bot mentioned this pull request Mar 16, 2026

📡 Upstream Digest — 2026-03-16 07:07 UTC curtismercier/openclaw-mods#277

Open

JianyuLin1999 mentioned this pull request Mar 17, 2026

feat(feishu): skip @-mention for thread follow-ups in topic-scoped sessions #48945

Open

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feishu: add structured card actions and interactive approval flows#47873

feishu: add structured card actions and interactive approval flows#47873
Takhoffman merged 7 commits intomainfrom
codex/feishu-card-interactions

Takhoffman commented Mar 16, 2026

Uh oh!

greptile-apps bot commented Mar 16, 2026 •

edited

Loading

Comments Outside Diff (1)

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

Takhoffman commented Mar 16, 2026

Summary

Change Type (select all)

Scope (select all touched areas)

Linked Issue/PR

User-visible / Behavior Changes

Security Impact (required)

Repro + Verification

Environment

Steps

Expected

Actual

Evidence

Human Verification (required)

Review Conversations

Compatibility / Migration

Failure Recovery (if this breaks)

Risks and Mitigations

Uh oh!

greptile-apps bot commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 4/5

Comments Outside Diff (1)

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

greptile-apps bot commented Mar 16, 2026 •

edited

Loading