Skip to content

Channels/Plugins: centralize shared interactive payloads#47715

Merged
steipete merged 49 commits intoopenclaw:mainfrom
vincentkoc:vincentkoc-code/slack-plugin-interactive-dedupe
Mar 16, 2026
Merged

Channels/Plugins: centralize shared interactive payloads#47715
steipete merged 49 commits intoopenclaw:mainfrom
vincentkoc:vincentkoc-code/slack-plugin-interactive-dedupe

Conversation

@vincentkoc
Copy link
Copy Markdown
Member

@vincentkoc vincentkoc commented Mar 16, 2026

Summary

  • Problem: interactive replies were split across a shared Telegram/Discord inbound plugin path, Slack-only inbound handling, and three different outbound payload surfaces (buttons, components, Slack blocks).
  • Why it matters: core reply APIs and plugin/channel surfaces were leaking channel-specific interactive shapes instead of keeping only the renderers channel-specific.
  • What changed:
    • added a shared interactive payload model in core reply/message flows,
    • moved Slack reply directives and plugin binding approval replies onto that shared model,
    • taught Slack, Telegram, and Discord outbound adapters plus send/message-action paths to render the shared model into native channel components,
    • kept legacy buttons / components / Slack blocks as compatibility escape hatches,
    • fixed Slack interactive handler registration/context typing while extending the shared inbound dispatcher to Slack.
  • Follow-up boundary: richer Discord-only component features still live behind the explicit Discord components surface; the shared model intentionally covers the common cross-channel subset only.

Change Type (select all)

  • Bug fix
  • Feature
  • Refactor
  • Docs
  • Security hardening
  • Chore/infra

Scope (select all touched areas)

  • Gateway / orchestration
  • Skills / tool execution
  • Auth / tokens
  • Memory / storage
  • Integrations
  • API / contracts
  • UI / DX
  • CI/CD / infra

Linked Issue/PR

  • Closes #
  • Related #

User-visible / Behavior Changes

  • Core reply/message APIs now have a shared interactive payload for common buttons/selects instead of requiring Telegram/Discord/Slack-specific payloads.
  • Slack [[slack_buttons: ...]] / [[slack_select: ...]] still work, but now compile into the shared model and render in the Slack adapter.
  • Telegram and Discord can render the shared model from outbound replies and message-tool sends; channel-specific payloads still work for backward compatibility.

Security Impact (required)

  • New permissions/capabilities? No
  • Secrets/tokens handling changed? No
  • New/changed network calls? No
  • Command/tool execution surface changed? Yes
  • Data access scope changed? No
  • If any Yes, explain risk + mitigation:
    The message/send surface now accepts a shared interactive payload in addition to legacy channel-specific payloads. Rendering remains channel-local, Slack sender authorization still runs before interactive dispatch, and unsupported richer component features are not exposed through the shared model.

Repro + Verification

Environment

  • OS: macOS
  • Runtime/container: local workspace
  • Model/provider: N/A
  • Integration/channel (if any): Slack, Telegram, Discord interactive reply paths
  • Relevant config (redacted): default local test config

Steps

  1. Send a reply or message-tool action with the shared interactive payload.
  2. Verify Slack, Telegram, and Discord render native controls from that one payload.
  3. Trigger Slack interactive callbacks and verify matching plugin namespaces use the shared dispatcher while unmatched actions still fall back to the legacy Slack system-event path.

Expected

  • Shared interactive payloads render natively per channel.
  • Core no longer needs to author Telegram/Discord-specific interactive envelopes for common controls.
  • Slack inbound plugin interactions share the centralized dispatcher path.

Actual

  • Shared interactive payloads now render through channel adapters/actions on Slack, Telegram, and Discord.
  • Core approval/directive paths emit the shared model instead of Telegram/Discord/Slack-specific structures.
  • Slack inbound plugin interactions dispatch through the shared registry path when matched.

Evidence

  • Failing test/log before + passing after
  • Trace/log snippets
  • Screenshot/recording
  • Perf numbers (if relevant)

Human Verification (required)

What you personally verified (not just CI), and how:

  • Verified focused unit/integration tests for reply normalization, outbound delivery, shared interactive render helpers, Slack interaction dispatch, and plugin interactive dedupe.
  • Verified TypeScript surfaces with pnpm tsgo.
  • Did not verify against live Slack/Telegram/Discord accounts.

Review Conversations

  • I replied to or resolved every bot review conversation I addressed in this PR.
  • I left unresolved only the conversations that still need reviewer or maintainer judgment.

Compatibility / Migration

  • Backward compatible? Yes
  • Config/env changes? No
  • Migration needed? No
  • If yes, exact upgrade steps:

Failure Recovery (if this breaks)

  • How to disable/revert this change quickly: revert this PR.
  • Files/config to restore: shared interactive payload model, channel outbound renderers, and Slack interactive dispatcher registration.
  • Known bad symptoms reviewers should watch for: interactive sends dropping controls, Slack directive-only replies being skipped, or Slack plugin callbacks bypassing the shared dispatcher.

Risks and Mitigations

  • Risk:
    Shared interactive rendering could diverge from existing channel-specific behavior on one channel.
  • Mitigation:
    Legacy channel-specific payloads still work, shared rendering is covered by focused tests, and richer Discord-only behavior remains on the explicit Discord-specific path.

@vincentkoc vincentkoc self-assigned this Mar 16, 2026
@openclaw-barnacle openclaw-barnacle bot added channel: slack Channel integration: slack size: M maintainer Maintainer-authored PR labels Mar 16, 2026
@vincentkoc vincentkoc marked this pull request as ready for review March 16, 2026 00:52
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Mar 16, 2026

Greptile Summary

This PR centralizes interactive UI payloads (buttons, selects) behind a shared InteractiveReply model in core, then teaches the Slack, Telegram, and Discord outbound adapters to render that model into their native component formats. Legacy buttons, components, and Slack blocks surfaces are preserved as escape hatches. The refactor also extends the shared plugin interactive dispatcher to Slack, wires up the new SlackInteractiveDispatchContext type, and migrates the conversation-binding approval reply from channel-specific channelData payloads to the shared model.

Key issues found:

  • ctx.interactionId is set to the data string, not the unique interaction ID (extensions/slack/src/monitor/events/interactions.ts:575): ctx.interactionId is assigned pluginInteractionData (e.g. "codex:approve:thread-1") while the top-level interactionId field used for deduplication correctly calls buildSlackPluginInteractionId(...). This inconsistency means plugin handlers receive the data string rather than a per-click unique ID, breaking any handler logic that relies on ctx.interactionId for tracking distinct interaction instances.

  • Slack button value slugification breaks semantic callback values (extensions/slack/src/shared-interactive.ts:48–57): buildSlackInteractiveBlocks applies buildSlackReplyChoiceToken to every button value, transforming it into a slug and truncating it to 75 chars. This was appropriate for the old display-only directive buttons, but is destructive for buttons carrying real callback payloads. The conversation-binding approval buttons (just migrated to the shared model) have values like plugin_binding:allow-once:<approvalId> — on Telegram and Discord the renderers pass these verbatim as callback_data/callbackData, but on Slack the slug transformation destroys the approval ID. The result is that approval buttons will render on Slack (when interactive replies are enabled) but clicking them will silently fail to process the approval decision.

  • Minor type annotation error in extensions/discord/src/shared-interactive.ts:6: resolveDiscordButtonStyle is declared as returning DiscordComponentButtonStyle | undefined but always returns a concrete value (defaults to "secondary"), so the | undefined is unreachable.

Confidence Score: 3/5

  • Safe to merge for Telegram and Discord; Slack interactive flows have two correctness bugs that should be addressed before enabling Slack interactive replies in production.
  • The core shared payload model, Telegram rendering, and Discord rendering are clean and well-tested. The Slack path has two logic bugs: ctx.interactionId receives the data string instead of the unique interaction ID, and the button value slugification makes semantic callback payloads (e.g. conversation-binding approval IDs) unprocessable on Slack. These bugs would only surface when Slack interactive replies are enabled, but the approval-button regression is particularly subtle because the UI will appear functional while silently failing.
  • extensions/slack/src/monitor/events/interactions.ts (ctx.interactionId assignment), extensions/slack/src/shared-interactive.ts (value slugification), src/plugins/conversation-binding.ts (Slack approval flow now non-functional)
Prompt To Fix All With AI
This is a comment left during a code review.
Path: extensions/slack/src/monitor/events/interactions.ts
Line: 575

Comment:
**`ctx.interactionId` receives the data string, not the unique interaction ID**

`ctx.interactionId` is set to `pluginInteractionData` (e.g. `"codex:approve:thread-1"`) — the action data string — while the top-level `interactionId` field (used for deduplication) correctly calls `buildSlackPluginInteractionId({...})` to produce a unique, per-click identifier (line 565–573).

The `PluginInteractiveSlackHandlerContext.interactionId` field exposed to the plugin handler should be the same unique ID used for deduplication, consistent with how the test in `interactive.test.ts` sets it (`"slack-ix-1"` equals the top-level `interactionId`). Using the data string means two different users clicking the same button at different times both see the same `ctx.interactionId`, which breaks any plugin logic that uses this field for per-interaction tracking or correlation.

```suggestion
            interactionId: buildSlackPluginInteractionId({
              userId,
              channelId,
              messageTs,
              actionId,
              summary: actionSummary,
            }),
```

How can I resolve this? If you propose a fix, please make it concise.

---

This is a comment left during a code review.
Path: extensions/slack/src/shared-interactive.ts
Line: 48-57

Comment:
**Slack button value tokenization destroys semantic values**

All interactive buttons — regardless of their origin — are given the static `action_id: "openclaw:reply_button"` and their `value` is slugified via `buildSlackReplyChoiceToken`. While this is appropriate for purely display-oriented reply buttons (where you only need a stable token to identify the choice), it is destructive for buttons carrying meaningful callback payloads.

The immediate example is the conversation-binding approval reply, which was just migrated from the channel-specific `channelData.telegram.buttons` / `channelData.discord.components` shapes to the shared `InteractiveReply` model in `conversation-binding.ts`. Those buttons carry values like `buildPluginBindingApprovalCustomId(approvalId, "allow-once")`. On Telegram and Discord the shared model preserves the original `callback_data`/`callbackData` verbatim, so the approval dispatcher can process them. On Slack however:

1. The `value` is slugified (`"plugin_binding:allow-once:<id>"``"reply_1_plugin_binding_allow_once_..."`), losing the approval ID.
2. The `action_id` is hardcoded to `"openclaw:reply_button"`, so the namespace resolution in `buildSlackPluginInteractionData` always produces data like `"openclaw:reply_button:reply_1_..."`.
3. No Slack interactive handler is registered for that namespace, so `dispatchPluginInteractiveHandler` returns `matched: false` and the event falls through to the legacy system-event path — without the approval decision.

Approval buttons will render on Slack but clicking them will silently fail to trigger the approval flow. Consider using the original `button.value` directly (Slack supports up to 2000-character button values) so that downstream handlers can process the value, or guard this rendering path for use-cases where pure display tokens suffice.

How can I resolve this? If you propose a fix, please make it concise.

---

This is a comment left during a code review.
Path: extensions/discord/src/shared-interactive.ts
Line: 4-7

Comment:
**Return type `| undefined` is unreachable**

`resolveDiscordButtonStyle` always returns a `DiscordComponentButtonStyle` value — it falls back to `"secondary"` when `style` is `undefined` — so the `| undefined` in the return type is unreachable and misleading. The callers (e.g. line 23) will always receive a string.

```suggestion
function resolveDiscordButtonStyle(
  style?: InteractiveButtonStyle,
): DiscordComponentButtonStyle {
  return style ?? "secondary";
}
```

How can I resolve this? If you propose a fix, please make it concise.

Last reviewed commit: f2665e2

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c6562d3871

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@openclaw-barnacle openclaw-barnacle bot added channel: discord Channel integration: discord channel: matrix Channel integration: matrix channel: telegram Channel integration: telegram cli CLI command changes agents Agent runtime and tooling size: XL and removed size: M labels Mar 16, 2026
@vincentkoc vincentkoc marked this pull request as draft March 16, 2026 02:01
@vincentkoc vincentkoc changed the title Plugins/Slack: route block actions through shared interactive dispatcher Channels/Plugins: centralize shared interactive payloads Mar 16, 2026
@vincentkoc vincentkoc force-pushed the vincentkoc-code/slack-plugin-interactive-dedupe branch from 2ec920a to f2665e2 Compare March 16, 2026 02:10
@vincentkoc vincentkoc marked this pull request as ready for review March 16, 2026 02:12
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f2665e29e4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@vincentkoc vincentkoc force-pushed the vincentkoc-code/slack-plugin-interactive-dedupe branch from f2665e2 to 66df5f2 Compare March 16, 2026 02:40
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 66df5f2bcb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@openclaw-barnacle openclaw-barnacle bot added channel: mattermost Channel integration: mattermost channel: msteams Channel integration: msteams channel: zalo Channel integration: zalo channel: feishu Channel integration: feishu labels Mar 16, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 749f3e7baa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 81c8e66f61

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +707 to +709
handler.sendPayload &&
(effectivePayload.channelData || hasInteractivePayload(effectivePayload))
) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restrict interactive sendPayload routing to capable adapters

This condition now routes any payload with interactive through handler.sendPayload, even for channels whose adapters do not render interactive blocks. On those adapters (for example the direct text/media path in src/channels/plugins/outbound/direct-text-media.ts and WhatsApp in extensions/whatsapp/src/outbound-adapter.ts), empty text+media is treated as a no-op, so interactive-only payloads are marked as successful sends with an empty message id while nothing is delivered. That creates a silent drop on non-interactive channels instead of a validation error or fallback rendering.

Useful? React with 👍 / 👎.

Comment on lines +40 to +42
const buttons =
params.buttons ??
buildTelegramInteractiveButtons(normalizeInteractiveReply(params.interactive));
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Carry interactive text fallback into Telegram send actions

This path now maps shared interactive payloads into Telegram buttons, but it still derives message content only from message/caption. In send calls where media is present (so message is optional), interactive text blocks are dropped and users receive buttons without the authored prompt text. The outbound Telegram adapter already applies interactive text fallback, so message-action sends are now inconsistent and lose user-visible content.

Useful? React with 👍 / 👎.

Comment on lines +45 to +47
const rawComponents =
params.components ??
buildDiscordInteractiveComponents(normalizeInteractiveReply(params.interactive));
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Carry interactive text fallback into Discord send actions

This conversion enables shared interactive components for Discord, but content is still read only from message. When a send includes media plus interactive text blocks and omits message, hasComponents bypasses the required-content guard and the component message is sent without the interactive prompt text. That drops authored context and diverges from the Discord outbound adapter, which applies interactive text fallback.

Useful? React with 👍 / 👎.

@steipete steipete merged commit 98877dc into openclaw:main Mar 16, 2026
27 of 33 checks passed
@steipete
Copy link
Copy Markdown
Contributor

Landed via rebase onto main.

  • PR merge commit: 98877dc
  • Follow-up fix commit: d937b61
  • Local gate: pnpm check, pnpm build, pnpm test

Notes:

  • The follow-up fixed the missed shared-interactive regressions and synced the lockfile so Install Smoke and Docker Release are green on the new head.
  • main was already red before the follow-up (823039c000b6863d5394b5512dae2c1cc25741a2 had failing CI, Install Smoke, and Docker Release). After the follow-up push, Workflow Sanity, Install Smoke, and Docker Release are green; the remaining CI red is in unrelated preexisting lanes.

Thanks @vincentkoc!

pengwork pushed a commit to pengwork/openclaw that referenced this pull request Mar 16, 2026
vincentkoc pushed a commit to vincentkoc/openclaw that referenced this pull request Mar 16, 2026
romeroej2 pushed a commit to romeroej2/openclaw that referenced this pull request Mar 16, 2026
jonBoone added a commit to jonBoone/openclaw that referenced this pull request Mar 17, 2026
* refactor: make setup the primary wizard surface

* test: move setup surface coverage

* docs: prefer setup wizard command

* fix: follow up shared interactive regressions (openclaw#47715)

* fix(plugins): resolve lazy runtime from package root

* fix(daemon): accept 'Last Result' schtasks key variant on Windows (openclaw#47726)

Some Windows locales/versions emit 'Last Result' instead of 'Last Run Result' in schtasks output, causing gateway status to falsely report 'Runtime: unknown'. Fall back to the shorter key when the canonical key is absent.

* fix: accept schtasks Last Result key on Windows (openclaw#47844) (thanks @MoerAI)

* refactor(plugins): move auth profile hooks into providers

* fix: resume orphaned subagent sessions after SIGUSR1 reload

Closes openclaw#47711

After a SIGUSR1 gateway reload aborts in-flight subagent LLM calls, the gateway now scans for orphaned sessions and sends a synthetic resume message to restart their work. Also makes the deferral timeout configurable via gateway.reload.deferralTimeoutMs (default: 5 minutes, up from 90s).

* fix: address Greptile review feedback

- Remove unrelated pnpm-lock.yaml changes
- Move abortedLastRun flag clearing to AFTER successful resume
  (prevents permanent session loss on transient gateway failures)
- Use dynamic import for orphan recovery module to avoid startup
  memory overhead
- Add test assertion that flag is preserved on resume failure

* fix: add retry with exponential backoff for orphan recovery

Addresses Codex review feedback — if recovery fails (e.g. gateway
still booting), retries up to 3 times with exponential backoff
(5s → 10s → 20s) before giving up.

* fix: address all review comments on PR openclaw#47719 + implement resume context and config idempotency guard

* fix: address 6 review comments on PR openclaw#47719

1. [P1] Treat remap failures as resume failures — if replaceSubagentRunAfterSteer
   returns false, do NOT clear abortedLastRun, increment failed count.

2. [P2] Count scan-level exceptions as retryable failures — set result.failed > 0
   in the outer catch block so scheduleOrphanRecovery retry logic triggers.

3. [P2] Persist resumed-session dedupe across recovery retries — accept
   resumedSessionKeys as a parameter; scheduleOrphanRecovery lifts the Set to
   its own scope and passes it through retries.

4. [Greptile] Use typed config accessors instead of raw structural cast for TLS
   check in lifecycle.ts.

5. [Greptile] Forward gateway.reload.deferralTimeoutMs to deferGatewayRestartUntilIdle
   in scheduleGatewaySigusr1Restart so user-configured value is not silently ignored.

6. [Greptile] Same as openclaw#4 — already addressed by the typed config fix.

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

* fix: land SIGUSR1 orphan recovery regressions (openclaw#47719) (thanks @joeykrug)

* refactor: move channel messaging hooks into plugins

* fix: stabilize windows parallels smoke harness

* refactor(plugins): move provider onboarding auth into plugins

* docs: restore onboard as canonical setup command

* docs: restore onboard docs references

* refactor: move channel capability diagnostics into plugins

* refactor: split slack block action handling

* refactor: split plugin interactive dispatch adapters

* refactor: unify reply content checks

* refactor: extract discord shared interactive mapper

* refactor: unify telegram interactive button resolution

* build: add land gate parity script

* test: fix setup wizard smoke mocks

* docs: sync config baseline

* Status: split heartbeat summary helpers

* Security: trim audit policy import surfaces

* Security: lazy-load deep skill audit helpers

* Security: lazy-load audit config snapshot IO

* Config: keep native command defaults off heavy channel registry

* Status: split lightweight gateway agent list

* refactor(plugins): simplify provider auth choice metadata

* test: add openshell sandbox e2e smoke

* feishu: add structured card actions and interactive approval flows (openclaw#47873)

* feishu: add structured card actions and interactive approval flows

* feishu: address review fixes and test-gate regressions

* feishu: hold inflight card dedup until completion

* feishu: restore fire-and-forget bot menu handling

* feishu: format card interaction helpers

* Feishu: add changelog entry for card interactions

* Feishu: add changelog entry for ACP session binding

* build: remove land gate script

* Status: lazy-load tailscale and memory scan deps

* Tests: fix Feishu full registration mock

* Tests: cover plugin capability matrix

* Gateway: import normalizeAgentId in hooks

* fix: recover bonjour advertiser from ciao announce loops

* fix: preserve loopback gateway scopes for local auth

* Status: lazy-load summary session helpers

* Status: lazy-load security audit commands

* refactor: move channel delivery and ACP seams into plugins

* Security: split audit runtime surfaces

* Tests: add channel actions contract helper

* Tests: add channel plugin contract helper

* Tests: add Slack channel contract suite

* Tests: add Mattermost channel contract suite

* Tests: add Telegram channel contract suite

* Tests: add Discord channel contract suite

* fix(session): preserve external channel route when webchat views session (openclaw#47745)

When a Telegram/WhatsApp/iMessage session was viewed or messaged from the
dashboard/webchat, resolveLastChannelRaw() unconditionally returned 'webchat'
for any isDirectSessionKey() or isMainSessionKey() match, overwriting the
persisted external delivery route.

This caused subagent completion events to be delivered to the webchat/dashboard
instead of the original channel (Telegram, WhatsApp, etc.), silently dropping
messages for the channel user.

Fix: only allow webchat to own routing when no external delivery route has been
established (no persisted external lastChannel, no external channel hint in the
session key). If an external route exists, webchat is treated as admin/monitoring
access and must not mutate the delivery route.

Updated/added tests to document the correct behaviour.

Fixes openclaw#47745

* fix: address bot nit on session route preservation (openclaw#47797) (thanks @brokemac79)

* Tests: add plugin contract suites

* Tests: add plugin contract registry

* Tests: add global plugin contract suite

* Tests: add global actions contract suite

* Tests: add global setup contract suite

* Tests: add global status contract suite

* Tests: replace local channel contracts

* refactor(plugins): move onboarding auth metadata to manifests

* refactor: move remaining channel seams into plugins

* refactor: add plugin-owned outbound adapters

* fix: scope localStorage settings key by basePath to prevent cross-deployment conflicts

- Add settingsKeyForGateway() function similar to tokenSessionKeyForGateway()
- Use scoped key format: openclaw.control.settings.v1:https://example.com/gateway-a
- Add migration from legacy static key on load
- Fixes openclaw#47481

* Tests: add provider contract suites

* Tests: add provider contract registry

* Tests: add global provider contract suite

* Tests: add global web search contract suite

* fix: stabilize ci gate

* Tests: add provider registry contract suite

* Tests: relax provider auth hint contract

* !refactor(browser): remove Chrome extension path and add MCP doctor migration (openclaw#47893)

* Browser: replace extension path with Chrome MCP

* Browser: clarify relay stub and doctor checks

* Docs: mark browser MCP migration as breaking

* Browser: reject unsupported profile drivers

* Browser: accept clawd alias on profile create

* Doctor: narrow legacy browser driver migration

* feishu: harden media support and align capability docs (openclaw#47968)

* feishu: harden media support and action surface

* feishu: format media action changes

* feishu: fix review follow-ups

* fix: scope Feishu target aliases to Feishu (openclaw#47968) (thanks @Takhoffman)

* fix: make docs i18n use gpt-5.4 overrides

* docs: regenerate zh-CN onboarding references

* Tests: tighten provider wizard contracts

* Tests: add plugin loader contract suite

* refactor: remove dock shim and move session routing into plugins

* Plugins: add provider runtime contracts

* GitHub Copilot: move runtime tests to provider contracts

* Z.ai: move runtime tests to provider contracts

* Anthropic: move runtime tests to provider contracts

* Google: move runtime tests to provider contracts

* OpenAI: move runtime tests to provider contracts

* Qwen Portal: move runtime tests to provider contracts

* fix(core): restore outbound fallbacks and gate checks

* style(core): normalize rebase fallout

* fix: accept sandbox plugin id hints

* Plugins: capture tool registrations in test registry

* Plugins: cover Firecrawl tool ownership

* Firecrawl: drop local registration contract test

* Plugins: add provider catalog contracts

* Plugins: narrow provider runtime contracts

* refactor(plugin-sdk): use scoped core imports for bundled channels

* fix: unblock ci gates

* Plugins: add provider wizard contracts

* fix: unblock docs and registry checks

* refactor: finish plugin-owned channel runtime seams

* refactor(plugin-sdk): clean shared core imports

* Plugins: add provider auth contracts

* Plugins: dedupe routing imports in channel adapters

* Plugins: add provider discovery contracts

* fix: stop bonjour before re-advertising

* Plugins: extend provider discovery contracts

* docs: codify macOS parallels discord smoke

* refactor: move session lifecycle and outbound fallbacks into plugins

* refactor(plugins): derive compat provider ids from manifests

* Plugins: cover catalog discovery providers

* Tests: type auth contract prompt mocks

* fix: mount CLI auth dirs in docker live tests

* refactor: route shared channel sdk imports through plugin seams

* Plugins: add auth choice contracts

* Plugins: restore routing seams and discovery fixtures

* fix: harden bonjour retry recovery

* Runtime: lazy-load channel runtime singletons

* refactor: tighten plugin sdk channel seams

* refactor: route remaining channel imports through plugin sdk

* refactor(plugins): finish provider auth boundary cleanup

* fix(infra): wire gaxios-fetch-compat shim to prevent node-fetch crash on Node.js 25

* fix(infra): also wire gaxios-fetch-compat shim into src/index.ts (gateway entry)

* fix: keep gaxios compat off the package root (openclaw#47914) (thanks @pdd-cli)

* refactor: shrink public channel plugin sdk surfaces

* refactor: add private channel sdk bridges

* fix: restore effective setup wizard lazy import

* docs: add frontmatter to parallels discord skill

* fix: retry runtime postbuild skill copy races

* Gateway: lazily resolve channel runtime

* Gateway: cover lazy channel runtime resolution

* Plugins: add Claude marketplace registry installs (openclaw#48058)

* Changelog: note Claude marketplace plugin support

* Plugins: add Claude marketplace installs

* E2E: cover marketplace plugin installs in Docker

* UI: keep thinking helpers browser-safe

* Infra: restore check after gaxios compat

* Docs: refresh generated config baseline

* docs: reorder unreleased changelog entries

* fix: split browser-safe thinking helpers

* fix(macos): restore debug build helpers (openclaw#48046)

* Docs: add Claude marketplace plugin install guidance

* Channels: expand contract suites

* Channels: add contract surface coverage

* Channels: centralize outbound payload contracts

* Channels: centralize group policy contracts

* Channels: centralize inbound context contracts

* Tests: add contract runner

* Tests: harden WhatsApp inbound contract cleanup

* Tests: add extension test runner

* Runtime: lazy-load Discord channel ops

* Docs: use placeholders for marketplace plugin examples

* Release: trim generated docs from npm pack

* Runtime: lazy-load Telegram and Slack channel ops

* Tests: detect changed extensions

* Tests: cover changed extension detection

* Docs: add extension test workflow

* CI: add changed extension test lane

* BlueBubbles: lazy-load channel runtime paths

* Plugin SDK: restore scoped imports for bundled channels

* Plugin SDK: consolidate shared channel exports

* Channels: fix surface contract plugin lookup

* Status: stabilize startup memory probes

* Media: avoid slow auth misses in auto-detect

* Tests: scope Codex bundle loader fixture

* Tests: isolate bundle surface fixtures

* feat(telegram): add configurable silent error replies (openclaw#19776)

Port and complete openclaw#19776 on top of the current Telegram extension layout.

Adds a default-off `channels.telegram.silentErrorReplies` setting. When enabled, Telegram bot replies marked as errors are delivered silently across the regular bot reply flow, native/slash command replies, and fallback sends.

Thanks @auspic7 

Co-authored-by: Myeongwon Choi <[email protected]>
Co-authored-by: ImLukeF <[email protected]>

* fix(ui): auto load Usage tab data on navigation

* fix(telegram): keep silent error fallback replies quiet

* test(gateway): restore agent request route mock

* Cron: isolate active-model delivery tests

* Tests: align media auth fixture with selection checks

* Plugins: preserve lazy runtime provider resolution

* Bootstrap: report nested entry import misses

* fix(channels): parse bundled targets without plugin registry

* test(telegram): cover shared parsing without registry

* Plugin SDK: split setup and sandbox subpaths

* Providers: centralize setup defaults and helper boundaries

* Plugins: decouple bundled web search discovery

* Plugin SDK: update entrypoint metadata

* Secrets: honor caller env during runtime validation

* Tests: align Docker cache checks with non-root images

* Plugin SDK: keep root alias reflection lazy

* Providers: scope compat resolution to owning plugins

* Plugin SDK: add narrow setup subpaths

* Plugin SDK: update entrypoint metadata

* fix(slack): harden bolt import interop (openclaw#45953)

* fix(slack): harden bolt import interop

* fix(slack): simplify bolt interop resolver

* fix(slack): harden startup bolt interop

* fix(slack): place changelog entry at section end

---------

Co-authored-by: Ubuntu <[email protected]>
Co-authored-by: Altay <[email protected]>

* Tests: fix green check typing regressions

* Plugins: avoid booting bundled providers for catalog hooks

* fix: bypass telegram runtime proxy during health checks

* fix: align telegram probe test mock

* test: remove stale synology zod mock

* fix(android): reduce chat recomposition churn

* fix(android): preserve chat message identity on refresh

* fix(android): shrink chat image attachments

* Browser: support non-Chrome existing-session profiles via userDataDir (openclaw#48170)

Merged via squash.

Prepared head SHA: e490035
Co-authored-by: velvet-shark <[email protected]>
Co-authored-by: velvet-shark <[email protected]>
Reviewed-by: @velvet-shark

* fix(local-storage): improve VITEST environment check for localStorage access

* fix: normalize discord commands allowFrom auth

* test: update discord subagent hook mocks

* test: mock telegram native command reply pipeline

* fix(android): lazy-init node runtime after onboarding

* docs(config): refresh generated baseline

* Plugins: share channel plugin id resolution

* Gateway: defer full channel plugins until after listen

* Gateway: gate deferred channel startup behind opt-in

* Docs: document deferred channel startup opt-in

* feat(skills): preserve all skills in prompt via compact fallback before dropping (openclaw#47553)

* feat(skills): add compact format fallback for skill catalog truncation

When the full-format skill catalog exceeds the character budget,
applySkillsPromptLimits now tries a compact format (name + location
only, no description) before binary-searching for the largest fitting
prefix. This preserves full model awareness of registered skills in
the common overflow case.

Three-tier strategy:
1. Full format fits → use as-is
2. Compact format fits → switch to compact, keep all skills
3. Compact still too large → binary search largest compact prefix

Other changes:
- escapeXml() utility for safe XML attribute values
- formatSkillsCompact() emits same XML structure minus <description>
- Compact char-budget check reserves 150 chars for the warning line
  the caller prepends, preventing prompt overflow at the boundary
- 13 tests covering all tiers, edge cases, and budget reservation
- docs/.generated/config-baseline.json: fix pre-existing oxfmt issue

* docs: document compact skill prompt fallback

---------

Co-authored-by: Frank Yang <[email protected]>

* Gateway: simplify startup and stabilize mock responses tests

* test: fix stale web search and boot-md contracts

* Gateway tests: centralize mock responses provider setup

* Gateway tests: share ordered client teardown helper

* Infra: ignore ciao probing cancellations

* Docs: repair unreleased changelog attribution

* Docs: normalize unreleased changelog refs

* Channels: ignore enabled-only disabled plugin config

* perf: reduce status json startup memory

* perf: lazy-load status route startup helpers

* Plugins: stage local bundled runtime tree

* Build: share root dist chunks across tsdown entries

* fix(logging): make logger import browser-safe

* fix(changelog): add entry for Control UI logger import fix (openclaw#48469)

* fix(changelog): note Control UI logger import fix

* fix(changelog): attribute Control UI logger fix entry

* fix(changelog): credit original Control UI fix author

* Plugins: remove public extension-api surface (openclaw#48462)

* Plugins: remove public extension-api surface

* Plugins: fix loader setup routing follow-ups

* CI: ignore non-extension helper dirs in extension-fast

* Docs: note extension-api removal as breaking

* fix(ui): language dropdown selection not persisting after refresh (openclaw#48019)

Merged via squash.

Prepared head SHA: 06c8258
Co-authored-by: git-jxj <[email protected]>
Co-authored-by: altaywtf <[email protected]>
Reviewed-by: @altaywtf

* fix(plugins): late-binding subagent runtime for non-gateway load paths (openclaw#46648)

Merged via squash.

Prepared head SHA: 4474265
Co-authored-by: jalehman <[email protected]>
Co-authored-by: jalehman <[email protected]>
Reviewed-by: @jalehman

* fix: enable auto-scroll during assistant response streaming

Fix auto-scroll behavior when AI assistant streams responses in the web UI.
Previously, the viewport would remain at the sent message position and users
had to manually click a badge to see streaming responses.

Fixes openclaw#14959

Changes:
- Reset chat scroll state before sending message to ensure viewport readiness
- Force scroll to bottom after message send to position viewport correctly
- Detect streaming start (chatStream: null -> string) and trigger auto-scroll
- Ensure smooth scroll-following during entire streaming response

Co-Authored-By: Claude Opus 4.6 <[email protected]>

* fix(ui): align chatStream lifecycle type with nullable state

* fix(whatsapp): restore implicit reply mentions for LID identities (openclaw#48494)

Threads selfLid from the Baileys socket through the inbound WhatsApp
pipeline and adds LID-format matching to the implicit mention check
in group gating, so reply-to-bot detection works when WhatsApp sends
the quoted sender in @lid format.

Also fixes the device-suffix stripping regex (was a silent no-op).

Closes openclaw#23029

Co-authored-by: sparkyrider <[email protected]>
Reviewed-by: @ademczuk

* fix(compaction): stabilize toolResult trim/prune flow in safeguard (openclaw#44133)

Merged via squash.

Prepared head SHA: ec789c6
Co-authored-by: SayrWolfridge <[email protected]>
Co-authored-by: jalehman <[email protected]>
Reviewed-by: @jalehman

* Fix launcher startup regressions (openclaw#48501)

* Fix launcher startup regressions

* Fix CI follow-up regressions

* Fix review follow-ups

* Fix workflow audit shell inputs

* Handle require resolve gaxios misses

* fix: remove orphaned tool_result blocks during compaction (openclaw#15691) (openclaw#16095)

Merged via squash.

Prepared head SHA: b772432
Co-authored-by: claw-sylphx <[email protected]>
Co-authored-by: jalehman <[email protected]>
Reviewed-by: @jalehman

* docs: rename onboarding user-facing wizard copy

Co-authored-by: Tak <[email protected]>

* fix(plugins): keep built plugin loading on one module graph (openclaw#48595)

* Plugins: stabilize global catalog contracts

* Channels: add global threading and directory contracts

* Tests: improve extension runner discovery

* CI: run global contract lane

* Plugins: speed up auth-choice contracts

* Plugins: fix catalog contract mocks

* refactor: move provider catalogs into extensions

* refactor: route bundled channel setup helpers through private sdk bridges

* test: fix check contract type drift

* Tests: lock plugin slash commands to one runtime graph

* Tests: cover Discord provider plugin registry

* Tests: pin loader command activation semantics

* Tests: cover Telegram plugin auth on real registry

* refactor(slack): share setup helpers

* refactor(whatsapp): reuse shared normalize helpers

* Tlon: lazy-load channel runtime paths

* Tests: document Discord plugin auth gating

* feat(plugins): add speech provider registration

* docs(plugins): document capability ownership model

* fix: detect Ollama "prompt too long" as context overflow error (openclaw#34019)

Merged via squash.

Prepared head SHA: 825a402
Co-authored-by: lishuaigit <[email protected]>
Co-authored-by: jalehman <[email protected]>
Reviewed-by: @jalehman

* agent: preemptive context overflow detection during tool loops (openclaw#29371)

Merged via squash.

Prepared head SHA: 19661b8
Co-authored-by: keshav55 <[email protected]>
Co-authored-by: jalehman <[email protected]>
Reviewed-by: @jalehman

---------

Co-authored-by: Peter Steinberger <[email protected]>
Co-authored-by: MoerAI <[email protected]>
Co-authored-by: Joey Krug <[email protected]>
Co-authored-by: bot_apk <[email protected]>
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: Vincent Koc <[email protected]>
Co-authored-by: Tak Hoffman <[email protected]>
Co-authored-by: brokemac79 <[email protected]>
Co-authored-by: ObitaBot <[email protected]>
Co-authored-by: Prompt Driven <[email protected]>
Co-authored-by: Nimrod Gutman <[email protected]>
Co-authored-by: Gustavo Madeira Santana <[email protected]>
Co-authored-by: Myeongwon Choi <[email protected]>
Co-authored-by: Myeongwon Choi <[email protected]>
Co-authored-by: ImLukeF <[email protected]>
Co-authored-by: 郑耀宏 <[email protected]>
Co-authored-by: Ayaan Zaidi <[email protected]>
Co-authored-by: huntharo <[email protected]>
Co-authored-by: Yauheni Shauchenka <[email protected]>
Co-authored-by: Ubuntu <[email protected]>
Co-authored-by: Altay <[email protected]>
Co-authored-by: Radek Sienkiewicz <[email protected]>
Co-authored-by: velvet-shark <[email protected]>
Co-authored-by: Val Alexander <[email protected]>
Co-authored-by: Hung-Che Lo <[email protected]>
Co-authored-by: Frank Yang <[email protected]>
Co-authored-by: git-jxj <[email protected]>
Co-authored-by: git-jxj <[email protected]>
Co-authored-by: altaywtf <[email protected]>
Co-authored-by: Josh Lehman <[email protected]>
Co-authored-by: jalehman <[email protected]>
Co-authored-by: Jaewon Hwang <[email protected]>
Co-authored-by: Claude Opus 4.6 <[email protected]>
Co-authored-by: sparkyrider <[email protected]>
Co-authored-by: sparkyrider <[email protected]>
Co-authored-by: Sayr Wolfridge <[email protected]>
Co-authored-by: SayrWolfridge <[email protected]>
Co-authored-by: Clayton Shaw <[email protected]>
Co-authored-by: claw-sylphx <[email protected]>
Co-authored-by: Tak <[email protected]>
Co-authored-by: lishuaigit <[email protected]>
Co-authored-by: lishuaigit <[email protected]>
Co-authored-by: Keshav Rao <[email protected]>
Co-authored-by: keshav55 <[email protected]>
dustin-olenslager pushed a commit to dustin-olenslager/ironclaw-supreme that referenced this pull request Mar 24, 2026
sbezludny pushed a commit to sbezludny/openclaw that referenced this pull request Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agents Agent runtime and tooling channel: discord Channel integration: discord channel: feishu Channel integration: feishu channel: matrix Channel integration: matrix channel: mattermost Channel integration: mattermost channel: msteams Channel integration: msteams channel: slack Channel integration: slack channel: telegram Channel integration: telegram channel: zalo Channel integration: zalo cli CLI command changes maintainer Maintainer-authored PR size: XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants