This is a comment left during a code review.
Path: extensions/msteams/src/monitor-handler.file-consent.test.ts
Line: 175-180

Comment:
**Test data mismatch on FileInfoCard name assertion**

`storePendingUpload` registers the pending file as `"report.pdf"`, but the assertion checks that `updateActivity` was called with `name: "secret.txt"`.

The code is actually correct — `buildFileInfoCard` reads from `consentResponse.uploadInfo.name`, which is hardcoded to `"secret.txt"` in the `createInvokeContext` helper — not from `pendingFile.filename`. However, the inconsistency between the registered filename (`"report.pdf"`) and the asserted name (`"secret.txt"`) is misleading for future maintainers. Anyone reading this test would expect the stored filename (`"report.pdf"`) to appear in the confirmation card.

Consider aligning the test data: either change `storePendingUpload`'s filename to `"secret.txt"` to match the hardcoded `uploadInfo.name`, or update `createInvokeContext` to take the upload name as a parameter so the two values can be made consistent.

```suggestion
    const uploadId = storePendingUpload({
      buffer: Buffer.from("file content"),
      filename: "secret.txt",
      contentType: "application/pdf",
      conversationId: "19:[email protected]",
    });
```

How can I resolve this? If you propose a fix, please make it concise.

---

This is a comment left during a code review.
Path: extensions/msteams/src/monitor-handler.file-consent.test.ts
Line: 254-286

Comment:
**Missing test coverage for `updateActivity` not being defined**

The three new test cases cover:
1. `updateActivity` present + `replyToId` present → in-place update ✅
2. `updateActivity` present + `replyToId` present, but update throws → fallback ✅
3. `updateActivity` present + `replyToId` absent → fallback ✅

But there is no test for `context.updateActivity` itself being `undefined` (i.e., the SDK version doesn't expose it). The `typeof context.updateActivity === "function"` guard in `monitor-handler.ts` specifically handles this case, so a test should verify it falls back to `sendActivity` correctly.

```suggestion
  it("sends FileInfoCard as new message when updateActivity is not available on context", async () => {
    const uploadId = storePendingUpload({
      buffer: Buffer.from("file content"),
      filename: "secret.txt",
      contentType: "application/pdf",
      conversationId: "19:[email protected]",
    });
    const deps = createDeps();
    const handler = registerMSTeamsHandlers(createActivityHandler(), deps);
    const { context, sendActivity } = createInvokeContext({
      conversationId: "19:[email protected];messageid=abc123",
      uploadId,
      action: "accept",
      replyToId: "consent-card-activity-id",
    });

    // Simulate SDK without updateActivity support
    (context as Record<string, unknown>).updateActivity = undefined;

    await handler.run?.(context);

    expect(sendActivity).toHaveBeenCalledWith(
      expect.objectContaining({
        type: "message",
        attachments: [
          expect.objectContaining({
            contentType: "application/vnd.microsoft.teams.card.file.info",
          }),
        ],
      }),
    );
  });
```

How can I resolve this? If you propose a fix, please make it concise.

---

This is a comment left during a code review.
Path: extensions/msteams/src/monitor-handler.ts
Line: 112-116

Comment:
**Consider explicitly clearing `text` in the `updateActivity` payload**

The activity sent to `updateActivity` only specifies `id`, `type`, and `attachments`. If the original FileConsentCard message was sent with a `text` field (or if Teams preserves the previous `text` during a partial update), the stale text would remain visible in the updated card alongside the new FileInfoCard attachment.

Bot Framework's update semantics perform a full replacement of the activity, so omitting `text` should effectively leave it empty. However, being explicit makes the intent clear and guards against any SDK version that might merge fields rather than replace them:

```suggestion
            await context.updateActivity({
              id: consentActivityId,
              type: "message",
              text: "",
              attachments: [fileInfoCard],
            });
```

How can I resolve this? If you propose a fix, please make it concise.