Skip to content

fix(node): remove debug console.log on node host startup#46515

Merged
ademczuk merged 1 commit intoopenclaw:mainfrom
ademczuk:fix/remove-node-host-path-debug-log
Mar 14, 2026
Merged

fix(node): remove debug console.log on node host startup#46515
ademczuk merged 1 commit intoopenclaw:mainfrom
ademczuk:fix/remove-node-host-path-debug-log

Conversation

@ademczuk
Copy link
Copy Markdown
Contributor

Removes a leftover console.log("node host PATH: ...") in src/node-host/runner.ts that prints the resolved PATH environment on every openclaw node run invocation. Not useful for end users.

Fixes #46411

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Mar 14, 2026

Greptile Summary

This PR removes a leftover debug console.log("node host PATH: ...") from src/node-host/runner.ts that was printing the resolved PATH environment variable on every openclaw node run invocation, and adds a corresponding CHANGELOG entry.

  • The two removed lines (the // eslint-disable-next-line no-console directive and the console.log call) are the only change to the source code.
  • The pathEnv variable returned by ensureNodePathEnv() is still used correctly on line 196 (passed to GatewayClient) and line 225 (passed to SkillBinsCache), so no functional behavior is changed.
  • The CHANGELOG entry is correctly placed in the unreleased section and references the originating issue ([Bug]: Debug console.log "node host PATH" printed on every node start #46411).

Confidence Score: 5/5

  • This PR is safe to merge — it removes only a debug log statement with no functional side-effects.
  • The change is minimal and surgical: two lines removed, both verified to have no impact on runtime behavior. The pathEnv variable is still used as intended, and the CHANGELOG update is accurate.
  • No files require special attention.

Last reviewed commit: c9f9fd1

@ademczuk ademczuk force-pushed the fix/remove-node-host-path-debug-log branch from c9f9fd1 to 82bce69 Compare March 14, 2026 20:15
@ademczuk ademczuk merged commit 747609d into openclaw:main Mar 14, 2026
12 checks passed
@ademczuk ademczuk deleted the fix/remove-node-host-path-debug-log branch March 14, 2026 20:30
Maple778 added a commit to Maple778/openclaw that referenced this pull request Mar 19, 2026
Pattern from PR openclaw#46515

The previous proposal incorrectly identified the entire 'pretty print' block (lines 256-272) as the bug, suggesting its removal, which would break the tool's default output mode for human-readable logs. The validation feedback correctly identifies that only the specific debug log at line 263 (printing the node name) is the leftover debug code. I have revised the fix to target only line 263 for removal, preserving the surrounding table formatting logic (lines 256-262 and 264-272) which represents the legitimate functionality of the script.
Maple778 added a commit to Maple778/openclaw that referenced this pull request Mar 19, 2026
Pattern from PR openclaw#46515

The previous proposal incorrectly identified the entire 'pretty print' block (lines 256-272) as the bug, suggesting its removal, which would break the tool's default output mode for human-readable logs. The validation feedback correctly identifies that only the specific debug log at line 263 (printing the node name) is the leftover debug code. I have revised the fix to target only line 263 for removal, preserving the surrounding table formatting logic (lines 256-262 and 264-272) which represents the legitimate functionality of the script.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer Maintainer-authored PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Debug console.log "node host PATH" printed on every node start

1 participant