fix: add Windows npm global path resolution for Gemini CLI OAuth (closes #30403)#46368
fix: add Windows npm global path resolution for Gemini CLI OAuth (closes #30403)#46368Br1an67 wants to merge 1 commit intoopenclaw:mainfrom
Conversation
Greptile SummaryThis PR adds a Windows-specific fallback to Key changes:
One minor caveat worth noting: the APPDATA path ( Confidence Score: 4/5
Last reviewed commit: 8699be4 |
openclaw#30403) On Windows, npm global packages live under %APPDATA%\npm\node_modules but the bin shim (.cmd) may not be in PATH or may not resolve via realpathSync like Unix symlinks do. This adds: 1. A fallback in extractGeminiCliCredentials() that checks %APPDATA%/npm/ node_modules/@google/gemini-cli directly when findInPath() fails on Windows. 2. An additional candidate in resolveGeminiCliDirs() for the APPDATA npm global path, so even when the binary IS found, the oauth2.js lookup succeeds. Co-authored-by: Copilot <[email protected]>
|
Closing to manage active PR count. Will reopen when slot is available. |
Summary
Change Type
Linked Issue/PR
Security Impact
All No
Evidence
Compatibility / Migration
Failure Recovery
This PR was AI-assisted (fully tested with pnpm build/check/test).