fix(feishu): add wsConfig with PingInterval/PingTimeout to WSClient#45674
Closed
alex-xuweilong wants to merge 1 commit intoopenclaw:mainfrom
Closed
fix(feishu): add wsConfig with PingInterval/PingTimeout to WSClient#45674alex-xuweilong wants to merge 1 commit intoopenclaw:mainfrom
alex-xuweilong wants to merge 1 commit intoopenclaw:mainfrom
Conversation
The Feishu WebSocket client was created without wsConfig, causing the Lark SDK to fail with 'code: 1000040351, system busy' and 'Cannot read properties of undefined (reading PingInterval)'. This made WebSocket mode completely non-functional, forcing users to fall back to webhook mode which requires a public URL. Adds PingInterval: 30 and PingTimeout: 5 to match the Lark SDK's expected configuration. Fixes openclaw#42354
Contributor
Greptile SummaryThis PR fixes a critical, 100% reproducible bug where The fix is minimal and correct — adding
Confidence Score: 5/5
Last reviewed commit: d3c1e3f |
Contributor
|
Review: ✅ LGTM Clean XS fix. Adding WebSocket keep-alive config (30s ping interval, 5s timeout) prevents stale Feishu WS connections from silently dying. No breaking changes, no side effects. Ship it. |
Author
|
Thanks for the review! 🦞 |
Member
This was referenced Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Feishu WebSocket long connection failure that blocks all enterprise users from using WebSocket mode (100% reproducible).
Root Cause
createFeishuWSClient()inextensions/feishu/src/client.tscreates aLark.WSClientwithout thewsConfigparameter. The Lark SDK expectswsConfig.PingIntervalandwsConfig.PingTimeoutto be set — without them, the SDK throws:This makes WebSocket mode completely non-functional, forcing users to fall back to webhook mode which requires a public URL.
Fix
Added
wsConfig: { PingInterval: 30, PingTimeout: 5 }to the WSClient constructor, matching the Lark SDK's expected configuration.Testing
pnpm buildpasses (note: pre-existingchrome-mcp.tstype errors unrelated to this change)Fixes #42354