Greptile Summary

This PR fixes a startup ReferenceError: Cannot access 'ANTHROPIC_MODEL_ALIASES' before initialization by converting a module-level const in model-selection.ts into a lazy getter function getAnthropicModelAliases(). The change is minimal, correct, and well-justified — deferring object allocation to call time sidesteps the ES module Temporal Dead Zone issue triggered by the circular dependency chain between model-selection.ts and config/defaults.ts.

• src/agents/model-selection.ts: The const → function conversion is the right fix. The getter is only called from one internal function (normalizeAnthropicModelId) so there is no API surface change. A new 4-entry object is allocated per call, but normalizeAnthropicModelId lives in config-load paths rather than a tight hot loop, making the GC overhead negligible.
• src/agents/model-selection.test.ts: A regression test is added that exercises all four shorthand aliases. The test has a minor redundancy — two aliases are each called twice (once in not.toThrow(), once for value assertion) — and only two of the four canonical mappings have value assertions. Neither issue affects correctness.

Confidence Score: 5/5

• This PR is safe to merge — it is a minimal, targeted fix with no API changes and a clear root-cause analysis.
• The change is a one-function conversion of a module-level constant that directly resolves a reproducible crash. There are no import changes, no module boundary shifts, and no behavioral differences for callers. The existing test suite is expanded with a regression test. The only nit is a minor redundancy in the new test.
• No files require special attention.

This is a comment left during a code review.
Path: src/agents/model-selection.test.ts
Line: 206-218

Comment:
**Redundant `.not.toThrow()` calls and incomplete value coverage**

For `"opus-4.6"` and `"sonnet-4.5"`, the function is called twice — once inside `expect(() => ...).not.toThrow()` (result discarded) and once for the value assertion. A non-`null` return value already proves no throw was raised, so the `not.toThrow` wrappers for those two aliases are redundant.

Additionally, the resolved values for `"sonnet-4.6"` and `"opus-4.5"` are never asserted. Asserting all four canonical mappings would tighten the regression coverage without extra verbosity:

```suggestion
      expect(parseModelRef("opus-4.6", "anthropic")).toEqual({
        provider: "anthropic",
        model: "claude-opus-4-6",
      });
      expect(parseModelRef("sonnet-4.6", "anthropic")).toEqual({
        provider: "anthropic",
        model: "claude-sonnet-4-6",
      });
      expect(parseModelRef("opus-4.5", "anthropic")).toEqual({
        provider: "anthropic",
        model: "claude-opus-4-5",
      });
      expect(parseModelRef("sonnet-4.5", "anthropic")).toEqual({
        provider: "anthropic",
        model: "claude-sonnet-4-5",
      });
```

How can I resolve this? If you propose a fix, please make it concise.

_{Last reviewed commit: de16e87}

Addressed both review findings (commit 75f325c):

Greptile — redundant .not.toThrow() wrappers: Removed. A non-null return value already proves no throw was raised, so the double-call pattern for opus-4.6 and sonnet-4.5 is gone.

Greptile — incomplete value coverage: Added assertions for all four canonical mappings (opus-4.6, sonnet-4.6, opus-4.5, sonnet-4.5), giving complete regression coverage.

Both findings addressed:

Greptile (id 2933291044) — Fixed in commit 75f325c. Redundant .not.toThrow() wrappers removed; all four canonical alias mappings now have explicit value assertions.

P2 (id 2933300653) — Acknowledged. The unit test cannot recreate the circular-import TDZ failure mode because by the time the test body runs, model-selection.ts has already finished evaluating. Reproducing the crash requires a bundler-level circular-dependency scenario that is not feasible in a standard vitest run. The test documents the expected behaviour and the fix rationale; the actual protection comes from the code change (getter function deferring allocation to call time), not from the test being able to trigger the original crash path.