Greptile Summary

This PR replaces the legacy JourneyApps ZXing activity-based QR scanner with Google Code Scanner (play-services-code-scanner) for the onboarding flow. The scanning logic, setup-code parsing, and manual-entry fallback paths are all preserved correctly. Callbacks run on the main thread as guaranteed by the GMS Task API, so the Compose state mutations are safe.

Changes:

• build.gradle.kts: swaps com.journeyapps:zxing-android-embedded:4.3.0 for com.google.android.gms:play-services-code-scanner:16.1.0
• OnboardingFlow.kt: removes ScanContract/ScanOptions activity launcher; creates a GmsBarcodeScanner client with remember and invokes startScan() with success/failure/cancel listeners inline
• Adds resolveQrScannerError to produce a user-friendly error message that nudges users toward updating Play Services or using manual entry

Issues found:

• GmsBarcodeScanner implements AutoCloseable but qrScanner.close() is never called when the composable leaves composition — a DisposableEffect should be added to close the client on disposal

Confidence Score: 4/5

• Safe to merge; the migration is functionally correct with one minor resource-management improvement needed
• All scanning and code-parsing logic is faithfully ported, state mutations are on the main thread, and error handling is covered. The only gap is that GmsBarcodeScanner.close() is never called on composable disposal, which is a best-practice style issue rather than a functional bug.
• apps/android/app/src/main/java/ai/openclaw/app/ui/OnboardingFlow.kt — add a DisposableEffect to close the scanner client on disposal

This is a comment left during a code review.
Path: apps/android/app/src/main/java/ai/openclaw/app/ui/OnboardingFlow.kt
Line: 251

Comment:
**Scanner client not closed on disposal**

`GmsBarcodeScanner` implements `AutoCloseable`. The client returned by `GmsBarcodeScanning.getClient(...)` should be closed when the composable leaves composition to release its connection to Play Services. Currently there is no `DisposableEffect` that calls `qrScanner.close()`, so the connection is held until the `remember` slot is garbage-collected.

Add a companion `DisposableEffect` right after this `remember` call:

```kotlin
  val qrScanner = remember(context, qrScannerOptions) { GmsBarcodeScanning.getClient(context, qrScannerOptions) }
  DisposableEffect(qrScanner) {
    onDispose { qrScanner.close() }
  }
```

How can I resolve this? If you propose a fix, please make it concise.

_{Last reviewed commit: f04bcd5}

@codex review

Landed on main.

• Landed source commit: a738edb
• Merge commit: 45721d5