Greptile Summary

This PR makes normalizeModelCompat honour explicit true overrides from a model's compat config for non-native OpenAI-completions endpoints, rather than blanket-forcing both supportsDeveloperRole and supportsUsageInStreaming to false. The change is narrowly scoped to src/agents/model-compat.ts and its test file.

Key observations:

• Logic is correct. The new forcedDeveloperRole / forcedUsageStreaming boolean guards correctly implement "opt-in via explicit true; default to safe off". All four combinations (both set, one set, neither set) produce the expected output.
• Tests are well-updated. Two existing tests that asserted the old "always force off" behaviour have been inverted to match the new semantics, and a new test covering the default (no compat) case has been added.
• Minor style nit. forcedDeveloperRole || false and forcedUsageStreaming || false on lines 83–84 are redundant — both variables are already typed as boolean via the === true strict equality check.
• Minor test gap. The test at line 265 (respects supportsUsageInStreaming: true) doesn't also assert that supportsDeveloperRole is still forced to false for the same model, leaving a small regression surface unverified.

Confidence Score: 4/5

• This PR is safe to merge — the logic change is correct, well-tested, and strictly additive (opt-in only).
• The implementation correctly handles all flag combinations, the default safe behaviour is preserved, and the test suite covers the new scenarios. Only minor style redundancies and a small test coverage gap were found — no logical or runtime errors.
• No files require special attention.

This is a comment left during a code review.
Path: src/agents/model-compat.ts
Line: 83-84

Comment:
**Redundant `|| false` on boolean expressions**

`forcedDeveloperRole` and `forcedUsageStreaming` are already guaranteed to be `boolean` (the result of a strict equality check `=== true`), so `|| false` is a no-op and can be dropped for clarity.

```suggestion
          supportsDeveloperRole: forcedDeveloperRole,
          supportsUsageInStreaming: forcedUsageStreaming,
```

How can I resolve this? If you propose a fix, please make it concise.

---

This is a comment left during a code review.
Path: src/agents/model-compat.test.ts
Line: 265-274

Comment:
**Partially-set compat override not fully asserted**

When only `supportsUsageInStreaming: true` is set, `supportsDeveloperRole` should still be forced to `false`. The test currently only checks `supportsUsageInStreaming`, leaving the complementary flag's behaviour unverified for this specific combination. Consider adding the assertion to catch a potential regression where the other flag slips through:

```suggestion
    const normalized = normalizeModelCompat(model);
    expect(supportsUsageInStreaming(normalized)).toBe(true);
    expect(supportsDeveloperRole(normalized)).toBe(false);
```

How can I resolve this? If you propose a fix, please make it concise.

_{Last reviewed commit: 6921b11}

Thanks @cheapestinference.

Landed in 60cb1d6 from e2d9c2b.