Fix browser proxy JSON bridge handling in macOS app#44146
Open
caojm93 wants to merge 2 commits intoopenclaw:mainfrom
Open
Fix browser proxy JSON bridge handling in macOS app#44146caojm93 wants to merge 2 commits intoopenclaw:mainfrom
caojm93 wants to merge 2 commits intoopenclaw:mainfrom
Conversation
This comment was marked as spam.
This comment was marked as spam.
Author
|
Fixes the browser proxy crash discussed in: That issue includes the original reproduction steps, crash reports, and the |
Contributor
Greptile SummaryThis PR replaces the Key changes:
Confidence Score: 5/5
Last reviewed commit: 1df314d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JSONSerializationbridging inMacNodeBrowserProxywithAnyCodableplusJSONEncoder/JSONDecoderTesting
HOME=/tmp/openclaw-home CLANG_MODULE_CACHE_PATH=/tmp/clang-mod-cache SWIFTPM_MODULECACHE_OVERRIDE=/tmp/swiftpm-module-cache swift test --package-path /Users/caojiaming/Documents/Playground/openclaw/apps/macos --filter MacNodeBrowserProxyTestsOpenClaw.applocally from this branch and verifiedopenclaw browser open https://www.baidu.comsucceeds without generating a new macOS crash reportCloses #43872