GoogleChat: respect replyToMode for thread replies#43076
Closed
neeravmakwana wants to merge 1 commit into
Closed
Conversation
Preserve Google Chat thread references through the shared reply pipeline so off/first/all modes behave correctly without forcing implicit thread targets.
20 tasks
Contributor
Author
|
Superseded by #43112. I reran the replacement branch from the latest
Closing this older PR so reviewers can focus on the rebased, green replacement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
threadIdpath, soreplyToModefiltering onreplyToIddid not actually disable or limit threading.channels.googlechat.replyToMode: \"off\"still threaded replies, and\"first\"could keep threading follow-up payloads after the first reply.threadIdas an unconditional explicit thread target.AI-assisted: yes. Testing: fully tested locally.
Change Type (select all)
Scope (select all touched areas)
Linked Issue/PR
User-visible / Behavior Changes
Google Chat now respects
channels.googlechat.replyToModein the shared reply pipeline:offkeeps replies in the root conversationfirstonly threads the first replyallpreserves threaded replies consistentlySecurity Impact (required)
NoNoNoNoNoYes, explain risk + mitigation:Repro + Verification
Environment
channels.googlechat.replyToMode=off|first|allSteps
message.thread.nameset.replyToMode=off,first, andall.Expected
offstrips implicit threading.firstuses the thread only once.allpreserves the Google Chat thread reference consistently.Actual
threadIdpath even afterreplyToIdhad been filtered out.Evidence
Human Verification (required)
pnpm build, fullpnpm testreplyToMode=off,replyToMode=first, immediate monitor replies, routed shared-pipeline replies, typing-placeholder behavior for threaded repliespnpm checkis currently blocked by unrelated upstream errors insrc/config/model-alias-defaults.test.tsandsrc/cron/isolated-agent/run.tsReview Conversations
Compatibility / Migration
YesNoNoFailure Recovery (if this breaks)
a2b73e0bextensions/googlechat/src/monitor.ts,src/auto-reply/reply/route-reply.ts,src/auto-reply/reply/agent-runner-utils.tsreplyToMode=off, or later replies continuing to thread whenreplyToMode=firstRisks and Mitigations
CurrentMessageIdfor Google Chat, so regressions would show up as incorrect implicit threading rather than explicit send failures.Made with Cursor