Skip to content

docs: require codex review in contributing guide#42503

Merged
onutc merged 1 commit intoopenclaw:mainfrom
onutc:docs-contributing-codex-review
Mar 10, 2026
Merged

docs: require codex review in contributing guide#42503
onutc merged 1 commit intoopenclaw:mainfrom
onutc:docs-contributing-codex-review

Conversation

@onutc
Copy link
Copy Markdown
Contributor

@onutc onutc commented Mar 10, 2026

Summary

  • require contributors with Codex access to run codex review --base origin/main locally before opening or updating a PR
  • clarify that Codex findings are author-owned and should be addressed or explicitly resolved when not applicable
  • document that local codex review is still expected when GitHub Codex review does not trigger

Testing

  • not run (docs-only change)

@openclaw-barnacle openclaw-barnacle bot added size: XS maintainer Maintainer-authored PR labels Mar 10, 2026
@onutc onutc merged commit c00117a into openclaw:main Mar 10, 2026
23 checks passed
@onutc
Copy link
Copy Markdown
Contributor Author

onutc commented Mar 10, 2026

Merged pure doc PR without landpr

@onutc onutc deleted the docs-contributing-codex-review branch March 10, 2026 21:15
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Mar 10, 2026

Greptile Summary

This PR updates CONTRIBUTING.md to require contributors with Codex access to run codex review --base origin/main locally before opening or updating a PR, and clarifies expectations around handling Codex review findings.

The changes include:

  • Adds a codex review pre-PR step to the "Before You PR" checklist (line 89)
  • Adds two bullets to "Review Conversations Are Author-Owned" covering how to handle Codex comments and what to do when GitHub Codex review doesn't trigger (lines 103–104)
  • Adds a codex review checklist item to the "AI/Vibe-Coded PRs Welcome!" section (line 133)

The changes are internally consistent, accurately reflect the PR description, and are well-placed within the existing document structure with no broken links or contradictions.

Confidence Score: 5/5

  • Docs-only change with clear, consistent additions to contribution guidelines; safe to merge.
  • This is a docs-only change with no code modifications. All additions are clearly written, properly placed within existing sections, and align with the stated intent. No syntax errors, broken links, or contradictions with other sections. The three new requirements (local codex review before PR, handling Codex findings, and fallback to local review) are well-articulated and consistent throughout the document.
  • No files require special attention.

Last reviewed commit: ee95a42

mrosmarin added a commit to mrosmarin/openclaw that referenced this pull request Mar 10, 2026
* main: (42 commits)
  test: share runtime group policy fallback cases
  refactor: share windows command shim resolution
  refactor: share approval gateway client setup
  refactor: share telegram payload send flow
  refactor: share passive account lifecycle helpers
  refactor: share channel config schema fragments
  refactor: share channel config security scaffolding
  refactor: share onboarding secret prompt flows
  refactor: share scoped account config patching
  feat(discord): add autoArchiveDuration config option (openclaw#35065)
  fix(gateway): harden token fallback/reconnect behavior and docs (openclaw#42507)
  fix(acp): strip provider auth env for child ACP processes (openclaw#42250)
  fix(browser): surface 429 rate limit errors with actionable hints (openclaw#40491)
  fix(acp): scope cancellation and event routing by runId (openclaw#41331)
  docs: require codex review in contributing guide (openclaw#42503)
  Fix stale runtime model reuse on session reset (openclaw#41173)
  docs: document r: spam auto-close label
  fix(ci): auto-close and lock r: spam items
  fix(acp): implicit streamToParent for mode=run without thread (openclaw#42404)
  test: extract sendpayload outbound contract suite
  ...
frankekn pushed a commit to MoerAI/openclaw that referenced this pull request Mar 11, 2026
frankekn pushed a commit to Effet/openclaw that referenced this pull request Mar 11, 2026
frankekn pushed a commit to ImLukeF/openclaw that referenced this pull request Mar 11, 2026
Treedy2020 pushed a commit to Treedy2020/openclaw that referenced this pull request Mar 11, 2026
dhoman pushed a commit to dhoman/chrono-claw that referenced this pull request Mar 11, 2026
ahelpercn pushed a commit to ahelpercn/openclaw that referenced this pull request Mar 12, 2026
Ruijie-Ysp pushed a commit to Ruijie-Ysp/clawdbot that referenced this pull request Mar 12, 2026
leozhengliu-pixel pushed a commit to leozhengliu-pixel/openclaw that referenced this pull request Mar 13, 2026
senw-developers pushed a commit to senw-developers/va-openclaw that referenced this pull request Mar 17, 2026
alexey-pelykh pushed a commit to remoteclaw/remoteclaw that referenced this pull request Mar 27, 2026
alexey-pelykh pushed a commit to remoteclaw/remoteclaw that referenced this pull request Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer Maintainer-authored PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant