Text after card marker is silently dropped

fallbackText is set to only the substring before the opening marker. Any text appearing after <!--/adaptive-card--> is never captured and is silently discarded.

For example, if the AI message is:

Here is your summary:
<!--adaptive-card-->...<!--/adaptive-card-->
Please review the above card carefully.

The trailing sentence "Please review the above card carefully." would never be rendered.

Consider capturing the suffix text as well:

val prefix = text.substring(0, match.range.first).trim()
val suffix = text.substring(match.range.last + 1).trim()
val fallback = listOf(prefix, suffix).filter { it.isNotBlank() }.joinToString("\n\n")

This is a comment left during a code review.
Path: apps/android/app/src/main/java/ai/openclaw/app/chat/AdaptiveCardParser.kt
Line: 22

Comment:
**Text after card marker is silently dropped**

`fallbackText` is set to only the substring *before* the opening marker. Any text appearing after `<!--/adaptive-card-->` is never captured and is silently discarded.

For example, if the AI message is:
```
Here is your summary:
<!--adaptive-card-->...<!--/adaptive-card-->
Please review the above card carefully.
```
The trailing sentence "Please review the above card carefully." would never be rendered.

Consider capturing the suffix text as well:

```kotlin
val prefix = text.substring(0, match.range.first).trim()
val suffix = text.substring(match.range.last + 1).trim()
val fallback = listOf(prefix, suffix).filter { it.isNotBlank() }.joinToString("\n\n")
```

How can I resolve this? If you propose a fix, please make it concise.

Fixed in 9fb29e3. Parser now captures both prefix and suffix text around markers, stripping any <!--adaptive-card-data--> blocks from the suffix.

Unbounded recursion can cause StackOverflowError

RenderContainer calls RenderElement for each item, RenderElement can call RenderContainer (or RenderColumnSet → RenderElement → …) again, with no depth limit. A deeply nested card — or a maliciously crafted one — can exhaust the call stack and crash the app.

Consider tracking a depth counter and bailing out once it exceeds a reasonable bound (e.g. 10):

@Composable
private fun RenderElement(element: Map<String, Any>, depth: Int = 0) {
    if (depth > 10) {
        Log.w(TAG, "Max nesting depth exceeded, skipping element")
        return
    }
    // pass depth + 1 to RenderContainer / RenderColumnSet
    ...
}

This is a comment left during a code review.
Path: apps/android/app/src/main/java/ai/openclaw/app/ui/chat/AdaptiveCardComposable.kt
Line: 173-179

Comment:
**Unbounded recursion can cause `StackOverflowError`**

`RenderContainer` calls `RenderElement` for each item, `RenderElement` can call `RenderContainer` (or `RenderColumnSet` → `RenderElement` → …) again, with no depth limit. A deeply nested card — or a maliciously crafted one — can exhaust the call stack and crash the app.

Consider tracking a depth counter and bailing out once it exceeds a reasonable bound (e.g. 10):

```kotlin
@Composable
private fun RenderElement(element: Map<String, Any>, depth: Int = 0) {
    if (depth > 10) {
        Log.w(TAG, "Max nesting depth exceeded, skipping element")
        return
    }
    // pass depth + 1 to RenderContainer / RenderColumnSet
    ...
}
```

How can I resolve this? If you propose a fix, please make it concise.

Fixed in 9fb29e3. Added depth: Int = 0 parameter to RenderElement. Returns early when depth > 10. All recursive call sites pass depth + 1.

Unused import

stripCardMarkers is imported but never called anywhere in this file. It can be safely removed.

This is a comment left during a code review.
Path: apps/android/app/src/main/java/ai/openclaw/app/ui/chat/ChatMessageViews.kt
Line: 32

Comment:
**Unused import**

`stripCardMarkers` is imported but never called anywhere in this file. It can be safely removed.

```suggestion
import ai.openclaw.app.chat.parseAdaptiveCardMarkers
```

How can I resolve this? If you propose a fix, please make it concise.

Fixed in 9fb29e3. Removed unused stripCardMarkers import.

Dead else branch — both arms of the ternary return 1f

The fallback expression always evaluates to 1f regardless of which branch is taken, making the if/else pointless:

?: if (widthStr == "stretch" || widthStr == "auto" || widthStr == null) 1f else 1f
//                                                                             ^^^^ same value

This also means that an Adaptive Card column using an integer weight string (e.g., "width": "2") would never apply a proportional weight — toFloatOrNull() on "2" returns 2f correctly, but any string that fails to parse (e.g. "half") silently falls back to 1f without distinction. Simplify to:

This is a comment left during a code review.
Path: apps/android/app/src/main/java/ai/openclaw/app/ui/chat/AdaptiveCardComposable.kt
Line: 157-158

Comment:
**Dead `else` branch — both arms of the ternary return `1f`**

The fallback expression always evaluates to `1f` regardless of which branch is taken, making the `if`/`else` pointless:

```kotlin
?: if (widthStr == "stretch" || widthStr == "auto" || widthStr == null) 1f else 1f
//                                                                             ^^^^ same value
```

This also means that an Adaptive Card column using an integer weight string (e.g., `"width": "2"`) would never apply a proportional weight — `toFloatOrNull()` on `"2"` returns `2f` correctly, but any string that fails to parse (e.g. `"half"`) silently falls back to `1f` without distinction. Simplify to:

```suggestion
      val weight = widthStr?.removeSuffix("px")?.toFloatOrNull() ?: 1f
```

How can I resolve this? If you propose a fix, please make it concise.

Fixed in 9fb29e3. Simplified to val weight = widthStr?.removeSuffix("px")?.toFloatOrNull() ?: 1f.

Preserve text after adaptive-card marker blocks

The parser only stores text.substring(0, match.range.first) as fallback text, so any user-visible text that appears after <!--/adaptive-card--> is dropped once a card is detected. In ChatMessageBody, this fallback is the only non-card text rendered for parsed messages, which means messages containing intro + card + trailing explanation (or multiple card blocks) lose content in the UI.

Useful? React with 👍 / 👎.

Fixed in 9fb29e3 — same fix as the Greptile comment above (captures both prefix and suffix text).

Validate parsed column widths before applying weight

RenderColumnSet converts column["width"] to a float and feeds it directly into Modifier.weight(weight) without checking that it is finite and greater than zero. If a card contains width values like "0", "-1", or "NaN" (easy to hit with malformed or model-generated payloads), Compose throws when applying the modifier and the message render path crashes instead of failing gracefully.

Useful? React with 👍 / 👎.

Parse template-data markers when extracting adaptive cards

The parser only matches <!--adaptive-card-->...<!--/adaptive-card--> and reads templateData only from inside that JSON object, so it ignores the separate <!--adaptive-card-data-->...<!--/adaptive-card-data--> payload format. When messages carry template data in that marker, Android loses the binding context and card expressions render with unresolved placeholders or missing dynamic values.

Useful? React with 👍 / 👎.

Guard negative rating max before coerceIn

RenderRating derives max directly from card data and then calls value.toInt().coerceIn(0, max). If a malformed or model-generated card sends a negative max (for example -1), coerceIn throws IllegalArgumentException, which crashes chat rendering for that message instead of degrading gracefully. Clamp max to a non-negative minimum (or skip rendering) before this call.

Useful? React with 👍 / 👎.

Handle numeric column widths in ColumnSet

RenderColumnSet only reads column["width"] as a String, but valid card payloads often provide weighted widths as JSON numbers (for example "width": 2), which org.json parses as Number. In that case this code falls back to 1f, so intended layouts like 2:1 are rendered as equal-width columns. Parse both numeric and string width values before defaulting.

Useful? React with 👍 / 👎.

Avoid dropping additional adaptive-card blocks

parseAdaptiveCardMarkers uses find to capture only the first card block, but fallback text is produced by removing all card markers from the message. When a response contains multiple <!--adaptive-card-->...<!--/adaptive-card--> sections, only the first card is renderable and later cards are silently lost. This should either parse/render all matches or preserve unmatched card blocks in fallback text.

Useful? React with 👍 / 👎.

Apply parsed template data before rendering cards

The parser now extracts templateData from <!--adaptive-card-data-->...<!--/adaptive-card-data-->, but ChatMessageBody drops it and renders only parsed.card. As a result, cards that use templated fields (for example ${userName} in TextBlock.text) render unresolved placeholders on Android even when valid template data is present in the message payload.

Useful? React with 👍 / 👎.