Closes #42068.

This makes image-capability checks null-safe for custom/OpenAI-compatible providers where model.input may be undefined (replacing .includes("image") with optional chaining + safe defaults). Verified locally with pnpm vitest src/agents/model-scan.test.ts.

Greptile Summary

This PR adds null-safety guards (?. optional chaining and ?? [] defaults) across three files to prevent TypeError: Cannot read properties of undefined (reading 'includes') crashes when model.input is absent — a scenario that can occur with custom/OpenAI-compatible providers. The core fix in model-scan.ts is correct and directly addresses the reported crash.

• src/agents/model-scan.ts: The ensureImageInput function and the imageResult gate in scanOpenRouterModels are now safe when model.input is undefined. Note that within scanOpenRouterModels model.input is always populated by parseModality(entry.modality) (which always returns an array), so the gate guard is purely defensive for that call site — but it correctly protects callers of ensureImageInput from external code paths.
• src/agents/tools/image-tool.helpers.ts: The ?. added at line 80 is redundant because the preceding Array.isArray(m?.input) check already guarantees a defined array at that point. Harmless, but slightly noisy.
• src/commands/models/list.table.ts: ModelRow.input is typed as non-optional string; optional chaining on it is unnecessary per the type definition. If input can genuinely be undefined at runtime, the ModelRow type in list.types.ts should be updated to reflect that, rather than silently hiding it at the call site.

Confidence Score: 4/5

• Safe to merge — the fix is minimal, null-safety only, and directly resolves a real crash path with no behavioral regressions for well-formed inputs.
• The primary crash fix in model-scan.ts is correct and well-scoped. Two minor style issues exist: an optional chain on a non-optional string type in list.table.ts (which may mask a missing type update), and a redundant ?. in image-tool.helpers.ts after an Array.isArray guard. Neither introduces a bug. Score is 4 rather than 5 due to the unresolved type-accuracy question in ModelRow.
• src/commands/models/list.table.ts — check whether ModelRow.input type should be updated to string | undefined.

_{Last reviewed commit: f00654f}

FYI: addressed Greptile nits — removed redundant optional chaining after Array.isArray guards, and reverted optional chaining on ModelRow.input (non-optional by type). Core null-safety fix for model.input remains in model-scan.ts.

Thanks for the PR @andyliu!

After tracing the repro in #42068, I think this fix lands in the wrong code path. The crash reported there happens in convertMessages() inside @mariozechner/pi-ai when an openai-completions provider returns a model without an input field ,that path still calls model.input.includes("image") without a null guard after this change.

The fixes in model-scan.ts lines 328 and 475 harden the OpenRouter scan/probe path, where model.input is already constructed from parseModality(entry.modality) anyway, so the guard there is defensive but doesn't address the reported crash.

Would you be able to extend the fix to cover the convertMessages() path as well? Happy to re-review once that's in.

Good catch — you’re right that #42068 crashes inside @mariozechner/pi-ai’s openai-completions convertMessages().

I updated the PR to patch @mariozechner/[email protected] via pnpm patchedDependencies, switching model.input includes checks to optional chaining (model.input?.includes("image")) in the openai-completions provider (and a couple of similar call sites). This should cover the reported crash path. Happy to adjust if you’d prefer upstreaming this to pi-ai instead of carrying a patch.

Merged via squash.

• Prepared head SHA: d398fa0222b7045b549fd3592d469c079ca3efb6
• Merge commit: 10e6e274515a761b080e24ae243836de52172e3c

Thanks @andyliu!