fix: honor --to when agent is specified by TomDjerry · Pull Request #42009 · openclaw/openclaw

TomDjerry · 2026-03-10T09:46:17Z

Summary

fix openclaw agent --agent --to so --to derives an agent-scoped session key instead of collapsing to the agent main session
keep explicit --session-key precedence unchanged
add regression coverage for --agent + --to and the explicit session-key guardrail

Root Cause

esolveSessionKeyForRequest() eagerly fell back to the agent main-session alias when --agent was present, so custom --to values like cw_111 were ignored and all runs reused �gent::main.

Testing

fully tested
corepack pnpm exec vitest run src/commands/agent/session.test.ts src/commands/agent/session-store.test.ts
temporarily reverted the fix and reran src/commands/agent/session.test.ts to confirm the new regression test fails with �gent:mybot:main before restoring the fix

Transparency

AI-assisted: implemented with Codex

greptile-apps · 2026-03-10T09:49:08Z

Greptile Summary

This PR fixes resolveSessionKeyForRequest to correctly honor --to when --agent is also specified, instead of always collapsing to the agent's main-session key. The change refactors the session-key resolution into three clearly distinct paths: explicit --session-key (highest precedence), a new derivedToSessionKey for the --agent + --to case, and the existing agent-main-session fallback — and adds targeted regression tests for both new paths.

Fix is logically correct: All four input combinations (explicit key, --to-only, --agent-only, --agent + --to) now route to the expected session key, verified by tracing through toAgentStoreSessionKey.
storeAgentId derivation improved: Using normalizedAgentId directly as the primary source (instead of reversing it from an agent-main alias) is cleaner and avoids an unnecessary indirection.
Minor readability concern (lines 55–61 in session.ts): The ternary explicitSessionKey || opts.to?.trim() ? undefined : resolveExplicitAgentSessionKey(...) relies on implicit || / ?: operator precedence. The logic is correct, but wrapping the OR sub-expression in parentheses would make the intent immediately obvious to future readers.
Plan document committed: docs/plans/2026-03-10-agent-to-session-routing.md is an AI-assisted implementation plan including a "For Claude" directive. Depending on team conventions, this type of ephemeral planning artifact might be better kept out of the repository's permanent history.

Confidence Score: 4/5

Safe to merge — the bug fix is correct and well-tested with no regressions in existing behavior.
The core logic change is sound: all four input combinations route to the correct session key, the new derivedToSessionKey path properly delegates to toAgentStoreSessionKey for agent-scoped keys, and the original --to-only and --agent-only flows are preserved. The only deduction is for a minor readability risk from implicit operator precedence on lines 55–61, which is a style concern rather than a functional defect.
Pay light attention to src/commands/agent/session.ts lines 55–61 for the ternary precedence style note; no files have critical issues.

_{Last reviewed commit: 48d19c2}

Copilot

Pull request overview

This PR fixes a bug where openclaw agent --agent <id> --to <target> would ignore the --to flag and always collapse to the agent's main session key (agent:<id>:main). The root cause was that resolveSessionKeyForRequest() eagerly fell back to the agent main-session alias when --agent was present, before considering --to.

Changes:

Refactored session key resolution in resolveSessionKeyForRequest() to derive an agent-scoped session key from --to when both --agent and --to are provided, while preserving explicit --session-key precedence
Added two regression tests covering the --agent + --to derivation and the explicit --session-key guardrail
Added an implementation plan document

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
src/commands/agent/session.ts	Refactored session key resolution to properly derive agent-scoped keys from `--to` instead of always collapsing to the main session
src/commands/agent/session.test.ts	Added two regression tests for `--agent + --to` and explicit `--session-key` precedence
docs/plans/2026-03-10-agent-to-session-routing.md	New implementation plan document describing the fix approach

You can also share your feedback on Copilot code review. Take the survey.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 48d19c2907

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 388eb52283

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

openclaw-barnacle · 2026-04-27T04:33:27Z

This pull request has been automatically marked as stale due to inactivity.
Please add updates or it will be closed.

clawsweeper · 2026-04-27T05:13:25Z

Thanks for the context here. I swept through the related work, and this is now duplicate or superseded.

Close as superseded: this PR targets a real session-routing bug, but the remaining work is now tracked by the open canonical issue and maintainer-owned implementation path, while this branch is conflicting and would regress current session-key contracts if merged as-is.

Canonical path: Keep #73403 as the canonical implementation path and close this conflicting branch while preserving its discussion as context.

So I’m closing this here and keeping the remaining discussion on #73403 and #41483.

Review details

Best possible solution:

Keep #73403 as the canonical implementation path and close this conflicting branch while preserving its discussion as context.

Do we have a high-confidence way to reproduce the issue?

Yes. Source inspection on current main shows --agent can select the agent main session key before --to participates, so the reported collapse to agent:<id>:main is reproducible from the resolver path without running the CLI.

Is this the best way to solve the issue?

No. The branch points at a valid bug, but the better solution is the canonical channel-aware resolver fix in #73403 because it covers gateway and embedded paths while preserving current default-agent and session-id contracts.

Security review:

Security review needs attention: The diff has no dependency or workflow changes, but its direct-target session-key path could persist raw recipient identifiers and should not be merged in this superseded form.

[medium] Avoid raw direct-target session keys — src/agents/command/session.ts:176
The PR would turn arbitrary direct --to values into persisted agent session-key suffixes via toAgentStoreSessionKey, which can expose customer or phone identifiers and conflicts with the current direct-chat main-session contract.
Confidence: 0.74

What I checked:

Current-main source reproduction: Current main still computes explicitSessionKey from resolveExplicitAgentSessionKey before --to derivation, so an explicit agent can still collapse the request to agent:<id>:main; this is not implemented on main. (src/agents/command/session.ts:212, c93d6d8daa37)
PR head conflict with default-agent contract: The PR head falls omitted-agent store selection back to normalizeAgentId(undefined) and lacks current main's configured default-agent routing path, so it conflicts with the merged compatibility work. (src/agents/command/session.ts:164, 99e542299009)
Direct-target contract evidence: Current resolver tests and docs keep direct chats collapsed to the agent main session while preserving group/channel isolation; the PR branch routes raw direct/opaque --to values through toAgentStoreSessionKey instead. (src/config/sessions/session-key.test.ts:8, c93d6d8daa37)
Canonical open fix path: Open PR fix(agent): route explicit channel targets per recipient #73403 is the maintainer-labeled implementation for the same remaining --agent --channel --to routing problem and explicitly fixes [Bug]: --to flag ignored when using --agent with custom channel, all sessions map to main #41483. (765765a972cc)
Related issue routing: Open issue [Bug]: --to flag ignored when using --agent with custom channel, all sessions map to main #41483 reports the same --agent --channel --to collapse to agent:<id>:main and its current review routes the fix to fix(agent): route explicit channel targets per recipient #73403, not to this conflicting branch. (c93d6d8daa37)
Feature-history provenance: Merged PR fix(agent): preserve default-agent session routing compatibility #72414 changed the same resolver area to preserve configured-default-agent routing and legacy migration behavior that this branch must not overwrite. (src/agents/command/session.ts, 61a18e5596c8)

Likely related people:

vincentkoc: Authored the merged default-agent session-routing compatibility work and the open canonical PR that fixes the same remaining channel-target routing problem. (role: recent resolver contributor and canonical follow-up owner; confidence: high; commits: 61a18e5596c8, 765765a972cc; files: src/agents/command/session.ts, src/commands/agent-via-gateway.ts, src/commands/agent/session.test.ts)
steipete: Recent path history shows repeated central work on session-key normalization and explicit session-id/session routing behavior adjacent to the direct/group key contract. (role: session-key normalization contributor; confidence: medium; commits: ad7399b6e605, cf1c2cc208ff, cd36ff748369; files: src/config/sessions/session-key.ts, src/config/sessions/session-key.test.ts, src/agents/command/session.ts)
frankekn: Authored a recent merged fix in the same resolver family covering agent-scoped session-id routing and gateway validation behavior. (role: adjacent session-id resolver contributor; confidence: medium; commits: 934dd5b3a738; files: src/agents/command/session.ts, src/commands/agent/session.test.ts, src/gateway/server-methods/agent.ts)

Codex review notes: model gpt-5.5, reasoning high; reviewed against c93d6d8daa37.

TomDjerry · 2026-04-27T06:28:04Z

Rebased and updated this PR against current main.

Ported the routing fix to src/agents/command/session.ts and kept src/commands/agent/session.ts as the re-export. The regression coverage in src/commands/agent/session.test.ts now covers --agent + --to, explicit --session-key precedence, blank --session-key, and qualified --to rewriting.

Verification run:

vitest run --config test/vitest/vitest.commands.config.ts src/commands/agent/session.test.ts --reporter=dot
1 passed, 15 tests passed

Copilot AI review requested due to automatic review settings March 10, 2026 09:46

openclaw-barnacle Bot added docs Improvements or additions to documentation commands Command implementations size: S labels Mar 10, 2026

Copilot started reviewing on behalf of TomDjerry March 10, 2026 09:46 View session

greptile-apps Bot reviewed Mar 10, 2026

View reviewed changes

Comment thread src/commands/agent/session.ts Outdated

Copilot AI reviewed Mar 10, 2026

View reviewed changes

Comment thread docs/plans/2026-03-10-agent-to-session-routing.md Outdated

Comment thread docs/plans/2026-03-10-agent-to-session-routing.md Outdated

chatgpt-codex-connector Bot reviewed Mar 10, 2026

View reviewed changes

Comment thread src/commands/agent/session.ts Outdated

Comment thread src/commands/agent/session.ts Outdated

openclaw-barnacle Bot removed the docs Improvements or additions to documentation label Mar 10, 2026

chatgpt-codex-connector Bot reviewed Mar 10, 2026

View reviewed changes

Comment thread src/commands/agent/session.ts Outdated

TomDjerry force-pushed the fix-agent-to-session-routing branch from 11683f0 to 8ed941b Compare March 11, 2026 05:27

vincentkoc mentioned this pull request Apr 26, 2026

fix(agent): preserve default-agent session routing compatibility #72414

Merged

openclaw-barnacle Bot added the stale Marked as stale due to inactivity label Apr 27, 2026

solar added 2 commits April 27, 2026 14:15

fix: honor --to when agent is specified

7069a66

chore: drop plan doc and format session fix

38a6d25

TomDjerry force-pushed the fix-agent-to-session-routing branch from 8ed941b to 09f09a2 Compare April 27, 2026 06:27

openclaw-barnacle Bot added the agents Agent runtime and tooling label Apr 27, 2026

fix: tighten agent session key resolution

99e5422

TomDjerry force-pushed the fix-agent-to-session-routing branch from 09f09a2 to 99e5422 Compare April 27, 2026 06:35

openclaw-barnacle Bot removed the stale Marked as stale due to inactivity label Apr 28, 2026

clawsweeper Bot mentioned this pull request Apr 28, 2026

[Bug] v2026.3.11: CLI 'openclaw agent --channel discord --to' routes to agent:*:main instead of live channel session #44448

Closed

clawsweeper Bot added the P2 Normal backlog priority with limited blast radius. label May 16, 2026

openclaw-barnacle Bot added the triage: needs-real-behavior-proof Candidate: external PR needs after-fix proof from a real setup. label May 16, 2026

clawsweeper Bot added impact:session-state Session, memory, transcript, context, or agent state can drift or corrupt. impact:security Security boundary, credential, authz, sandbox, or sensitive-data risk. labels May 17, 2026

clawsweeper Bot closed this May 17, 2026

This was referenced Jun 16, 2026

[Bug]: --to flag ignored when using --agent with custom channel, all sessions map to main #41483

Closed

fix(agent): route explicit channel targets per recipient #73403

Closed

coderabbitai Bot mentioned this pull request Jul 17, 2026

revert(docs): 回退 Claude Code 与 OpenClaw 模板文档调整 aliyun-fc/fc-docs#79

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: honor --to when agent is specified#42009

fix: honor --to when agent is specified#42009
TomDjerry wants to merge 3 commits into
openclaw:mainfrom
TomDjerry:fix-agent-to-session-routing

TomDjerry commented Mar 10, 2026

Uh oh!

greptile-apps Bot commented Mar 10, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

openclaw-barnacle Bot commented Apr 27, 2026

Uh oh!

clawsweeper Bot commented Apr 27, 2026 •

edited

Loading

Uh oh!

TomDjerry commented Apr 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

TomDjerry commented Mar 10, 2026

Summary

Root Cause

Testing

Transparency

Uh oh!

greptile-apps Bot commented Mar 10, 2026

Greptile Summary

Confidence Score: 4/5

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

openclaw-barnacle Bot commented Apr 27, 2026

Uh oh!

clawsweeper Bot commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TomDjerry commented Apr 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

clawsweeper Bot commented Apr 27, 2026 •

edited

Loading