fix(telegram): prevent duplicate messages when preview edit times out by hougangdev · Pull Request #41662 · openclaw/openclaw

hougangdev · 2026-03-10T02:54:55Z

Summary

Fixes the Telegram duplicate message bug that occurs when streaming preview edits time out — most commonly triggered by slow provider proxy chains like OpenRouter (via Cloudflare AI Gateway).

Root cause

When editMessageTelegram throws a post-connect network error (timeout, connection reset), the edit has likely already been processed by Telegram's server. However, the lane delivery fallback chain in tryEditPreviewMessage (lane-delivery-text-deliverer.ts:217-220) treated all edit errors the same — returning false and falling through to sendPayload, which sends a second, duplicate message.

Why OpenRouter triggers this

OpenRouter (especially routed through Cloudflare AI Gateway) adds significant latency to the LLM response path. While the LLM response itself isn't the issue, the added network hops and proxy overhead make the Telegram API calls themselves more likely to timeout. The sequence:

Streaming preview message is created via sendMessage
LLM streams tokens, preview is updated via editMessageText
Final delivery attempts one last editMessageText to finalize the preview
The edit reaches Telegram and succeeds server-side
But the HTTP response times out on the client (slow proxy, network jitter)
editMessageTelegram retries (default TELEGRAM_RETRY_RE matches "timeout")
Retries exhaust → error propagates to tryEditPreviewMessage
treatEditFailureAsDelivered is false for normal previews → returns false
Fallback sendPayload fires → user sees two identical messages

The same bug can occur without OpenRouter on any high-latency or unstable connection to Telegram's API.

Fix

The editPreview callback in bot-message-dispatch.ts now classifies errors before propagating:

Error type	Example	Action
Pre-connect (`isSafeToRetrySendError`)	`ECONNREFUSED`, `ENOTFOUND`	Re-throw → fallback sends new message (safe — edit never reached Telegram)
Post-connect network	`timeout`, `reset`, `fetch failed`	Swallow → treat as delivered (edit likely landed, avoids duplicate)
API error	`400`, `500`	Re-throw → fallback sends new message (Telegram rejected the edit)

Relationship to #40883

#40883 addresses the same symptom via a broader structural refactor (~500 lines across 7 files): it removes the archivedAnswerPreviews system entirely, coalesces answer segments into a single preview, and flips treatEditFailureAsDelivered to true for all final edits.

This PR is a surgical alternative (3 files, ~135 lines) that fixes the root cause at the network-error classification layer — the editPreview callback distinguishes pre-connect errors (safe to retry/fallback) from post-connect errors (edit likely landed, swallow to avoid duplicate). Both PRs prevent the duplicate; this one is narrower in scope and preserves the existing lane delivery architecture.

Related issues and PRs

Fixes Telegram streaming=partial causes duplicate messages on edit failure #40746 — Telegram streaming=partial causes duplicate messages on edit failure
Overlaps with Fix Telegram streamed duplicate reply bubbles #40883 — Fix Telegram streamed duplicate reply bubbles (broader refactor, same symptom)
Related to Telegram streaming "partial" creates duplicate messages due to generation counter race #39795 — Telegram streaming "partial" creates duplicate messages due to generation counter race
Related to fix(telegram): delete orphaned preview message after fallback send #39455 — fix(telegram): delete orphaned preview message after fallback send
Related to [Bug]: Telegram DM can re-show a stale draft preview after the final reply is already delivered #40750 — Telegram DM can re-show a stale draft preview after the final reply is already delivered
Related to [Bug]: Telegram: duplicate messages sent after stale-socket health-monitor restart #40685 — Telegram: duplicate messages sent after stale-socket health-monitor restart
Related to [Bug]: Telegram streaming preview duplication with Anthropic-compatible providers (MiniMax) #18859 — Telegram streaming preview duplication with Anthropic-compatible providers (MiniMax)
Related to [Bug]: Telegram Duplicate Messages with Partial Streaming #33453 — Telegram Duplicate Messages with Partial Streaming
Related to fix(telegram): skip redundant final edit in partial streaming mode #19479 — fix(telegram): skip redundant final edit in partial streaming mode

Test plan

pnpm vitest run src/telegram/lane-delivery.test.ts — 16 tests pass
pnpm vitest run src/telegram/bot-message-dispatch.test.ts — 61 tests pass (2 new tests for the fix)
pnpm tsgo — no type errors
Manual: send messages through Telegram with a slow provider proxy and confirm no duplicates

🤖 Generated with Claude Code

greptile-apps · 2026-03-10T03:00:28Z

Greptile Summary

This PR fixes a duplicate-message bug in the Telegram delivery pipeline that could occur when a slow proxy chain (e.g. OpenRouter via Cloudflare AI Gateway) caused editMessageText to time out on the client side even after Telegram had already processed the edit. Previously, all errors from editPreview propagated to the lane-delivery fallback chain, which then called sendPayload — producing a second visible message. The fix wraps the editMessageTelegram call in bot-message-dispatch.ts with a catch block that distinguishes three categories of error:

Pre-connect (ECONNREFUSED, ENOTFOUND, etc. via isSafeToRetrySendError) → re-thrown; fallback is safe because the edit never reached Telegram.
Post-connect network (timeout, reset, socket, etc. via inline regex) → swallowed; fallback is suppressed because the edit likely landed.
API errors (400/500 etc.) → re-thrown; fallback is safe because Telegram explicitly rejected the edit.

The change is well-reasoned and the two new integration tests in bot-message-dispatch.test.ts directly verify both code paths. The additional tests in lane-delivery.test.ts confirm the downstream fallback still operates correctly when genuine API errors do reach that layer.

Key points to review:

The inline /timeout|timed out|reset|closed|network|fetch failed|socket/i regex re-implements a subset of the error-classification logic already centralised in isRecoverableTelegramNetworkError in network-errors.ts. Notably, the regex only inspects err.message (not the nested cause chain), and misses error-name–based matches (AbortError, ConnectTimeoutError, etc.) already handled by the centralised function — though in practice grammY wraps these so "network" appears in the top-level message.
The pre-connect test asserts only expect(deliverReplies).toHaveBeenCalled() without verifying the payload content, making it slightly less specific than the timeout test which explicitly checks that the "Final answer" text was not sent via deliverReplies.

Confidence Score: 4/5

Safe to merge with one style suggestion — the fix is correct for the described use case and all new tests pass.
The root cause analysis and fix are sound, and the new tests directly verify both the "swallow timeout" and "re-throw pre-connect" paths. The main concern is that the inline regex duplicates network-error classification logic from network-errors.ts and only inspects err.message rather than the full error graph, which could theoretically miss some post-connect errors on non-grammY error shapes and allow a duplicate to slip through. In practice the risk is low because grammY always includes "network" in its HttpError wrapper messages, but using isRecoverableTelegramNetworkError would make the classification more robust and maintainable.
The catch block in src/telegram/bot-message-dispatch.ts (lines 499–507) deserves attention for the regex-vs-centralised-function discussion.

_{Last reviewed commit: 8ba0127}

src/telegram/bot-message-dispatch.ts

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8ba0127c23

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/telegram/bot-message-dispatch.ts

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f946659d58

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/telegram/lane-delivery-text-deliverer.ts

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e2048676fe

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/telegram/lane-delivery-text-deliverer.ts

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: db6b3fcfae

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/telegram/lane-delivery-text-deliverer.ts

obviyus · 2026-03-10T03:44:24Z

Thanks for digging into this and isolating the duplicate path.

I pushed a small follow-up on your branch that keeps the narrow fix shape, but moves final edit classification into one place: pre-connect failures now fall back to a real send, ambiguous post-connect failures keep the existing preview, and message to edit not found now keeps the preview instead of sending a likely duplicate.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e9f132acaf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

src/telegram/lane-delivery-text-deliverer.ts

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8537211a1a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

src/telegram/lane-delivery-text-deliverer.ts

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b1b607e699

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

src/telegram/lane-delivery-text-deliverer.ts

…nal edit failures as delivered

obviyus · 2026-03-10T04:47:45Z

Merged via squash.

Prepared head SHA: 2780e62d070d7b4c4d7447e966ca172e33e44ad4
Merge commit: da4fec664121b8ca443a3d72d19a6a1c9200204f

Thanks @hougangdev!

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2780e62d07

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-03-10T04:53:31Z

src/telegram/lane-delivery-text-deliverer.ts

        return "preview-finalized";
      }
+      if (finalized === "retained") {
+        params.retainPreviewOnCleanupByLane.answer = true;


Clear stale retain flag before fallback final sends

Setting retainPreviewOnCleanupByLane.answer = true here makes the retain flag sticky across later final deliveries in the same dispatch. If a subsequent answer final cannot edit the active preview and falls back to sendPayload (for example a pre-connect edit failure), deliverLaneText never resets this flag, so the cleanup path in dispatchTelegramMessage (shouldClear check) skips stream.clear() and leaves the active partial preview visible next to the fallback-sent final message. This reintroduces duplicate/stale bubbles in multi-message streams.

Useful? React with 👍 / 👎.

@obviyus

…openclaw#41662) Merged via squash. Prepared head SHA: 2780e62 Co-authored-by: hougangdev <[email protected]> Co-authored-by: obviyus <[email protected]> Reviewed-by: @obviyus

@obviyus

…openclaw#41662) Merged via squash. Prepared head SHA: 2780e62 Co-authored-by: hougangdev <[email protected]> Co-authored-by: obviyus <[email protected]> Reviewed-by: @obviyus

@obviyus

…openclaw#41662) Merged via squash. Prepared head SHA: 2780e62 Co-authored-by: hougangdev <[email protected]> Co-authored-by: obviyus <[email protected]> Reviewed-by: @obviyus

@obviyus

…openclaw#41662) Merged via squash. Prepared head SHA: 2780e62 Co-authored-by: hougangdev <[email protected]> Co-authored-by: obviyus <[email protected]> Reviewed-by: @obviyus

@obviyus

…openclaw#41662) Merged via squash. Prepared head SHA: 2780e62 Co-authored-by: hougangdev <[email protected]> Co-authored-by: obviyus <[email protected]> Reviewed-by: @obviyus

@obviyus

…openclaw#41662) Merged via squash. Prepared head SHA: 2780e62 Co-authored-by: hougangdev <[email protected]> Co-authored-by: obviyus <[email protected]> Reviewed-by: @obviyus

@obviyus

…openclaw#41662) Merged via squash. Prepared head SHA: 2780e62 Co-authored-by: hougangdev <[email protected]> Co-authored-by: obviyus <[email protected]> Reviewed-by: @obviyus

@obviyus

…openclaw#41662) Merged via squash. Prepared head SHA: 2780e62 Co-authored-by: hougangdev <[email protected]> Co-authored-by: obviyus <[email protected]> Reviewed-by: @obviyus

@obviyus

…openclaw#41662) Merged via squash. Prepared head SHA: 2780e62 Co-authored-by: hougangdev <[email protected]> Co-authored-by: obviyus <[email protected]> Reviewed-by: @obviyus

@obviyus

…openclaw#41662) Merged via squash. Prepared head SHA: 2780e62 Co-authored-by: hougangdev <[email protected]> Co-authored-by: obviyus <[email protected]> Reviewed-by: @obviyus

openclaw-barnacle bot added channel: telegram Channel integration: telegram size: S labels Mar 10, 2026

greptile-apps bot reviewed Mar 10, 2026

View reviewed changes

src/telegram/bot-message-dispatch.ts Outdated Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Mar 10, 2026

View reviewed changes

src/telegram/bot-message-dispatch.ts Outdated Show resolved Hide resolved

openclaw-barnacle bot added size: M and removed size: S labels Mar 10, 2026

chatgpt-codex-connector bot reviewed Mar 10, 2026

View reviewed changes

src/telegram/lane-delivery-text-deliverer.ts Outdated Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Mar 10, 2026

View reviewed changes

src/telegram/lane-delivery-text-deliverer.ts Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Mar 10, 2026

View reviewed changes

src/telegram/lane-delivery-text-deliverer.ts Outdated Show resolved Hide resolved

obviyus self-assigned this Mar 10, 2026

chatgpt-codex-connector bot reviewed Mar 10, 2026

View reviewed changes

src/telegram/lane-delivery-text-deliverer.ts Outdated Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Mar 10, 2026

View reviewed changes

src/telegram/lane-delivery-text-deliverer.ts Show resolved Hide resolved

kesor mentioned this pull request Mar 10, 2026

Minimax M2.5 experience is weird anomalyco/opencode#15092

Open

chatgpt-codex-connector bot reviewed Mar 10, 2026

View reviewed changes

src/telegram/lane-delivery-text-deliverer.ts Outdated Show resolved Hide resolved

openclaw-barnacle bot added size: L and removed size: M labels Mar 10, 2026

obviyus force-pushed the fix/telegram-duplicate-message-on-edit-timeout branch from cd036b3 to 9b17c64 Compare March 10, 2026 04:45

hougangdev and others added 7 commits March 10, 2026 10:15

fix(telegram): prevent duplicate messages when preview edit times out

f158fcc

fix(telegram): use isRecoverableTelegramNetworkError and treat all fi…

7b25898

…nal edit failures as delivered

fix(telegram): unify preview final edit outcomes

38d5183

fix(telegram): fall back when current preview is missing

95bf8ed

fix(telegram): preserve retained archived previews

b8134d0

refactor(telegram): split preview lifecycle from cleanup

507dab9

fix(telegram): harden final preview delivery

2780e62

obviyus force-pushed the fix/telegram-duplicate-message-on-edit-timeout branch from 9b17c64 to 2780e62 Compare March 10, 2026 04:46

obviyus merged commit da4fec6 into openclaw:main Mar 10, 2026
10 checks passed

chatgpt-codex-connector bot reviewed Mar 10, 2026

View reviewed changes

obviyus mentioned this pull request Mar 10, 2026

fix(telegram): clear stale retain before transient final fallback #41763

Merged

20 tasks

github-actions bot mentioned this pull request Mar 10, 2026

📡 Upstream Digest — 2026-03-10 06:38 UTC curtismercier/openclaw-mods#226

Open

This was referenced Mar 10, 2026

fix(telegram): prevent duplicate messages with slow LLM providers #41927

Closed

fix(telegram): prevent duplicate messages with slow LLM providers #41932

Merged

kingrubic mentioned this pull request Mar 10, 2026

[Bug]: Slack: Streaming messages show incomplete content #42200

Open

alexey-pelykh mentioned this pull request Mar 10, 2026

Cherry-pick: Telegram duplicate fix, memory flush changelog, Swift CI, PR revi remoteclaw/remoteclaw#930

Closed

4 tasks

github-actions bot mentioned this pull request Mar 12, 2026

上游更新: v2026.3.11 — 14 P0 + 32 P1 待合并 jiulingyun/openclaw-cn#499

Open

Uh oh!

Conversation

hougangdev commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Root cause

Why OpenRouter triggers this

Fix

Relationship to #40883

Related issues and PRs

Test plan

Uh oh!

greptile-apps bot commented Mar 10, 2026

Greptile Summary

Confidence Score: 4/5

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

obviyus commented Mar 10, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

obviyus commented Mar 10, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

hougangdev commented Mar 10, 2026 •

edited

Loading