Skip to content

fix: format daemon lifecycle test#40450

Closed
jalehman wants to merge 0 commit intomainfrom
fix/pr-37876-format-followup
Closed

fix: format daemon lifecycle test#40450
jalehman wants to merge 0 commit intomainfrom
fix/pr-37876-format-followup

Conversation

@jalehman
Copy link
Copy Markdown
Contributor

@jalehman jalehman commented Mar 9, 2026

What

This PR fixes the formatting regression introduced in #37876 by applying the expected oxfmt layout in src/cli/daemon-cli/lifecycle.test.ts.

Why

The merged PR left main with a failing check job, which can block other PRs that run the shared formatter and lint gate.

Changes

  • Reformat probeGateway test declaration
  • Restore pnpm check pass on main

Testing

  • pnpm check
  • Expected: passes locally, including format:check

@openclaw-barnacle openclaw-barnacle bot added cli CLI command changes size: XS maintainer Maintainer-authored PR labels Mar 9, 2026
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Mar 9, 2026

Greptile Summary

This PR is a single-file formatting fix that restores the oxfmt-compliant layout for the probeGateway mock declaration in src/cli/daemon-cli/lifecycle.test.ts, which was left out-of-format by PR #37876.

  • Reformats const probeGateway = vi.fn<…>() from the split-assignment style to the inline generic-open-bracket style required by oxfmt.
  • No logic, types, or runtime behaviour are changed.
  • Unblocks the shared check (format + lint) gate on main.

Confidence Score: 5/5

  • This PR is safe to merge — it is a pure whitespace/formatting change with no behavioural impact.
  • The entire diff is a reflow of one variable declaration to satisfy the project formatter. There is no change to types, logic, or test assertions.
  • No files require special attention.

Last reviewed commit: 477790d

@jlcbk
Copy link
Copy Markdown

jlcbk commented Mar 9, 2026

Windows shard 6/6 is currently failing on src/secrets/runtime.test.ts (secrets runtime snapshot) with:

SecretProviderResolutionError: secrets.providers.default.path ACL verification unavailable on Windows ... Set allowInsecurePath=true ...

This matches the CI log in run https://github.com/openclaw/openclaw/actions/runs/22835208721 .

Note: upstream/main now includes changes that skip these ACL-dependent runtime snapshot tests on Windows (and adds allowInsecurePath for the temp secrets file path in this harness). Rebasing this PR onto latest main may resolve the Windows failure.

@jalehman jalehman closed this Mar 9, 2026
@jalehman jalehman force-pushed the fix/pr-37876-format-followup branch from 477790d to 51bae75 Compare March 9, 2026 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cli CLI command changes maintainer Maintainer-authored PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants