Self-review: i kept discovered --all rows as the base list and only filled the missing catalog-backed rows on top. that keeps the old --all behavior when loadModelCatalog() returns [], and it avoids building fake catalog-only runtime models just for display.

Greptile Summary

This PR fixes a gap in openclaw models list --all where synthetic/forward-compat catalog models (e.g. openai-codex/gpt-5.4) were omitted because the command only iterated runtime-discovered registry rows. The fix adds a supplement pass: after emitting all discovered rows, it calls loadModelCatalog and uses resolveModelWithRegistry to hydrate any catalog entries not already present, correctly applying auth-based availability fallback for models that aren't surfaced by the runtime's getAvailable() call.

Key implementation details:

• The seenKeys / discoveredKeys distinction cleanly separates "already emitted" from "known to the runtime", allowing allowProviderAvailabilityFallback to be set precisely for truly synthetic rows.
• The if (modelRegistry) guard means the supplement pass is skipped (safely) when registry loading fails.
• Two new focused tests cover the catalog-present and empty-catalog paths with appropriate test isolation.
• The fix preserves existing behavior and adds no breaking changes while addressing the reported issue with GPT-5.4 visibility.

Confidence Score: 5/5

• Safe to merge. Core bug fix is correct with clean deduplication logic.
• The PR correctly implements the bug fix for catalog model visibility in models list --all. The supplement-only approach preserves existing behavior, uses seenKeys for precise deduplication, and properly applies auth availability fallback only for truly synthetic rows. Test coverage is focused on the key scenarios (catalog-present and empty-catalog paths). No functional issues identified.
• No files require special attention.

_{Last reviewed commit: 5cb8f81}

small status note: i checked the current red CI, and on my read the failures are outside this diff.

• check, build-artifacts, and install-smoke are failing on current base TS errors in src/agents/provider-capabilities.ts and src/agents/pi-embedded-runner-extraparams.test.ts
• secrets is failing on .secrets.baseline drift and unrelated test fixtures

i re-ran the focused paths for this change locally and they were green:

• pnpm exec vitest run src/commands/models/list.list-command.forward-compat.test.ts src/commands/models.list.auth-sync.test.ts
• pnpm exec vitest run --config vitest.e2e.config.ts src/commands/models.list.e2e.test.ts
• pnpm build

happy to refresh once base CI is green again if needed.

synced latest main into this branch.

my fix is still the same: keep discovered --all rows as the base list, then fill only the missing catalog-backed synthetic rows on top.

i also refreshed the focused list tests after upstream config/listing changes landed on main. local checks i re-ran after the sync:

• pnpm exec vitest run src/commands/models/list.list-command.forward-compat.test.ts src/commands/models.list.auth-sync.test.ts
• pnpm exec vitest run --config vitest.e2e.config.ts src/commands/models.list.e2e.test.ts
• pnpm build

Landed via temp rebase onto main.

• Gate: pnpm exec vitest run src/commands/models/list.list-command.forward-compat.test.ts src/commands/models.list.auth-sync.test.ts; pnpm exec vitest run --config vitest.e2e.config.ts src/commands/models.list.e2e.test.ts; pnpm build; pnpm check
• Land commit: ee38359
• Merge commit: $(gh pr view 40160 --repo openclaw/openclaw --json mergeCommit --jq '.mergeCommit.oid')

Thanks @dorukardahan!

Thanks Peter, i appreciate you landing this.

Also good to see you back around GitHub. i had not seen you for a while. glad you are back.