config: clarify tools.profile help text#39963
Conversation
Greptile SummaryThis PR updates two help text strings in
Confidence Score: 5/5
Last reviewed commit: fce2f80 |
|
This pull request has been automatically marked as stale due to inactivity. |
|
Thanks for the context here. I swept through the related work, and this is now duplicate or superseded. Keep this PR open: the schema-help wording is still a unique generated-config-help change on top of the merged docs work, but it is not merge-ready because the config docs baseline hash is not updated and external real behavior proof is still missing. Canonical path: Close this stale PR. The latest review rated it F, the branch still lacks merge-ready proof, and there has been no human follow-up after the durable review. So I’m closing this here because the remaining work is already tracked in the canonical issue. Review detailsBest possible solution: Close this stale PR. The latest review rated it F, the branch still lacks merge-ready proof, and there has been no human follow-up after the durable review. Do we have a high-confidence way to reproduce the issue? Yes for the review finding: source inspection shows Is this the best way to solve the issue? No, not as-is. Security review: Security review cleared: The diff only changes config help strings and does not touch dependencies, CI, secrets, permissions, or code-execution paths. What I checked:
Likely related people:
Codex review notes: model gpt-5.5, reasoning high; reviewed against d7a078f1962b. |
|
ClawSweeper PR egg 🎁 Pass real behavior proof to wake the egg and unlock a hatchable treat. Where did the egg go?
|
|
ClawSweeper applied the proposed close for this PR.
|
Summary
tools.profileagents.list[].tools.profilemessagingis intentionally narrow andfullprovides the broadest command/control surfaceWhy
A valid
tools.profilesetting can still be surprising in practice. In messaging-first setups,tools.profile: "messaging"can make an assistant feel unexpectedly limited even though the behavior is intentional. This change makes that tradeoff clearer directly in config help text, where users encounter it during setup.Changes
tools.profilehelp text to describe its practical effect on the default tool surfacemessagingvsfullexplicitlyagents.list[].tools.profilehelp text with a concrete override exampleWhat did not change
Change Type
Scope
Linked Issue/PR
User-visible / Behavior Changes
Users reading generated config help text will get clearer guidance about when
messagingis intentionally restrictive and whenfullis a better fit. No runtime behavior changes.Security Impact
No)No)No)No)No)Yes, explain risk + mitigation:Repro + Verification
Environment
tools.profile,agents.list[].tools.profileSteps
src/config/schema.help.tstools.profileandagents.list[].tools.profileExpected
Actual
messagingandfulldirectly and gives a clearer per-agent override exampleEvidence
Human Verification
Review Conversations
Compatibility / Migration
Yes)No)No)Failure Recovery (if this breaks)
src/config/schema.help.tsRisks and Mitigations