docs: clarify bot review conversation ownership by Takhoffman · Pull Request #39942 · openclaw/openclaw

Takhoffman · 2026-03-08T14:30:13Z

Summary

Describe the problem and fix in 2–5 bullets:

Problem: Contributors and LLM coding agents do not have an explicit repo policy telling them to resolve bot review conversations they have already addressed.
Why it matters: Maintainers end up spending time and tokens cleaning up already-resolved bot conversations.
What changed: Added contributor-facing guidance to the PR template, CONTRIBUTING.md, and AGENTS.md that makes authors responsible for resolving addressed bot review conversations.
What did NOT change (scope boundary): No CI, automation, merge gates, or code behavior changed.

Change Type (select all)

Scope (select all touched areas)

Linked Issue/PR

Closes: None
Related: None

User-visible / Behavior Changes

Contributor expectations are now explicit: authors should resolve bot review conversations they have addressed, and leave conversations open only when reviewer or maintainer judgment is still needed.

Security Impact (required)

New permissions/capabilities? (No)
Secrets/tokens handling changed? (No)
New/changed network calls? (No)
Command/tool execution surface changed? (No)
Data access scope changed? (No)
If any Yes, explain risk + mitigation:

Repro + Verification

Environment

OS: macOS
Runtime/container: N/A (docs-only)
Model/provider: N/A
Integration/channel (if any): GitHub PR workflow
Relevant config (redacted): N/A

Steps

Open the PR template and contributor/agent guidance.
Confirm the new policy uses GitHub-accurate review conversations terminology.
Confirm the policy consistently assigns addressed bot conversations to PR authors.

Expected

Contributors and LLM coding agents see the same policy in the PR template, CONTRIBUTING.md, and AGENTS.md.

Actual

The three surfaces now consistently instruct authors to resolve addressed bot review conversations themselves.

Evidence

Attach at least one:

Trace/log snippets
Failing test/log before + passing after
Screenshot/recording
Perf numbers (if relevant)

Verification evidence: git diff and targeted rg checks were used to confirm the wording and remove leftover review thread terminology.

Human Verification (required)

What you personally verified (not just CI), and how:

Verified scenarios: Read the PR template, CONTRIBUTING.md, and AGENTS.md after the edit and confirmed the policy text matches across all three.
Edge cases checked: Verified the wording uses review conversations rather than the less accurate review threads terminology.
What you did not verify: No GitHub UI automation or enforcement behavior was tested because this change is docs/template-only.

Compatibility / Migration

Backward compatible? (Yes)
Config/env changes? (No)
Migration needed? (No)
If yes, exact upgrade steps:

Failure Recovery (if this breaks)

How to disable/revert this change quickly: Revert this PR.
Files/config to restore: .github/pull_request_template.md, CONTRIBUTING.md, AGENTS.md
Known bad symptoms reviewers should watch for: Contributor guidance feels too strict or confusing for docs-only and bot-only review feedback.

Risks and Mitigations

List only real risks for this PR. Add/remove entries as needed. If none, write None.

Risk: Contributors may read the policy as a hard merge gate rather than a workflow expectation.
- Mitigation: The wording stays in docs/template guidance and does not add automation or blocking checks.

greptile-apps · 2026-03-08T14:31:48Z

Greptile Summary

This is a docs-only PR that adds consistent contributor guidance across three surfaces (.github/pull_request_template.md, CONTRIBUTING.md, and AGENTS.md) making PR authors — including LLM coding agents — responsible for resolving bot review conversations they have already addressed.

Key changes:

.github/pull_request_template.md: New "Review Conversations" section with two author-accountability checkboxes.
CONTRIBUTING.md: New "Review Conversations Are Author-Owned" section, a matching "Before You PR" bullet, and an extra checklist item + sentence in the AI-assisted PRs section.
AGENTS.md: A single new bullet in the top-level guidelines list directing agents to self-resolve addressed bot conversations.

One minor issue found:

.github/pull_request_template.md line 95 uses the phrase "bot comment" rather than the established "bot review conversations" terminology. The PR's own verification criteria explicitly checks for consistent review conversations usage, so this one slip is worth fixing for full consistency.

No automation, CI, or code behavior was changed.

Confidence Score: 5/5

Safe to merge — docs-only change with no code, CI, or automation impact.
All three files contain only prose additions. The guidance is clear, internally consistent (modulo one minor wording slip in the PR template), and does not introduce any breaking changes or new enforcement mechanisms.
.github/pull_request_template.md line 95 has a minor terminology inconsistency ("bot comment" vs "bot review conversations") worth fixing before merge.

_{Last reviewed commit: 17e6c50}

.github/pull_request_template.md

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

@danodoesdesign

* main: (70 commits) Refactor release hardening follow-ups (openclaw#39959) docs: clarify bot review conversation ownership (openclaw#39942) fix: harden talk silence timeout parsing (openclaw#39607) (thanks @danodoesdesign) talk: add configurable silence timeout transcript-policy: use named Set for anthropic signature-excluded providers transcript-policy: don't preserve thinking signatures for kimi-coding (openclaw#39798) fix: land mac universal release defaults (openclaw#33891) (thanks @cgdusek) Docs: clarify notarization handoff in mac release flow Docs: mark basic mac dist example as non-notarized Docs: clarify release build arch defaults for mac packaging macOS: default release app builds to universal binaries fix(issue-39839): address tool-call extra params parsing for kimi anthropic-messages docs: use alphabetical provider ordering fix: follow up openclaw#39321 and openclaw#38445 landings docs: note /landpr merge process fix: land Brave llm-context gaps (openclaw#33383) (thanks @thirumaleshp) feat: add Brave Search LLM Context API mode for web_search fix(feishu): restore @larksuiteoapi/node-sdk in root dependencies refactor: tighten codex inline api fallback follow-up macOS: set speech recognition taskHint for Talk Mode mic capture ...

* docs: clarify bot review conversations

* docs: clarify bot review conversations (cherry picked from commit 2755880)

* docs: clarify bot review conversations (cherry picked from commit 2755880) Co-authored-by: Tak Hoffman <[email protected]>

* docs: clarify bot review conversations

docs: clarify bot review conversations

17e6c50

openclaw-barnacle bot added size: XS maintainer Maintainer-authored PR labels Mar 8, 2026

greptile-apps bot reviewed Mar 8, 2026

View reviewed changes

.github/pull_request_template.md Outdated Show resolved Hide resolved

Apply suggestion from @greptile-apps[bot]

921e623

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

Takhoffman merged commit 2755880 into main Mar 8, 2026
29 of 30 checks passed

Takhoffman deleted the docs-review-thread-ownership branch March 8, 2026 14:39

github-actions bot mentioned this pull request Mar 8, 2026

📡 Upstream Digest — 2026-03-08 16:18 UTC curtismercier/openclaw-mods#213

Open

Saitop pushed a commit to NomiciAI/openclaw that referenced this pull request Mar 8, 2026

docs: clarify bot review conversation ownership (openclaw#39942)

8ec88ee

* docs: clarify bot review conversations

GordonSH-oss pushed a commit to GordonSH-oss/openclaw that referenced this pull request Mar 9, 2026

docs: clarify bot review conversation ownership (openclaw#39942)

9e78b90

* docs: clarify bot review conversations

hugs42 pushed a commit to hugs42/openclaw that referenced this pull request Mar 10, 2026

docs: clarify bot review conversation ownership (openclaw#39942)

00ab6ce

* docs: clarify bot review conversations

jenawant pushed a commit to jenawant/openclaw that referenced this pull request Mar 10, 2026

docs: clarify bot review conversation ownership (openclaw#39942)

48d0af3

* docs: clarify bot review conversations

alexey-pelykh mentioned this pull request Mar 10, 2026

Cherry-pick: upstream CI workflow updates (3 commits) remoteclaw/remoteclaw#906

Closed

4 tasks

sauerdaniel pushed a commit to sauerdaniel/openclaw that referenced this pull request Mar 11, 2026

docs: clarify bot review conversation ownership (openclaw#39942)

a93c2f6

* docs: clarify bot review conversations

Moshiii pushed a commit to Moshiii/openclaw that referenced this pull request Mar 11, 2026

docs: clarify bot review conversation ownership (openclaw#39942)

b360535

* docs: clarify bot review conversations

Moshiii pushed a commit to Moshiii/openclaw that referenced this pull request Mar 11, 2026

docs: clarify bot review conversation ownership (openclaw#39942)

9b1570b

* docs: clarify bot review conversations

dhoman pushed a commit to dhoman/chrono-claw that referenced this pull request Mar 11, 2026

docs: clarify bot review conversation ownership (openclaw#39942)

4836ceb

* docs: clarify bot review conversations

alexey-pelykh pushed a commit to remoteclaw/remoteclaw that referenced this pull request Mar 14, 2026

docs: clarify bot review conversation ownership (openclaw#39942)

5f14be7

* docs: clarify bot review conversations (cherry picked from commit 2755880)

alexey-pelykh mentioned this pull request Mar 14, 2026

Cherry-pick 27558806b: docs: clarify bot review conversation ownership remoteclaw/remoteclaw#1296

Merged

senw-developers pushed a commit to senw-developers/va-openclaw that referenced this pull request Mar 17, 2026

docs: clarify bot review conversation ownership (openclaw#39942)

19c1104

* docs: clarify bot review conversations

V-Gutierrez pushed a commit to V-Gutierrez/openclaw-vendor that referenced this pull request Mar 17, 2026

docs: clarify bot review conversation ownership (openclaw#39942)

fc0f978

* docs: clarify bot review conversations

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

docs: clarify bot review conversation ownership#39942

docs: clarify bot review conversation ownership#39942
Takhoffman merged 2 commits intomainfrom
docs-review-thread-ownership

Takhoffman commented Mar 8, 2026

Uh oh!

greptile-apps bot commented Mar 8, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

Takhoffman commented Mar 8, 2026

Summary

Change Type (select all)

Scope (select all touched areas)

Linked Issue/PR

User-visible / Behavior Changes

Security Impact (required)

Repro + Verification

Environment

Steps

Expected

Actual

Evidence

Human Verification (required)

Compatibility / Migration

Failure Recovery (if this breaks)

Risks and Mitigations

Uh oh!

greptile-apps bot commented Mar 8, 2026

Greptile Summary

Confidence Score: 5/5

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant