fix(ClawdbotKit): move tool-display.json to correct SPM Resources path#398
Closed
fcatuhe wants to merge 1 commit intoopenclaw:mainfrom
Closed
fix(ClawdbotKit): move tool-display.json to correct SPM Resources path#398fcatuhe wants to merge 1 commit intoopenclaw:mainfrom
fcatuhe wants to merge 1 commit intoopenclaw:mainfrom
Conversation
The tool-display.json file was at the package root level
(ClawdbotKit/Resources/) instead of inside the target's source
directory (ClawdbotKit/Sources/ClawdbotKit/Resources/).
SPM's .process("Resources") directive is relative to the target's
source folder, so the file wasn't being bundled. This caused
NSBundle.module to fail with an assertion when ToolDisplayRegistry
tried to load the config, crashing the app on launch.
Contributor
|
Thanks François! |
Contributor
Contributor
dgarson
added a commit
to dgarson/clawdbot
that referenced
this pull request
Feb 9, 2026
…w#398) The finalizeJobRun function expects startedAtMs in its opts parameter, but ops.ts was passing runAtMs which doesn't exist in the type. This caused the plugin-sdk:dts build step to fail with TS2353.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tool-display.jsonfrom package root (ClawdbotKit/Resources/) to target source directory (ClawdbotKit/Sources/ClawdbotKit/Resources/)NSBundle.moduleassertion failureProblem
SPM's
.process("Resources")directive is relative to the target's source folder, so the file at the package root wasn't being bundled. WhenToolDisplayRegistry.loadConfig()tried to accessClawdbotKitResources.bundle, the missing bundle caused a fatal assertion.Test plan
~/Library/Logs/DiagnosticReports/