fix(agents): resolve gpt-5.4 crash when custom openai-codex config omits api#39753
Merged
steipete merged 2 commits intoopenclaw:mainfrom Mar 8, 2026
Merged
Conversation
When a user configures `models.providers.openai-codex` with a models array but omits the `api` field, `buildInlineProviderModels` produces an entry with `api: undefined`. The inline-match early return then hands this incomplete model straight to the caller, skipping the forward-compat resolver that would supply the correct `openai-codex-responses` api — causing a crash loop. Let the inline match fall through to forward-compat when `api` is absent so the resolver chain can fill it in. Fixes openclaw#39682
justinhuangcode
changed the title
Contributor
Greptile SummaryThis PR fixes a crash loop for
Confidence Score: 5/5
Last reviewed commit: 7be385c |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+658
to
+664
| const result = resolveModel("openai-codex", "gpt-5.4", "/tmp/agent", cfg); | ||
| expect(result.error).toBeUndefined(); | ||
| expect(result.model).toMatchObject({ | ||
| api: "openai-codex-responses", | ||
| id: "gpt-5.4", | ||
| provider: "openai-codex", | ||
| }); |
Contributor
There was a problem hiding this comment.
Test missing baseUrl preservation assertion
The PR description specifically calls out that the fix "preserves any user-supplied baseUrl / headers". The test configures baseUrl: "https://custom.example.com" but never asserts it appears on the resolved model. Adding this assertion would guard against a future regression where the fall-through path drops the user-configured baseUrl.
Suggested change
| const result = resolveModel("openai-codex", "gpt-5.4", "/tmp/agent", cfg); | |
| expect(result.error).toBeUndefined(); | |
| expect(result.model).toMatchObject({ | |
| api: "openai-codex-responses", | |
| id: "gpt-5.4", | |
| provider: "openai-codex", | |
| }); | |
| const result = resolveModel("openai-codex", "gpt-5.4", "/tmp/agent", cfg); | |
| expect(result.error).toBeUndefined(); | |
| expect(result.model).toMatchObject({ | |
| api: "openai-codex-responses", | |
| id: "gpt-5.4", | |
| provider: "openai-codex", | |
| baseUrl: "https://custom.example.com", | |
| }); |
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/agents/pi-embedded-runner/model.test.ts
Line: 658-664
Comment:
**Test missing `baseUrl` preservation assertion**
The PR description specifically calls out that the fix "preserves any user-supplied `baseUrl` / `headers`". The test configures `baseUrl: "https://custom.example.com"` but never asserts it appears on the resolved model. Adding this assertion would guard against a future regression where the fall-through path drops the user-configured `baseUrl`.
```suggestion
const result = resolveModel("openai-codex", "gpt-5.4", "/tmp/agent", cfg);
expect(result.error).toBeUndefined();
expect(result.model).toMatchObject({
api: "openai-codex-responses",
id: "gpt-5.4",
provider: "openai-codex",
baseUrl: "https://custom.example.com",
});
```
How can I resolve this? If you propose a fix, please make it concise.
justinhuangcode
force-pushed
the
fix/codex-inline-model-api-fallback
branch
from
507cd3c to
cb07d15
Compare
steipete
added a commit
that referenced
this pull request
Mar 8, 2026
Contributor
|
Landed via temp rebase onto main. Thanks @justinhuangcode! |
dustin-olenslager
pushed a commit
to dustin-olenslager/ironclaw-supreme
that referenced
this pull request
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39682
Summary
When you configure
openai-codexwith a custom models list but don't setapi:buildInlineProviderModelsproducesapi: undefined, and the inline match returns it before forward-compat gets a chance to fill inopenai-codex-responses. This crashes the agent.The fix is small: only return the inline match early when it actually has an
api. Otherwise let it fall through to the forward-compat path, which already handles user config (baseUrl, headers etc.) viaapplyConfiguredProviderOverrides.Testing
Added a regression test for the config above. Existing 43 tests unaffected.