fix(acpx): pass MCP server configuration to ACP sessions by goodspeed-apps · Pull Request #39337 · openclaw/openclaw

goodspeed-apps · 2026-03-08T01:19:50Z

Problem

The ACPX runtime was ignoring MCP server configurations, always passing mcpServers: [] to the underlying acpx CLI. This prevented users from using external MCP servers like Canva's MCP with OpenClaw's ACP runtime.

Solution

This PR adds support for configuring MCP servers in the ACPX plugin configuration and passes them to the acpx CLI when creating new sessions.

Changes

Added McpServerConfig type and validation
Updated runtime to pass MCP servers to acpx CLI
Updated service logging
Added config schema for MCP servers
Added comprehensive tests

Testing

Added config.test.ts with tests for config validation
Verified that mcpServers are correctly passed to acpx

Fixes #39225

greptile-apps · 2026-03-08T01:23:02Z

Greptile Summary

This PR fixes a bug where the ACPX runtime always passed an empty mcpServers array to the underlying acpx CLI, preventing users from configuring external MCP servers. The fix adds:

McpServerConfig type with thorough validation in config.ts
JSON schema for the plugin configuration UI with full MCP server structure
Proper passing of MCP server config to acpx CLI in runtime.ts (only when creating new sessions)
Service logging of configured MCP server count
Comprehensive test coverage

The implementation is correct and well-tested. One minor code quality issue: an unused destructured variable key in the env validation loop should be prefixed with underscore to suppress linter warnings.

Confidence Score: 4/5

Safe to merge after fixing the unused variable linting warning.
The PR correctly implements MCP server config passing with comprehensive validation and tests. The core logic is sound. One minor code quality issue—an unused variable that will trigger linter warnings—needs to be fixed before merge. This is a quick fix that doesn't affect functionality.
extensions/acpx/src/config.ts — Fix unused variable key by prefixing with underscore on line 93.

_{Last reviewed commit: 628ba1e}

greptile-apps · 2026-03-08T01:23:06Z

extensions/acpx/src/config.ts

+    for (const [key, val] of Object.entries(value.env)) {
+      if (typeof val !== "string") return false;
+    }


The variable key is destructured but never used. This will trigger TypeScript's noUnusedLocals (or ESLint equivalent) warnings. Prefix with an underscore to suppress:

Suggested change

for (const [key, val] of Object.entries(value.env)) {

if (typeof val !== "string") return false;

}

for (const [_key, val] of Object.entries(value.env)) {

if (typeof val !== "string") return false;

}

Prompt To Fix With AI

This is a comment left during a code review. Path: extensions/acpx/src/config.ts Line: 93-95 Comment: The variable `key` is destructured but never used. This will trigger TypeScript's `noUnusedLocals` (or ESLint equivalent) warnings. Prefix with an underscore to suppress: ```suggestion for (const [_key, val] of Object.entries(value.env)) { if (typeof val !== "string") return false; } ``` How can I resolve this? If you propose a fix, please make it concise.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 628ba1eaad

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-08T01:23:51Z

extensions/acpx/src/runtime.ts

        }),
        cwd,
        fallbackCode: "ACP_SESSION_INIT_FAILED",
+        mcpServers: this.config.mcpServers,


Pass MCP server config on the main ensure-session path

mcpServers is only attached in the fallback sessions new branch, but ensureSession first calls sessions ensure and accepts that result whenever it already returns session IDs (the normal behavior). In that common path, the CLI never receives --mcpServers, so configured MCP servers are still not applied to sessions despite this change.

Useful? React with 👍 / 👎.

xkonjin

Quick review pass:

Main risk area here is auth/session state and stale credential handling.
Good to see test coverage move with the code; I’d still make sure it exercises the unhappy path around auth/session state and stale credential handling rather than only the happy path.
Before merge, I’d smoke-test the behavior touched by openclaw.plugin.json, config.test.ts, config.ts (+2 more) with malformed input / retry / rollback cases, since that’s where this class of change usually breaks.
Cancellation paths are notoriously flaky; a deterministic test proving cleanup happens on abort/timeout would reduce regression risk.

Co-authored-by: Goodspeed App Studio <[email protected]>

steipete · 2026-03-08T03:17:52Z

Landed on main in 5659d7f.
Source PR head: 628ba1e.

The original PR direction exposed the right config surface, but bundled acpx 0.1.15 does not support a --mcpServers CLI flag and still hardcodes mcpServers: [] on session bootstrap. I landed a fix-up that keeps bundled acpx unchanged and routes MCP-configured sessions through a small ACP bootstrap proxy via --agent, so session/new, session/load, and session/fork receive the configured MCP servers while acpx auth/queue behavior stays intact.

Validated with:

pnpm lint
pnpm build
pnpm test

Landed commit:
5659d7f

Source commit:
628ba1e

Thanks @goodspeed-apps.

@goodspeed-apps

* main: (290 commits) test: stabilize exec resolver timeout fixture chore: add changelog and format fix for openclaw#39414 fix(chat): preserve sender labels in dashboard history docs: clean up latest changelog sections docs: dedupe changelog contributor attribution fix(ci): resolve current gate regressions refactor(voice-call): share tts deep merge fix: land openclaw#39337 by @goodspeed-apps for acpx MCP bootstrap fix(ci): resolve type regressions on main fix: document discord agentComponents schema parity (openclaw#39378) (thanks @gambletan) (openclaw#39378) fix(discord): validate agentComponents config test: cover daemon probe auth seam refactor: preserve explicit mock voice-call values refactor: register gateway service adapters refactor: reuse shared gateway probe auth refactor: split daemon status gathering refactor: centralize strict numeric parsing refactor: normalize voice-call runtime defaults fix(ci): pin multi-arch docker base digests docs: add changelog for Telegram DM draft restore (openclaw#39398) ...

Co-authored-by: Goodspeed App Studio <[email protected]>

Co-authored-by: Goodspeed App Studio <[email protected]> (cherry picked from commit 5659d7f) # Conflicts: # extensions/acpx/openclaw.plugin.json # extensions/acpx/src/config.test.ts # extensions/acpx/src/config.ts # extensions/acpx/src/runtime-internals/test-fixtures.ts # extensions/acpx/src/runtime.test.ts # extensions/acpx/src/runtime.ts # extensions/acpx/src/service.ts

@vincentkoc

…r live test fixes (#1795) * Changelog: credit openclaw#39328 to @vincentkoc (cherry picked from commit 2ec478c) * Changelog: move openclaw#39328 credit to section end (cherry picked from commit 5b30c9d) * Pi Runner: gate parallel_tool_calls to compatible APIs (openclaw#39356) * Pi Runner: gate parallel_tool_calls payload injection * Pi Runner: cover parallel_tool_calls alias precedence * Changelog: note parallel_tool_calls compatibility fix * Update CHANGELOG.md * Pi Runner: clarify null parallel_tool_calls override logging (cherry picked from commit daecd2d) # Conflicts: # CHANGELOG.md # src/agents/pi-embedded-runner-extraparams.test.ts # src/agents/pi-embedded-runner/extra-params.ts * docs: add changelog for Telegram DM draft restore (openclaw#39398) (cherry picked from commit 722c5e5) * fix: document discord agentComponents schema parity (openclaw#39378) (thanks @gambletan) (openclaw#39378) Co-authored-by: Shadow <[email protected]> (cherry picked from commit 9c8e34d) * fix: land openclaw#39337 by @goodspeed-apps for acpx MCP bootstrap Co-authored-by: Goodspeed App Studio <[email protected]> (cherry picked from commit 5659d7f) # Conflicts: # extensions/acpx/openclaw.plugin.json # extensions/acpx/src/config.test.ts # extensions/acpx/src/config.ts # extensions/acpx/src/runtime-internals/test-fixtures.ts # extensions/acpx/src/runtime.test.ts # extensions/acpx/src/runtime.ts # extensions/acpx/src/service.ts * docs: clean up latest changelog sections (cherry picked from commit c743fd9) * fix: land contributor PR openclaw#39516 from @Imhermes1 macOS app/chat/browser/cron/permissions fixes. Co-authored-by: ImHermes1 <[email protected]> (cherry picked from commit d15b6af) # Conflicts: # CHANGELOG.md # apps/macos/Sources/RemoteClaw/NodeMode/MacNodeBrowserProxy.swift # apps/macos/Sources/RemoteClaw/NodeMode/MacNodeModeCoordinator.swift # apps/macos/Sources/RemoteClaw/NodeMode/MacNodeRuntime.swift # apps/macos/Sources/RemoteClaw/PermissionsSettings.swift # apps/macos/Tests/RemoteClawIPCTests/MacNodeBrowserProxyTests.swift # apps/shared/RemoteClawKit/Sources/RemoteClawChatUI/ChatView.swift # apps/shared/RemoteClawKit/Sources/RemoteClawKit/BrowserCommands.swift # apps/shared/RemoteClawKit/Tests/RemoteClawKitTests/ChatComposerPasteSupportTests.swift * fix: stage docker live tests from mounted source (cherry picked from commit 21df014) * fix: add minimal process shim for acpx mcp-agent-command The upstream process.ts depends on gutted runtime-api, so provide a minimal spawnAndCollect implementation that satisfies the import. --------- Co-authored-by: Vincent Koc <[email protected]> Co-authored-by: Ayaan Zaidi <[email protected]> Co-authored-by: gambletan <[email protected]> Co-authored-by: Shadow <[email protected]> Co-authored-by: Peter Steinberger <[email protected]>

fix(acpx): pass MCP server configuration to ACP sessions

628ba1e

Fixes #39225

openclaw-barnacle bot added extensions: acpx size: M labels Mar 8, 2026

greptile-apps bot reviewed Mar 8, 2026

View reviewed changes

chatgpt-codex-connector bot reviewed Mar 8, 2026

View reviewed changes

xkonjin reviewed Mar 8, 2026

View reviewed changes

steipete mentioned this pull request Mar 8, 2026

ACPX runtime ignores MCP server config (mcpServers always empty), blocking Canva MCP #39225

Closed

steipete added a commit that referenced this pull request Mar 8, 2026

fix: land #39337 by @goodspeed-apps for acpx MCP bootstrap

5659d7f

Co-authored-by: Goodspeed App Studio <[email protected]>

steipete closed this Mar 8, 2026

mcaxtr pushed a commit to mcaxtr/openclaw that referenced this pull request Mar 8, 2026

fix: land openclaw#39337 by @goodspeed-apps for acpx MCP bootstrap

a598b53

Co-authored-by: Goodspeed App Studio <[email protected]>

github-actions bot mentioned this pull request Mar 8, 2026

上游更新: v2026.3.7 — 19 P0 + 122 P1 待合并 jiulingyun/openclaw-cn#486

Open

Saitop pushed a commit to NomiciAI/openclaw that referenced this pull request Mar 8, 2026

fix: land openclaw#39337 by @goodspeed-apps for acpx MCP bootstrap

5ad1c04

Co-authored-by: Goodspeed App Studio <[email protected]>

GordonSH-oss pushed a commit to GordonSH-oss/openclaw that referenced this pull request Mar 9, 2026

fix: land openclaw#39337 by @goodspeed-apps for acpx MCP bootstrap

0b362b3

Co-authored-by: Goodspeed App Studio <[email protected]>

jenawant pushed a commit to jenawant/openclaw that referenced this pull request Mar 10, 2026

fix: land openclaw#39337 by @goodspeed-apps for acpx MCP bootstrap

cb61a37

Co-authored-by: Goodspeed App Studio <[email protected]>

alexey-pelykh mentioned this pull request Mar 10, 2026

Cherry-pick: upstream changelog and docs (10 commits) remoteclaw/remoteclaw#891

Closed

4 tasks

dhoman pushed a commit to dhoman/chrono-claw that referenced this pull request Mar 11, 2026

fix: land openclaw#39337 by @goodspeed-apps for acpx MCP bootstrap

e9e277f

Co-authored-by: Goodspeed App Studio <[email protected]>

senw-developers pushed a commit to senw-developers/va-openclaw that referenced this pull request Mar 17, 2026

fix: land openclaw#39337 by @goodspeed-apps for acpx MCP bootstrap

03ade59

Co-authored-by: Goodspeed App Studio <[email protected]>

V-Gutierrez pushed a commit to V-Gutierrez/openclaw-vendor that referenced this pull request Mar 17, 2026

fix: land openclaw#39337 by @goodspeed-apps for acpx MCP bootstrap

b6191b0

Co-authored-by: Goodspeed App Studio <[email protected]>

alexey-pelykh mentioned this pull request Mar 22, 2026

Cherry-pick issue #891: upstream browser proxy, chat refactors, docker live test fixes remoteclaw/remoteclaw#1795

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(acpx): pass MCP server configuration to ACP sessions#39337

fix(acpx): pass MCP server configuration to ACP sessions#39337
goodspeed-apps wants to merge 1 commit intoopenclaw:mainfrom
goodspeed-apps:fix/issue-39225-acpx-mcp-servers

goodspeed-apps commented Mar 8, 2026

Uh oh!

greptile-apps bot commented Mar 8, 2026

Uh oh!

greptile-apps bot Mar 8, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Mar 8, 2026

Uh oh!

xkonjin left a comment

Uh oh!

steipete commented Mar 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

goodspeed-apps commented Mar 8, 2026

Problem

Solution

Changes

Testing

Uh oh!

greptile-apps bot commented Mar 8, 2026

Greptile Summary

Confidence Score: 4/5

Uh oh!

greptile-apps bot Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

xkonjin left a comment

Choose a reason for hiding this comment

Uh oh!

steipete commented Mar 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants