Greptile Summary

This PR fixes a Swift exclusive-access (memory exclusivity) violation in VoiceWakeOverlayController, TalkOverlayController, and NotifyOverlayController by replacing the inout Bool parameter on OverlayPanelFactory.present() with a pre-computed Bool value (isFirstPresent).

Root cause: Passing &self.model.isVisible as inout to a function that also captures self in an escaping/trailing closure triggered Swift's Law of Exclusivity — the same memory location had a simultaneous write (inout borrow) and a read (via self capture) at the same time.

Fix: Each call site now snapshots isFirst = !self.model.isVisible and eagerly sets self.model.isVisible = true (when needed) before entering OverlayPanelFactory.present(). The factory function now only receives a plain value copy, eliminating the exclusivity conflict entirely.

• OverlayPanelFactory.present() signature changed from isVisible: inout Bool → isFirstPresent: Bool
• All three overlay controllers (VoiceWakeOverlayController, TalkOverlayController, NotifyOverlayController) updated to match the new signature
• Behaviour is semantically equivalent to the original; no functional regressions expected

Confidence Score: 5/5

• This PR is safe to merge — it fixes a Swift exclusivity violation with a minimal, well-scoped refactor and no behavioral regressions.
• The change is mechanically straightforward: an inout Bool parameter is replaced with a pre-computed value copy across three identical call sites, and the factory function's internal logic is unchanged. All three overlay controllers remain semantically equivalent to their pre-patch behavior. The flag is set at the call site before the factory invocation, eliminating the simultaneous read/write conflict that triggered the exclusivity violation. No new logic is introduced, no tests are skipped, and the fix directly addresses the reported exclusivity crash.
• No files require special attention.

_{Last reviewed commit: 992cdcc}

Landed via temp rebase onto main.

• Gate: swift test --package-path apps/macos --filter LowCoverageViewSmokeTests + uvx --from pre-commit pre-commit run --all-files detect-secrets + pnpm lint && pnpm build && pnpm test
• Source branch tip: 9e4a7b54965869e6955e2ca667c5fcc89ecafe16
• Merge commit: 58ae5582f4cd829563fc917216ccb5df4da2ccf4

Thanks @fellanH!

Follow-up landed on main in d5b305b

GitHub's deleted-head rebase path kept the contributor commit but dropped the maintainer follow-up that added the changelog entry and the repeated Talk overlay smoke test, so I landed those directly on main afterward.

Thanks @fellanH!