fix(synology-chat): respect SYNOLOGY_RATE_LIMIT=0 in env var parsing by scoootscooob · Pull Request #39197 · openclaw/openclaw

scoootscooob · 2026-03-07T21:29:00Z

Summary

Replace parseInt(envRateLimit, 10) || 30 with a proper parse that uses Number.isFinite() to validate
parseInt("0", 10) returns 0 which || treats as falsy, silently defaulting to 30
The new approach correctly handles both 0 (valid rate limit) and NaN (invalid input falls back to 30)

Test plan

Added test: respects SYNOLOGY_RATE_LIMIT=0 instead of defaulting to 30
All 12 synology-chat account tests pass

🤖 Generated with Claude Code

parseInt(envRateLimit, 10) || 30 drops valid 0 because 0 is falsy. Switch to ?? (nullish coalescing) so only NaN triggers the default. Fixes openclaw#39191 Co-Authored-By: Claude Opus 4.6 <[email protected]>

greptile-apps · 2026-03-07T21:30:41Z

Greptile Summary

This PR fixes a subtle falsy-value bug in the SYNOLOGY_RATE_LIMIT environment variable parsing inside extensions/synology-chat/src/accounts.ts. The original expression parseInt(envRateLimit, 10) || 30 silently fell back to 30 when the env var was set to "0" because JavaScript's || operator treats 0 as falsy. The fix replaces this with a proper Number.isFinite() guard so that 0 is honoured as a valid rate limit while non-numeric and unset inputs still fall back to 30.

Root cause fixed: parseInt("0", 10) returns 0; 0 || 30 evaluates to 30 — now replaced with Number.isFinite(parsedRateLimit) ? parsedRateLimit : 30.
All edge cases handled correctly: unset env var → NaN → 30; "0" → 0; non-numeric string (e.g. "abc") → NaN → 30.
Regression test added: a new test case respects SYNOLOGY_RATE_LIMIT=0 instead of defaulting to 30 directly exercises the previously broken path and relies on the existing beforeEach cleanup to avoid state leakage.

Confidence Score: 5/5

This PR is safe to merge — it is a minimal, well-tested bug fix with no risk of regression.
The change is two lines in the source and one new test. The logic is provably correct for all relevant inputs (undefined, "0", valid integers, non-numeric strings). The existing test suite is left intact and the new test directly covers the previously broken case. No architectural changes or refactoring present.
No files require special attention.

_{Last reviewed commit: 5629a3d}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5629a3ddac

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-03-07T21:31:57Z

extensions/synology-chat/src/accounts.ts

+  const parsedRateLimit = envRateLimit != null ? parseInt(envRateLimit, 10) : NaN;
+  const envRateLimitValue = Number.isFinite(parsedRateLimit) ? parsedRateLimit : 30;


Reject partially numeric rate-limit env values

Using parseInt with Number.isFinite treats malformed values that start with zero (for example SYNOLOGY_RATE_LIMIT=0abc or 0x10) as valid 0, so this change now accepts those inputs instead of falling back to 30 as before. That silently changes runtime throttling behavior for misconfigured deployments and can unexpectedly clamp message throughput; the env value should only be accepted when the entire string is a valid integer.

Useful? React with 👍 / 👎.

@scoootscooob

Landed from contributor PR #39197 by @scoootscooob. Co-authored-by: scoootscooob <[email protected]>

steipete · 2026-03-08T02:34:31Z

Landed on main after rebasing onto the latest origin/main.

What shipped:

honor SYNOLOGY_RATE_LIMIT=0 as an explicit rate limit instead of falling back to 30
tighten env parsing so malformed values like 0abc still fall back to the default instead of being partially parsed
added regression coverage for both the explicit 0 case and malformed-value fallback
updated CHANGELOG.md
ran pnpm lint, pnpm build, and pnpm test

Landed commit:

af9d76b

Source PR commit:

5629a3d

Thanks @scoootscooob.

@scoootscooob

Landed from contributor PR openclaw#39197 by @scoootscooob. Co-authored-by: scoootscooob <[email protected]>

@scoootscooob

Landed from contributor PR openclaw#39197 by @scoootscooob. Co-authored-by: scoootscooob <[email protected]>

@scoootscooob

Landed from contributor PR openclaw#39197 by @scoootscooob. Co-authored-by: scoootscooob <[email protected]>

@scoootscooob

Landed from contributor PR openclaw#39197 by @scoootscooob. Co-authored-by: scoootscooob <[email protected]>

@scoootscooob

Landed from contributor PR openclaw#39197 by @scoootscooob. Co-authored-by: scoootscooob <[email protected]>

@scoootscooob

Landed from contributor PR openclaw#39197 by @scoootscooob. Co-authored-by: scoootscooob <[email protected]>

@scoootscooob

Landed from contributor PR openclaw#39197 by @scoootscooob. Co-authored-by: scoootscooob <[email protected]>

@scoootscooob

Landed from contributor PR openclaw#39197 by @scoootscooob. Co-authored-by: scoootscooob <[email protected]> (cherry picked from commit af9d76b)

@scoootscooob

… CI fixes (#1794) * fix: honor explicit Synology Chat rate-limit env values Landed from contributor PR openclaw#39197 by @scoootscooob. Co-authored-by: scoootscooob <[email protected]> (cherry picked from commit af9d76b) * fix: honor zero-valued voice-call STT settings Landed from contributor PR openclaw#39196 by @scoootscooob. Co-authored-by: scoootscooob <[email protected]> (cherry picked from commit 28b72e5) * fix: honor explicit OpenAI TTS speed values Landed from contributor PR openclaw#39318 by @ql-wade. Co-authored-by: ql-wade <[email protected]> (cherry picked from commit 442f2c3) * Voice Call: allowlist realtime STT api key fixtures (cherry picked from commit b8b6569) * Voice Call: read TTS internals in tests (cherry picked from commit b1f7cf4) * Voice Call: read realtime STT internals in tests (cherry picked from commit 244aabb) * test: fix gate regressions (cherry picked from commit 56cd008) * refactor: normalize voice-call runtime defaults (cherry picked from commit 3087893) * refactor: preserve explicit mock voice-call values (cherry picked from commit f6c7ff3) * fix(ci): resolve type regressions on main (cherry picked from commit f721141) * refactor(voice-call): share tts deep merge (cherry picked from commit ed43743) * fix: land openclaw#33992 from @darkamenosa Co-authored-by: Tom <[email protected]> (cherry picked from commit fcdc1a1) * fix(ci): repair zalouser CI failures (cherry picked from commit 06ffef8) * fix: resolve cherry-pick type errors in zalouser extension Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> * fix: resolve cherry-pick type error in voice-call config test — adapt SecretRef to string apiKey Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> --------- Co-authored-by: Peter Steinberger <[email protected]> Co-authored-by: scoootscooob <[email protected]> Co-authored-by: ql-wade <[email protected]> Co-authored-by: Vincent Koc <[email protected]> Co-authored-by: Tom <[email protected]> Co-authored-by: Claude Opus 4.6 (1M context) <[email protected]>

fix(synology-chat): respect SYNOLOGY_RATE_LIMIT=0 in env var parsing

5629a3d

parseInt(envRateLimit, 10) || 30 drops valid 0 because 0 is falsy. Switch to ?? (nullish coalescing) so only NaN triggers the default. Fixes openclaw#39191 Co-Authored-By: Claude Opus 4.6 <[email protected]>

openclaw-barnacle bot added the size: XS label Mar 7, 2026

chatgpt-codex-connector bot reviewed Mar 7, 2026

View reviewed changes

steipete mentioned this pull request Mar 8, 2026

bug: synology-chat ignores SYNOLOGY_RATE_LIMIT=0 (parseInt || 30 truthy check) #39191

Open

mvanhorn mentioned this pull request Mar 8, 2026

fix(synology-chat): use nullish coalescing for SYNOLOGY_RATE_LIMIT=0 #39276

Closed

3 tasks

steipete added a commit that referenced this pull request Mar 8, 2026

fix: honor explicit Synology Chat rate-limit env values

af9d76b

Landed from contributor PR #39197 by @scoootscooob. Co-authored-by: scoootscooob <[email protected]>

steipete closed this Mar 8, 2026

mcaxtr pushed a commit to mcaxtr/openclaw that referenced this pull request Mar 8, 2026

fix: honor explicit Synology Chat rate-limit env values

c64f3b6

Landed from contributor PR openclaw#39197 by @scoootscooob. Co-authored-by: scoootscooob <[email protected]>

Saitop pushed a commit to NomiciAI/openclaw that referenced this pull request Mar 8, 2026

fix: honor explicit Synology Chat rate-limit env values

d74ac71

Landed from contributor PR openclaw#39197 by @scoootscooob. Co-authored-by: scoootscooob <[email protected]>

GordonSH-oss pushed a commit to GordonSH-oss/openclaw that referenced this pull request Mar 9, 2026

fix: honor explicit Synology Chat rate-limit env values

7b7d1b1

Landed from contributor PR openclaw#39197 by @scoootscooob. Co-authored-by: scoootscooob <[email protected]>

jenawant pushed a commit to jenawant/openclaw that referenced this pull request Mar 10, 2026

fix: honor explicit Synology Chat rate-limit env values

b865f97

Landed from contributor PR openclaw#39197 by @scoootscooob. Co-authored-by: scoootscooob <[email protected]>

dhoman pushed a commit to dhoman/chrono-claw that referenced this pull request Mar 11, 2026

fix: honor explicit Synology Chat rate-limit env values

a8c707a

Landed from contributor PR openclaw#39197 by @scoootscooob. Co-authored-by: scoootscooob <[email protected]>

senw-developers pushed a commit to senw-developers/va-openclaw that referenced this pull request Mar 17, 2026

fix: honor explicit Synology Chat rate-limit env values

07621ad

Landed from contributor PR openclaw#39197 by @scoootscooob. Co-authored-by: scoootscooob <[email protected]>

V-Gutierrez pushed a commit to V-Gutierrez/openclaw-vendor that referenced this pull request Mar 17, 2026

fix: honor explicit Synology Chat rate-limit env values

b4f0d60

Landed from contributor PR openclaw#39197 by @scoootscooob. Co-authored-by: scoootscooob <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(synology-chat): respect SYNOLOGY_RATE_LIMIT=0 in env var parsing#39197

fix(synology-chat): respect SYNOLOGY_RATE_LIMIT=0 in env var parsing#39197
scoootscooob wants to merge 1 commit intoopenclaw:mainfrom
scoootscooob:fix/synology-rate-limit-zero

scoootscooob commented Mar 7, 2026

Uh oh!

greptile-apps bot commented Mar 7, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Mar 7, 2026

Uh oh!

steipete commented Mar 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		const parsedRateLimit = envRateLimit != null ? parseInt(envRateLimit, 10) : NaN;
		const envRateLimitValue = Number.isFinite(parsedRateLimit) ? parsedRateLimit : 30;

Uh oh!

Conversation

scoootscooob commented Mar 7, 2026

Summary

Test plan

Uh oh!

greptile-apps bot commented Mar 7, 2026

Greptile Summary

Confidence Score: 5/5

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

steipete commented Mar 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants