Skip to content

fix CI: add missing mode property and secret scan pragmas in tests#39169

Closed
extrasmall0 wants to merge 1 commit intoopenclaw:mainfrom
extrasmall0:raymond/fix-ci-test-pragmas
Closed

fix CI: add missing mode property and secret scan pragmas in tests#39169
extrasmall0 wants to merge 1 commit intoopenclaw:mainfrom
extrasmall0:raymond/fix-ci-test-pragmas

Conversation

@extrasmall0
Copy link
Copy Markdown
Contributor

The delivery dispatch test helper was missing the mode property after the type was updated, causing tsc to fail. Also added missing pragma: allowlist secret comments on a few test fixture strings that were tripping the secret scanner.

  • Add mode: "explicit" to makeResolvedDelivery() in delivery-dispatch.double-announce.test.ts
  • Add secret scan pragmas to test API key fixtures in models-config tests

@openclaw-barnacle openclaw-barnacle bot added agents Agent runtime and tooling size: XS labels Mar 7, 2026
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Mar 7, 2026

Greptile Summary

This PR fixes two CI failures: a TypeScript compilation error in a test helper missing a required mode property, and secret scanner false positives on test fixture strings. The changes are minimal, targeted, and do not affect production code.

  • Added mode: "explicit" to makeResolvedDelivery() in the double-announce dispatch test — this field is required by the DeliveryTargetResolution type (mode: "explicit" | "implicit") and was absent after the type was updated.
  • Added // pragma: allowlist secret to three test fixture strings across two files to suppress detect-secrets false positives. All three pragmas are on the same line as the secret value, which is the correct placement. Note that the pragma on line 417 of models-config.fills-missing-provider-apikey-from-env-var.test.ts is appended to an existing comment with a double space (// already resolved by loadConfig pragma: allowlist secret), which is visually inconsistent but functionally valid.

Confidence Score: 5/5

  • This PR is safe to merge — all changes are limited to test files and address CI tooling failures with no impact on production logic.
  • Three test-only files are modified. The mode: "explicit" fix is a direct, correct response to a TypeScript type requirement. The secret scanner pragmas follow the expected detect-secrets format. No production code is touched, no test logic is altered, and there are no edge cases introduced.
  • No files require special attention.

Last reviewed commit: bc49c9e

@vincentkoc vincentkoc added the r: no-ci-pr Auto-response for CI/test-failure PRs label Mar 20, 2026
@openclaw-barnacle
Copy link
Copy Markdown

Please don't make PRs for test failures on main.

The team is aware of those and will handle them directly on the codebase, not only fixing the tests but also investigating what the root cause is. Having to sift through test-fix-PRs (including some that have been out of date for weeks...) on top of that doesn't help. There are already way too many PRs for humans to manage; please don't make the flood worse.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agents Agent runtime and tooling r: no-ci-pr Auto-response for CI/test-failure PRs size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants