fix CI: add missing mode property and secret scan pragmas in tests#39169
Closed
extrasmall0 wants to merge 1 commit intoopenclaw:mainfrom
Closed
fix CI: add missing mode property and secret scan pragmas in tests#39169extrasmall0 wants to merge 1 commit intoopenclaw:mainfrom
extrasmall0 wants to merge 1 commit intoopenclaw:mainfrom
Conversation
Contributor
Greptile SummaryThis PR fixes two CI failures: a TypeScript compilation error in a test helper missing a required
Confidence Score: 5/5
Last reviewed commit: bc49c9e |
4 tasks
|
Please don't make PRs for test failures on main. The team is aware of those and will handle them directly on the codebase, not only fixing the tests but also investigating what the root cause is. Having to sift through test-fix-PRs (including some that have been out of date for weeks...) on top of that doesn't help. There are already way too many PRs for humans to manage; please don't make the flood worse. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The delivery dispatch test helper was missing the
modeproperty after the type was updated, causingtscto fail. Also added missingpragma: allowlist secretcomments on a few test fixture strings that were tripping the secret scanner.mode: "explicit"tomakeResolvedDelivery()indelivery-dispatch.double-announce.test.tsmodels-configtests