Skip to content

fix(skills): expand skill-creator description to cover edit/audit/review triggers#39158

Merged
altaywtf merged 1 commit intoopenclaw:mainfrom
Nimbl-SaaS:fix/skill-creator-description
Mar 8, 2026
Merged

fix(skills): expand skill-creator description to cover edit/audit/review triggers#39158
altaywtf merged 1 commit intoopenclaw:mainfrom
Nimbl-SaaS:fix/skill-creator-description

Conversation

@haynzz
Copy link
Copy Markdown
Contributor

@haynzz haynzz commented Mar 7, 2026

Summary

  • Problem: The skill-creator skill description only listed creation-oriented phrases ("Create or update AgentSkills…designing, structuring, or packaging"). When a user said "tidy up a skill", "audit the skill", "review the skill", "clean up the skill", or "improve this SKILL.md", the model did not recognise the skill as relevant and winged the task without the skill's guidance.
  • Why it matters: Skill maintenance (editing, auditing, restructuring existing skills) is at least as common as creating new ones. Skipping the skill for these cases causes inconsistent results and undermines the skill's value as a spec-enforcing guide.
  • What changed: The description field in skills/skill-creator/SKILL.md frontmatter is expanded to explicitly cover edit/improve/review/audit/tidy-up scenarios and lists the exact trigger phrases.
  • What did NOT change: No logic, scripts, body copy, or other files were modified. This is a single-line frontmatter edit.

Change Type (select all)

  • Bug fix
  • Feature
  • Refactor
  • Docs
  • Security hardening
  • Chore/infra

Scope (select all touched areas)

  • Gateway / orchestration
  • Skills / tool execution
  • Auth / tokens
  • Memory / storage
  • Integrations
  • API / contracts
  • UI / DX
  • CI/CD / infra

Linked Issue/PR

User-visible / Behavior Changes

The skill-creator skill now triggers for maintenance-oriented phrasings in addition to creation-oriented ones. Users who say "tidy up my skill", "review the SKILL.md", "audit this skill", or "clean up the skill directory" will now have the skill loaded and its guidance applied.

Security Impact (required)

  • New permissions/capabilities? No
  • Secrets/tokens handling changed? No
  • New/changed network calls? No
  • Command/tool execution surface changed? No
  • Data access scope changed? No

Repro + Verification

Environment

  • OS: Linux (container, x64)
  • Runtime/container: OpenClaw gateway (node v22)
  • Model/provider: anthropic/claude-sonnet-4-6
  • Integration/channel: N/A (skill metadata only)
  • Relevant config: N/A

Steps

Before:

  1. Open a session with OpenClaw
  2. Say: "tidy up my pdf-editor skill"
  3. Model proceeds without loading skill-creator skill

After:

  1. Open a session with OpenClaw
  2. Say: "tidy up my pdf-editor skill"
  3. Model matches the expanded description and loads skill-creator skill before responding

Expected

  • "tidy up a skill", "audit the skill", "review the skill", "clean up the skill", "improve this skill" all trigger the skill-creator skill

Actual (before fix)

  • Only explicit creation phrases like "create a skill" or "design a skill" triggered it

Evidence

  • Trace/log snippets

Before (description that was too narrow):

description: Create or update AgentSkills. Use when designing, structuring, or packaging skills with scripts, references, and assets.

After (description with explicit trigger phrases):

description: Create, edit, improve, or audit AgentSkills. Use when creating a new skill from scratch or when asked to improve, review, audit, tidy up, or clean up an existing skill or SKILL.md file. Also use when editing or restructuring a skill directory (moving files to references/ or scripts/, removing stale content, validating against the AgentSkills spec). Triggers on phrases like "create a skill", "author a skill", "tidy up a skill", "improve this skill", "review the skill", "clean up the skill", "audit the skill".

pnpm build ✅ · pnpm check ✅ (pre-existing tlon/TS errors unrelated to this change)

Human Verification (required)

  • Verified the diff is exactly one line changed in one file (skills/skill-creator/SKILL.md frontmatter)
  • Verified the new description includes all phrases mentioned in issue skill-creator: description too narrow — fails to trigger on edit/refactor tasks #36039: "tidy up a skill", "review the skill", "audit the skill", "clean up the skill", "improve this SKILL.md", "edit an existing skill"
  • Verified pnpm build completes successfully with no new errors
  • Verified pnpm check output matches pre-existing failures only (tlon module resolution + two ui TS errors present on main before this branch)
  • What I did not verify: live session trigger testing against a running OpenClaw instance (description matching is purely text-based — the expanded text mechanically subsumes the original)

Compatibility / Migration

  • Backward compatible? Yes — existing triggers still work; new triggers added only
  • Config/env changes? No
  • Migration needed? No

Failure Recovery (if this breaks)

  • Revert: git revert HEAD on main (single-commit change, clean revert)
  • Files to restore: skills/skill-creator/SKILL.md — restore the description: line to the original value
  • Known bad symptoms: None expected; worst case is the description is slightly broader than necessary, which has no harmful effects

Risks and Mitigations

  • Risk: Overly broad description triggers the skill for unrelated skill-adjacent queries (e.g. "list my skills")
    • Mitigation: The trigger phrases are specific action verbs (tidy up, improve, audit, review, clean up) that only apply when a user intends to work on a skill. "List my skills" does not match any of them.

🤖 Generated with Claude Code · This PR was authored with AI assistance (Claude / OpenClaw agent session). The description change was authored, verified, and reviewed by the agent; build and check were run locally before filing.

…iew triggers

Closes openclaw#36039

The previous description was too narrow ('Create or update AgentSkills...'),
causing the skill to be skipped when users phrase requests as 'tidy up a skill',
'review the skill', 'audit the skill', 'clean up the skill', or 'improve this
SKILL.md'. Expand the description to list these trigger phrases explicitly.
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Mar 7, 2026

Greptile Summary

This PR expands the description frontmatter in skills/skill-creator/SKILL.md to cover maintenance-oriented trigger phrases (edit, audit, review, tidy up, clean up) in addition to the original creation-oriented ones. The change is minimal, backward-compatible, and correctly follows the skill's own documented guidance that the description should include all "when to use" context and explicit trigger phrases.

  • Only one line changed in one file — no logic, scripts, or body content touched.
  • The new description (~82 words) stays within the skill's own ~100-word metadata guideline (line 117 of the same file).
  • All six phrases cited in the linked issue are covered: "tidy up a skill", "review the skill", "audit the skill", "clean up the skill", "improve this SKILL.md", and "edit an existing skill".
  • The inclusion of the explicit Triggers on phrases like … clause aligns with the skill-creator's own frontmatter guidance (lines 324–327), which recommends listing concrete trigger phrases.

Confidence Score: 5/5

  • Safe to merge — purely additive documentation change with no code, logic, or configuration impact.
  • The change is a single-line frontmatter edit that only broadens the skill's trigger vocabulary. It is backward-compatible, follows the skill's own design guidelines, and carries no risk of breaking existing behaviour.
  • No files require special attention.

Last reviewed commit: 13997c1

@haynzz
Copy link
Copy Markdown
Contributor Author

haynzz commented Mar 7, 2026

CI Failure Note

Both failing jobs ( and ) are pre-existing failures on itself and are not caused by this PR (which only touches and ).

Evidence: The most recent CI run on (run #22806401873) fails on the same two jobs:

  • — falls back to a full scan (shallow clone lacks the base commit) and updates line numbers in the baseline → exits with code 3
  • — TS2741 error ( property missing) from a recently-merged commit

This PR is unblocked pending those upstream fixes landing on .

@haynzz
Copy link
Copy Markdown
Contributor Author

haynzz commented Mar 7, 2026

CI Failure Note

Both failing jobs (secrets and check) are pre-existing failures on main itself — not caused by this PR, which only touches skills/skill-creator/SKILL.md and .secrets.baseline.

Evidence: The most recent CI run on main (run #22806401873) fails on the same two jobs:

  • secretsdetect-secrets falls back to a full scan (shallow clone lacks the base commit) and updates line numbers in the baseline → exits with code 3
  • checksrc/cron/isolated-agent/delivery-dispatch.double-announce.test.ts:80 TS2741 error (mode property missing) from a recently-merged commit

This PR is unblocked pending those upstream fixes landing on main.

@haynzz haynzz force-pushed the fix/skill-creator-description branch from f7475e4 to 13997c1 Compare March 7, 2026 21:21
@altaywtf altaywtf merged commit aedf3ee into openclaw:main Mar 8, 2026
43 of 45 checks passed
@altaywtf
Copy link
Copy Markdown
Member

altaywtf commented Mar 8, 2026

Merged via squash.

Thanks @haynzz.

Saitop pushed a commit to NomiciAI/openclaw that referenced this pull request Mar 8, 2026
…iew triggers (openclaw#39158)

Merged via squash.

Prepared head SHA: 13997c1
Co-authored-by: haynzz <[email protected]>
Co-authored-by: altaywtf <[email protected]>
Reviewed-by: @altaywtf
GordonSH-oss pushed a commit to GordonSH-oss/openclaw that referenced this pull request Mar 9, 2026
…iew triggers (openclaw#39158)

Merged via squash.

Prepared head SHA: 13997c1
Co-authored-by: haynzz <[email protected]>
Co-authored-by: altaywtf <[email protected]>
Reviewed-by: @altaywtf
jenawant pushed a commit to jenawant/openclaw that referenced this pull request Mar 10, 2026
…iew triggers (openclaw#39158)

Merged via squash.

Prepared head SHA: 13997c1
Co-authored-by: haynzz <[email protected]>
Co-authored-by: altaywtf <[email protected]>
Reviewed-by: @altaywtf
sauerdaniel pushed a commit to sauerdaniel/openclaw that referenced this pull request Mar 11, 2026
…iew triggers (openclaw#39158)

Merged via squash.

Prepared head SHA: 13997c1
Co-authored-by: haynzz <[email protected]>
Co-authored-by: altaywtf <[email protected]>
Reviewed-by: @altaywtf
dhoman pushed a commit to dhoman/chrono-claw that referenced this pull request Mar 11, 2026
…iew triggers (openclaw#39158)

Merged via squash.

Prepared head SHA: 13997c1
Co-authored-by: haynzz <[email protected]>
Co-authored-by: altaywtf <[email protected]>
Reviewed-by: @altaywtf
senw-developers pushed a commit to senw-developers/va-openclaw that referenced this pull request Mar 17, 2026
…iew triggers (openclaw#39158)

Merged via squash.

Prepared head SHA: 13997c1
Co-authored-by: haynzz <[email protected]>
Co-authored-by: altaywtf <[email protected]>
Reviewed-by: @altaywtf
V-Gutierrez pushed a commit to V-Gutierrez/openclaw-vendor that referenced this pull request Mar 17, 2026
…iew triggers (openclaw#39158)

Merged via squash.

Prepared head SHA: 13997c1
Co-authored-by: haynzz <[email protected]>
Co-authored-by: altaywtf <[email protected]>
Reviewed-by: @altaywtf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

skill-creator: description too narrow — fails to trigger on edit/refactor tasks

2 participants