Skip to content

chore: Update Node.js version instructions in openclaw.mjs#39056

Closed
onstash wants to merge 1 commit intoopenclaw:mainfrom
onstash:patch-3
Closed

chore: Update Node.js version instructions in openclaw.mjs#39056
onstash wants to merge 1 commit intoopenclaw:mainfrom
onstash:patch-3

Conversation

@onstash
Copy link
Copy Markdown
Contributor

@onstash onstash commented Mar 7, 2026

Summary

Describe the problem and fix in 2–5 bullets:

  • Problem: error message before process.exit(1) has a hardcoded node version (major)
  • Why it matters: later when the min node version gets changed, this error message needs to be synced
  • What changed: This changeset uses MIN_NODE_VERSION from the module global scope in the error message
  • What did NOT change (scope boundary): everything else

Change Type (select all)

  • Bug fix
  • Feature
  • Refactor
  • Docs
  • Security hardening
  • Chore/infra

Scope (select all touched areas)

  • Gateway / orchestration
  • Skills / tool execution
  • Auth / tokens
  • Memory / storage
  • Integrations
  • API / contracts
  • UI / DX
  • CI/CD / infra

Linked Issue/PR

  • Closes #
  • Related #

User-visible / Behavior Changes

None

List user-visible changes (including defaults/config).
If none, write None.

Security Impact (required)

  • New permissions/capabilities? (Yes/No)
  • Secrets/tokens handling changed? (Yes/No)
  • New/changed network calls? (Yes/No)
  • Command/tool execution surface changed? (Yes/No)
  • Data access scope changed? (Yes/No)
  • If any Yes, explain risk + mitigation:

Repro + Verification

Environment

  • OS:
  • Runtime/container:
  • Model/provider:
  • Integration/channel (if any):
  • Relevant config (redacted):

Steps

Expected

Actual

Evidence

Attach at least one:

  • Failing test/log before + passing after
  • Trace/log snippets
  • Screenshot/recording
  • Perf numbers (if relevant)

Human Verification (required)

What you personally verified (not just CI), and how:

  • Verified scenarios:
  • Edge cases checked:
  • What you did not verify:

Compatibility / Migration

  • Backward compatible? (Yes/No)
  • Config/env changes? (Yes/No)
  • Migration needed? (Yes/No)
  • If yes, exact upgrade steps:

Failure Recovery (if this breaks)

  • How to disable/revert this change quickly:
  • Files/config to restore:
  • Known bad symptoms reviewers should watch for:

Risks and Mitigations

List only real risks for this PR. Add/remove entries as needed. If none, write None.

  • Risk:
    • Mitigation:

This changeset uses MIN_NODE_VERSION from the module global scope (instead of the hardcoded "22" node version) in the error message before process.exit(1)
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Mar 7, 2026

Greptile Summary

This PR replaces hardcoded 22 values in the nvm installation instructions within the error message of ensureSupportedNodeVersion with the already-defined MIN_NODE_MAJOR constant, improving maintainability so that future minimum Node.js version bumps only require changing the constants at the top of the file.

  • The change is minimal and correct — MIN_NODE_MAJOR (line 5) is already in scope and resolves to 22, so behavior is unchanged.
  • The first line of the error message already used MIN_NODE_VERSION, making this change consistent with the existing pattern.
  • No logic, behavior, or security surface is affected.

Confidence Score: 5/5

  • This PR is safe to merge — it is a pure string-interpolation refactor with no behavioral change.
  • The only change is substituting three hardcoded 22 literals with ${MIN_NODE_MAJOR}, which is defined as 22 on line 5 of the same file. The emitted error message at runtime is identical to the previous version, and no logic, control flow, or external interfaces are touched.
  • No files require special attention.

Last reviewed commit: 01bf6de

steipete added a commit that referenced this pull request Mar 7, 2026
Land contributor change from #39056 and append changelog credit for @onstash.

Co-authored-by: Santosh Venkatraman <[email protected]>
@steipete
Copy link
Copy Markdown
Contributor

steipete commented Mar 7, 2026

Landed #39056 on main.

What we did:

  • Rebases/landing flow from main on temp branch, then squash-landed.
  • Kept the Node-version hint change in openclaw.mjs and added changelog credit in CHANGELOG.md.
  • Ran gate before landing commit: pnpm lint && pnpm build && pnpm test (all green).
  • Landing commit includes contributor credit + Co-authored-by trailer.

SHA hashes:

  • Original PR commit: 01bf6deb6905e9e3916e9a8ec7b40d1ef43fc060
  • Landed on main: c6472c189f830c9b6d975b2ea03108bd40878c19

Thanks @onstash for the contribution.

@steipete steipete closed this Mar 7, 2026
vincentkoc added a commit that referenced this pull request Mar 7, 2026
* origin/main: (37 commits)
  chore: land #39056 Node version hint sync (thanks @onstash)
  fix(security): use icacls /sid for locale-independent Windows ACL audit (#38900)
  fix(ci): refresh detect-secrets baseline offsets
  fix(security): strip custom auth headers on cross-origin redirects
  fix(ci): harden diffs viewer request guard and secret scan baseline
  Secrets: harden SecretRef-safe models.json persistence (#38955)
  docs(changelog): credit allowlist scoping report
  refactor(commands): dedupe onboard search perplexity test setup
  refactor(commands): dedupe message command secret-config tests
  refactor(cli): dedupe restart health probe setup tests
  refactor(cron): dedupe interim retry fallback assertions
  refactor(commands): dedupe model probe target test fixtures
  refactor(discord): dedupe message preflight test runners
  refactor(discord): share message handler test scaffolding
  refactor(discord): dedupe native command ACP routing test setup
  refactor(slack): dedupe app mention in-flight race setup
  refactor(slack): reuse shared prepare test scaffolding
  refactor(plugin-sdk): extract shared channel prelude exports
  refactor(slack): dedupe app mention race test setup
  refactor(line): dedupe replay webhook test fixtures
  ...

# Conflicts:
#	.secrets.baseline
#	apps/ios/fastlane/Fastfile
#	src/commands/message.test.ts
mcaxtr pushed a commit to mcaxtr/openclaw that referenced this pull request Mar 7, 2026
Land contributor change from openclaw#39056 and append changelog credit for @onstash.

Co-authored-by: Santosh Venkatraman <[email protected]>
vincentkoc pushed a commit to BryanTegomoh/openclaw-fork that referenced this pull request Mar 8, 2026
Land contributor change from openclaw#39056 and append changelog credit for @onstash.

Co-authored-by: Santosh Venkatraman <[email protected]>
openperf pushed a commit to openperf/moltbot that referenced this pull request Mar 8, 2026
Land contributor change from openclaw#39056 and append changelog credit for @onstash.

Co-authored-by: Santosh Venkatraman <[email protected]>
Saitop pushed a commit to NomiciAI/openclaw that referenced this pull request Mar 8, 2026
Land contributor change from openclaw#39056 and append changelog credit for @onstash.

Co-authored-by: Santosh Venkatraman <[email protected]>
GordonSH-oss pushed a commit to GordonSH-oss/openclaw that referenced this pull request Mar 9, 2026
Land contributor change from openclaw#39056 and append changelog credit for @onstash.

Co-authored-by: Santosh Venkatraman <[email protected]>
jenawant pushed a commit to jenawant/openclaw that referenced this pull request Mar 10, 2026
Land contributor change from openclaw#39056 and append changelog credit for @onstash.

Co-authored-by: Santosh Venkatraman <[email protected]>
dhoman pushed a commit to dhoman/chrono-claw that referenced this pull request Mar 11, 2026
Land contributor change from openclaw#39056 and append changelog credit for @onstash.

Co-authored-by: Santosh Venkatraman <[email protected]>
senw-developers pushed a commit to senw-developers/va-openclaw that referenced this pull request Mar 17, 2026
Land contributor change from openclaw#39056 and append changelog credit for @onstash.

Co-authored-by: Santosh Venkatraman <[email protected]>
V-Gutierrez pushed a commit to V-Gutierrez/openclaw-vendor that referenced this pull request Mar 17, 2026
Land contributor change from openclaw#39056 and append changelog credit for @onstash.

Co-authored-by: Santosh Venkatraman <[email protected]>
alexey-pelykh pushed a commit to remoteclaw/remoteclaw that referenced this pull request Mar 21, 2026
Land contributor change from openclaw#39056 and append changelog credit for @onstash.

Co-authored-by: Santosh Venkatraman <[email protected]>
(cherry picked from commit c6472c1)
alexey-pelykh added a commit to remoteclaw/remoteclaw that referenced this pull request Mar 21, 2026
…1747)

Land contributor change from openclaw#39056 and append changelog credit for @onstash.


(cherry picked from commit c6472c1)

Co-authored-by: Peter Steinberger <[email protected]>
Co-authored-by: Santosh Venkatraman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants