Greptile Summary

This PR fixes a race condition in resumeSubagentRun where subagent completion announcements were silently dropped when a subagent had waiting grandchild agents. The intended fix is to bypass the cleanupCompletedAt early-return guard when wakeOnDescendantSettle = true, allowing the announce flow to proceed even after cleanup was prematurely marked complete.

However, the fix is ineffective as written due to a second, independent guard on cleanupCompletedAt deeper in the call chain:

• After the new branch clears wakeOnDescendantSettle and falls through, the code reaches startSubagentAnnounceCleanupFlow → beginSubagentCleanup (line 992), which checks entry.cleanupCompletedAt again and returns false if it is set.
• This causes startSubagentAnnounceCleanupFlow to return false, and resumeSubagentRun to return early at line 615 — dropping the announce exactly as before the fix.
• The cleanupCompletedAt field must also be reset to undefined in the new branch for the announce flow to actually execute.

There is also a minor style inconsistency: entry.wakeOnDescendantSettle is set to false rather than undefined, while all other clearing sites (lines 833, 887, 1085, 1156) use undefined.

Confidence Score: 1/5

• Not safe to merge — the fix is a no-op because cleanupCompletedAt is not cleared, so beginSubagentCleanup still blocks the announce flow.
• The PR targets a real and well-described bug, but the implementation is incomplete. The new branch in resumeSubagentRun bypasses the first cleanupCompletedAt guard but leaves the field set, causing the downstream beginSubagentCleanup call to return false and short-circuit the announce. The bug being fixed would remain present after merging this PR.
• src/agents/subagent-registry.ts — specifically the new branch at lines 566-569 and its interaction with beginSubagentCleanup at line 992.

_{Last reviewed commit: 9709123}

@chatgpt-codex-connector @greptile-apps Thanks for the detailed review!

I've addressed the issue by also resetting entry.cleanupCompletedAt = undefined when handling the wakeOnDescendantSettle case. This allows beginSubagentCleanup to proceed and send the announce.

Changes:

• Reset both entry.wakeOnDescendantSettle = undefined and entry.cleanupCompletedAt = undefined
• Used undefined for consistency with other clearing sites (lines 833, 887, 1085, 1156)
• Pushed new commit: ca5bf1e6c

The fix should now properly allow the announce flow to execute when a subagent with descendants completes.

To use Codex here, create a Codex account and connect to github.

Perfect! The fix looks good. By resetting both cleanupCompletedAt and wakeOnDescendantSettle, you've correctly addressed the issue:

1. ✅ Resetting cleanupCompletedAt = undefined allows beginSubagentCleanup to pass its check at subagent-registry.ts:834
2. ✅ Using undefined is consistent with the rest of the codebase
3. ✅ The comment clearly explains the edge case being handled
4. ✅ persistSubagentRuns() ensures the state is saved

The announce flow will now execute properly when descendants complete during the defer period. Great work!

✅ Local Tests Passed

All local tests are passing:

• 88 subagent-related unit tests: All passed

  • subagent-registry-completion.test.ts (6 tests)
  • subagent-registry-cleanup.test.ts (4 tests)
  • subagent-registry.announce-loop-guard.test.ts (5 tests)
  • And 9 more test files...

• All lint/checks: Passed

  • plugin SDK imports ✅
  • webhook auth ✅
  • pairing account scope ✅
  • host env policy ✅

The fix is ready for review and merge.