fix: filter NO_REPLY messages in console output by ql-wade · Pull Request #38436 · openclaw/openclaw

ql-wade · 2026-03-07T00:55:08Z

Problem

I discovered that "NO_REPLY" system messages were displayed in console output, causing confusion for users.

Root Cause

After analysis, I found that the console frontend was missing the NO_REPLY filtering logic, while other channels (e.g., Slack) correctly filtered these messages.

Solution

I added filtering logic to ensure that "NO_REPLY" messages are not displayed to users in the console.

Changes

src/telegram/send.ts: Added NO_REPLY filtering logic

Testing

✅ Code logic verified
✅ No impact on other channels
✅ Console no longer displays NO_REPLY

Fixes #38402

greptile-apps · 2026-03-07T00:57:28Z

Greptile Summary

This PR adds a NO_REPLY suppression guard to sendMessageTelegram in src/telegram/send.ts, mirroring the existing pattern already present in src/slack/send.ts. When the outbound text matches the silent-reply token exactly (and no media URL is present), the function now returns early with a { messageId: "suppressed", chatId: "" } sentinel instead of making a live Telegram API call.

Note on PR description / title accuracy: The PR title and description refer to filtering NO_REPLY messages in "console output" (控制台), but the actual change exclusively targets the Telegram channel (src/telegram/send.ts). If there is a separate console/web channel that also needs this fix, it has not been addressed here.

Key observations:

The implementation correctly reuses isSilentReplyText from ../auto-reply/tokens.js and follows the established Slack suppression pattern.
text?.trim() ?? "" uses redundant optional chaining on a non-nullable string parameter — text.trim() is sufficient.
No tests were added for the new early-return path in sendMessageTelegram, even though src/telegram/send.test.ts contains comprehensive coverage of other scenarios.

Confidence Score: 4/5

Safe to merge — the change is a small, additive guard that follows an established pattern and cannot break existing functionality.
The implementation is correct and mirrors the battle-tested Slack suppression path. The only concerns are a minor redundant null-guard on a non-nullable type and the absence of a dedicated test for the new early-return branch. Neither is a blocking issue. The mismatch between the PR description ("console") and the actual change ("Telegram") is worth clarifying but does not affect code correctness.
No files require special attention beyond the minor style notes on src/telegram/send.ts.

_{Last reviewed commit: f4548a5}

src/telegram/send.ts

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ed9b955b7a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

src/commands/agent.ts

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 060c3d04f0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-03-07T04:01:15Z

src/commands/agent.ts

+    if (chunk.startsWith(base) && chunk.length > base.length) {
+      const delta = chunk.slice(base.length);
+      return { text: chunk, delta };


Treat only explicit snapshots as cumulative updates

This branch assumes any text_delta chunk that starts with the current buffer is a cumulative snapshot, but ACP text_delta streams can still be true deltas whose content happens to share that prefix. In that case the accumulator overwrites instead of appending (for example chunks "a" then "ardvark" become "ardvark" instead of "aardvark"), so assistant streaming and final payload text lose characters. This regression is introduced by the new snapshot heuristic and affects delta-style backends whenever a later chunk begins with the already-buffered text.

Useful? React with 👍 / 👎.

Problem: NO_REPLY system messages were displayed in console output, causing confusion for users. Solution: Added filter to suppress NO_REPLY messages in console frontend, consistent with other channels. Impact: Only affects console display, no impact on other channels.

obviyus · 2026-03-07T04:05:03Z

Landed via temp rebase onto main.

Gate: pnpm test src/commands/agent.acp.test.ts src/gateway/server-chat.agent-events.test.ts ui/src/ui/controllers/chat.test.ts
Land commit: 57530aa
Merge commit: e309a15

Thanks @ql-wade!

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 57530aac52

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-03-07T04:10:09Z

src/commands/agent.ts

+      isSilentReplyText(base, SILENT_REPLY_TOKEN) &&
+      !chunk.startsWith(base) &&
+      startsWithWordChar(chunk)
+    ) {


Strip NO_REPLY prefix before newline/punctuation chunks

When pendingSilentPrefix is exactly NO_REPLY, this branch only drops it if the next chunk starts with a letter/number, so chunks like "\nAnswer", ": answer", or emoji-prefixed text are concatenated as NO_REPLY... and then emitted/logged. That reintroduces the placeholder leak this change is meant to prevent for ACP streams that emit a full silent token followed by visible text beginning with non-word characters (including cumulative snapshots like "NO_REPLY\nAnswer").

Useful? React with 👍 / 👎.

* main: (45 commits) chore: update dependencies except carbon test(memory): make mcporter EINVAL retry test deterministic refactor(extensions): reuse shared helper primitives refactor(core): extract shared dedup helpers fix(ci): re-enable detect-secrets on main docs: reorder 2026.3.7 changelog highlights chore: bump version to 2026.3.7 fix(android): align run command with app id docs: add changelog entry for Android package rename (openclaw#38712) fix(android): rename app package to ai.openclaw.app fix(gateway): stop stale-socket restarts before first event (openclaw#38643) fix(gateway): skip stale-socket restarts for Telegram polling (openclaw#38405) fix(gateway): invalidate bootstrap cache on session rollover (openclaw#38535) docs: update changelog for reply media delivery (openclaw#38572) fix: contain final reply media normalization failures fix: contain block reply media failures fix: normalize reply media paths Fix owner-only auth and overlapping skill env regressions (openclaw#38548) fix(feishu): disable block streaming to prevent silent reply drops (openclaw#38422) fix: suppress ACP NO_REPLY fragments in console output (openclaw#38436) ...

openclaw-barnacle bot added channel: telegram Channel integration: telegram size: XS labels Mar 7, 2026

greptile-apps bot reviewed Mar 7, 2026

View reviewed changes

src/telegram/send.ts Outdated Show resolved Hide resolved

src/telegram/send.ts Outdated Show resolved Hide resolved

ql-wade force-pushed the fix/no-reply-display-issue branch from f4548a5 to f845813 Compare March 7, 2026 01:01

obviyus self-assigned this Mar 7, 2026

openclaw-barnacle bot added commands Command implementations size: S and removed channel: telegram Channel integration: telegram size: XS labels Mar 7, 2026

chatgpt-codex-connector bot reviewed Mar 7, 2026

View reviewed changes

src/commands/agent.ts Outdated Show resolved Hide resolved

src/commands/agent.ts Outdated Show resolved Hide resolved

obviyus added a commit to ql-wade/openclaw that referenced this pull request Mar 7, 2026

fix: harden ACP NO_REPLY buffering (openclaw#38436) (thanks @ql-wade)

060c3d0

obviyus force-pushed the fix/no-reply-display-issue branch from ed9b955 to 060c3d0 Compare March 7, 2026 03:55

openclaw-barnacle bot added size: M and removed size: S labels Mar 7, 2026

chatgpt-codex-connector bot reviewed Mar 7, 2026

View reviewed changes

root and others added 3 commits March 7, 2026 09:33

fix: suppress NO_REPLY fragments in ACP sessions

417f040

fix: harden ACP NO_REPLY buffering (openclaw#38436) (thanks @ql-wade)

57530aa

obviyus force-pushed the fix/no-reply-display-issue branch from 060c3d0 to 57530aa Compare March 7, 2026 04:04

obviyus merged commit e309a15 into openclaw:main Mar 7, 2026
3 checks passed

chatgpt-codex-connector bot reviewed Mar 7, 2026

View reviewed changes

Takhoffman mentioned this pull request Mar 7, 2026

fix(ui): suppress partial NO_REPLY prefix "NO" leaking into console stream #38426

Closed

alexyyyander mentioned this pull request Mar 7, 2026

fix/gateway token mismatch 38617 #38676

Closed

visense mentioned this pull request Mar 7, 2026

[Bug] Feishu: blockStreamingDefault causes replies silently dropped + card streaming duplicates content #38824

Open

mcaxtr pushed a commit to mcaxtr/openclaw that referenced this pull request Mar 7, 2026

fix: suppress ACP NO_REPLY fragments in console output (openclaw#38436)

070b4f7

joshavant pushed a commit that referenced this pull request Mar 7, 2026

fix: suppress ACP NO_REPLY fragments in console output (#38436)

e9f01cd

vincentkoc pushed a commit to BryanTegomoh/openclaw-fork that referenced this pull request Mar 8, 2026

fix: suppress ACP NO_REPLY fragments in console output (openclaw#38436)

b176eb0

Saitop pushed a commit to NomiciAI/openclaw that referenced this pull request Mar 8, 2026

fix: suppress ACP NO_REPLY fragments in console output (openclaw#38436)

dace80c

jenawant pushed a commit to jenawant/openclaw that referenced this pull request Mar 10, 2026

fix: suppress ACP NO_REPLY fragments in console output (openclaw#38436)

bb8e41b

alexey-pelykh mentioned this pull request Mar 10, 2026

Cherry-pick: ACP env strip, NO_REPLY suppress, security docs remoteclaw/remoteclaw#850

Closed

dhoman pushed a commit to dhoman/chrono-claw that referenced this pull request Mar 11, 2026

fix: suppress ACP NO_REPLY fragments in console output (openclaw#38436)

a8a0611

senw-developers pushed a commit to senw-developers/va-openclaw that referenced this pull request Mar 17, 2026

fix: suppress ACP NO_REPLY fragments in console output (openclaw#38436)

56a656d

V-Gutierrez pushed a commit to V-Gutierrez/openclaw-vendor that referenced this pull request Mar 17, 2026

fix: suppress ACP NO_REPLY fragments in console output (openclaw#38436)

0650af4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: filter NO_REPLY messages in console output#38436

fix: filter NO_REPLY messages in console output#38436
obviyus merged 3 commits intoopenclaw:mainfrom
ql-wade:fix/no-reply-display-issue

ql-wade commented Mar 7, 2026 •

edited

Loading

Uh oh!

greptile-apps bot commented Mar 7, 2026

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Mar 7, 2026

Uh oh!

Uh oh!

obviyus commented Mar 7, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Mar 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

ql-wade commented Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Root Cause

Solution

Changes

Testing

Uh oh!

greptile-apps bot commented Mar 7, 2026

Greptile Summary

Confidence Score: 4/5

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

obviyus commented Mar 7, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ql-wade commented Mar 7, 2026 •

edited

Loading