Dependencies: remove unused extension packages#38317
Conversation
Greptile SummaryThis PR removes three unused npm dependencies —
All three unused dependency removals have been verified as safe with no imports in the codebase, and the lockfile changes correctly reflect the updated manifest dependencies. Confidence Score: 5/5
Last reviewed commit: f389ea7 |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f389ea7966
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
* Dependencies: drop unused extension packages * Dependencies: drop unused tlon http-api package * Dependencies: keep bundled acpx package
* Dependencies: drop unused extension packages * Dependencies: drop unused tlon http-api package * Dependencies: keep bundled acpx package
* Dependencies: drop unused extension packages * Dependencies: drop unused tlon http-api package * Dependencies: keep bundled acpx package
* Dependencies: drop unused extension packages * Dependencies: drop unused tlon http-api package * Dependencies: keep bundled acpx package
* Dependencies: drop unused extension packages * Dependencies: drop unused tlon http-api package * Dependencies: keep bundled acpx package
* Dependencies: drop unused extension packages * Dependencies: drop unused tlon http-api package * Dependencies: keep bundled acpx package
* Dependencies: drop unused extension packages * Dependencies: drop unused tlon http-api package * Dependencies: keep bundled acpx package (cherry picked from commit 75981b0)
* Dependencies: drop unused extension packages * Dependencies: drop unused tlon http-api package * Dependencies: keep bundled acpx package (cherry picked from commit 75981b0)
Summary
@urbit/http-apias unused in the Tlon extension manifest.@urbit/http-apifromextensions/tlon/package.jsonand cleaned the matching lockfile entries.acpxbundled in ACPX, kept@tloncorp/tlon-skillbundled in Tlon, and preserved the git-based@tloncorp/apilock resolution.Change Type (select all)
Scope (select all touched areas)
Linked Issue/PR
User-visible / Behavior Changes
None.
Security Impact (required)
No)No)No)No)No)Yes, explain risk + mitigation:Repro + Verification
Environment
Steps
pnpm deadcode:kniponmainafter the Knip config lands.@urbit/http-apiin the Tlon extension dependency findings.Expected
@urbit/http-apidisappears from the unused dependency findings while bundled runtime dependencies remain untouched.Actual
@urbit/http-apiis no longer reported;acpxand@tloncorp/tlon-skillare intentionally retained.Evidence
Human Verification (required)
What you personally verified (not just CI), and how:
@urbit/http-apiimports and reranpnpm deadcode:knipafter the narrow cleanup.Compatibility / Migration
Yes)No)No)Failure Recovery (if this breaks)
extensions/tlon/package.json,pnpm-lock.yaml.Risks and Mitigations
@urbit/http-apicould be used by an unsearched generated/runtime path.