fix(gateway): keep probe routes reachable with root-mounted control ui#38199
Merged
vincentkoc merged 3 commits intomainfrom Mar 6, 2026
Merged
fix(gateway): keep probe routes reachable with root-mounted control ui#38199vincentkoc merged 3 commits intomainfrom
vincentkoc merged 3 commits intomainfrom
Conversation
0508603 to
b6b1948
Compare
Contributor
Greptile SummaryThis PR fixes a routing bug where the Control UI's SPA catch-all, when mounted at The fix:
Test coverage:
Scope boundaries respected: No changes to readiness semantics, auth model, or route ordering. Confidence Score: 5/5
Last reviewed commit: 57a2661 |
18 tasks
Saitop
pushed a commit
to NomiciAI/openclaw
that referenced
this pull request
Mar 8, 2026
openclaw#38199) * fix(gateway): keep probe routes reachable with root-mounted control ui * Changelog: add root-mounted probe precedence fix entry * Update CHANGELOG.md
jenawant
pushed a commit
to jenawant/openclaw
that referenced
this pull request
Mar 10, 2026
openclaw#38199) * fix(gateway): keep probe routes reachable with root-mounted control ui * Changelog: add root-mounted probe precedence fix entry * Update CHANGELOG.md
dhoman
pushed a commit
to dhoman/chrono-claw
that referenced
this pull request
Mar 11, 2026
openclaw#38199) * fix(gateway): keep probe routes reachable with root-mounted control ui * Changelog: add root-mounted probe precedence fix entry * Update CHANGELOG.md
6 tasks
senw-developers
pushed a commit
to senw-developers/va-openclaw
that referenced
this pull request
Mar 17, 2026
openclaw#38199) * fix(gateway): keep probe routes reachable with root-mounted control ui * Changelog: add root-mounted probe precedence fix entry * Update CHANGELOG.md
V-Gutierrez
pushed a commit
to V-Gutierrez/openclaw-vendor
that referenced
this pull request
Mar 17, 2026
openclaw#38199) * fix(gateway): keep probe routes reachable with root-mounted control ui * Changelog: add root-mounted probe precedence fix entry * Update CHANGELOG.md
alexey-pelykh
pushed a commit
to remoteclaw/remoteclaw
that referenced
this pull request
Mar 20, 2026
openclaw#38199) * fix(gateway): keep probe routes reachable with root-mounted control ui * Changelog: add root-mounted probe precedence fix entry * Update CHANGELOG.md (cherry picked from commit d070c44)
alexey-pelykh
pushed a commit
to remoteclaw/remoteclaw
that referenced
this pull request
Mar 20, 2026
openclaw#38199) * fix(gateway): keep probe routes reachable with root-mounted control ui * Changelog: add root-mounted probe precedence fix entry * Update CHANGELOG.md (cherry picked from commit d070c44)
alexey-pelykh
pushed a commit
to remoteclaw/remoteclaw
that referenced
this pull request
Mar 20, 2026
openclaw#38199) * fix(gateway): keep probe routes reachable with root-mounted control ui * Changelog: add root-mounted probe precedence fix entry * Update CHANGELOG.md (cherry picked from commit d070c44)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/, the SPA request classifier can still claim/health,/healthz,/ready, and/readyzbefore the gateway probe handler runs./healthand/healthzcan return Control UI HTML200instead of machine health payload #18446 reproducible even after Gateway: add healthz/readyz probe endpoints for container checks #31272 landed.Change Type (select all)
Scope (select all touched areas)
Linked Issue/PR
/healthand/healthzcan return Control UI HTML200instead of machine health payload #18446User-visible / Behavior Changes
/health,/healthz,/ready, and/readyzstay reachable even when the Control UI is mounted at/.Security Impact (required)
No)No)No)No)No)Yes, explain risk + mitigation:Repro + Verification
Environment
gateway.controlUi.basePath = "/"equivalent normalization to empty base path)Steps
/./healthzand/readyz./healthzand request it again.Expected
Actual
Evidence
Attach at least one:
Human Verification (required)
What you personally verified (not just CI), and how:
/health,/healthz,/ready, or/readyz./healthzstill keep precedence.Compatibility / Migration
Yes)No)No)Failure Recovery (if this breaks)
src/gateway/control-ui-routing.tssrc/gateway/server.plugin-http-auth.test.tsCHANGELOG.md/healthzstop taking precedence.Risks and Mitigations