feat: add Azure api-version support for OpenAI‑compatible chat completions#37717
Open
CRISPpp wants to merge 4 commits intoopenclaw:mainfrom
Open
feat: add Azure api-version support for OpenAI‑compatible chat completions#37717CRISPpp wants to merge 4 commits intoopenclaw:mainfrom
CRISPpp wants to merge 4 commits intoopenclaw:mainfrom
Conversation
Contributor
Greptile SummaryThis PR adds Key concerns found during review:
Confidence Score: 2/5
Last reviewed commit: d1309c0 |
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Describe the problem and fix in 2–5 bullets:
/chat/completionscalls returned 404 becauseapi-versionwasn’t being appended correctly.api-version; without it, web chat and embedded runs fail.models.providers.*.apiVersion, captured it in onboarding, and injectedapi-versionat request time for Azure chat completions.Change Type (select all)
Scope (select all touched areas)
Linked Issue/PR
User-visible / Behavior Changes
models.providers.*.apiVersionfor OpenAI‑compatible chat completions.--custom-api-version.Security Impact (required)
Yes, explain risk + mitigation:/chat/completionsrequests only; no new endpoints.Repro + Verification
Environment
models.providers.custom-*.baseUrl: https://<resource>.cognitiveservices.azure.com/openai/deployments/o1models.providers.custom-*.apiVersion: 2025-01-01-previewSteps
apiVersion.api-versionand succeeds.Expected
Actual
api-versionmissing.Evidence
Attach at least one:
Human Verification (required)
What you personally verified (not just CI), and how:
api-version.Compatibility / Migration
models.providers.*.apiVersiononly for Azure OpenAI providers that require it.Failure Recovery (if this breaks)
models.providers.*.apiVersionor revert the code.~/.openclaw/openclaw.jsonprovider block.Risks and Mitigations
apiVersionis opt‑in and only applied for configured Azure hosts and/chat/completionspaths.