agents: scope parallel_tool_calls to OpenAI-compatible payloads#37261
agents: scope parallel_tool_calls to OpenAI-compatible payloads#37261cgdusek wants to merge 10 commits intoopenclaw:mainfrom
Conversation
Greptile SummaryThis PR scopes Key strengths:
Issue to address:
Confidence Score: 4/5
Last reviewed commit: ce91a5b |
ce91a5b to
b5216e6
Compare
This comment was marked as spam.
This comment was marked as spam.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 508c443821
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
c2b4c0f to
ccdb8bf
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ccdb8bf595
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This comment was marked as spam.
This comment was marked as spam.
b7f5dc7 to
e9454c9
Compare
|
Closing this PR because the author has more than 10 active PRs in this repo. Please reduce the active PR queue and reopen or resubmit once it is back under the limit. You can close your own PRs to get back under the limit. |
Summary
parallel_tool_callspayload injection to OpenAI-compatible request APIs only (openai-completions,openai-responses)params.parallel_tool_callsandparams.parallelToolCallsWhy
Issue #37048 reports a high-impact regression where models that reject parallel tool calls return 400 and break tool execution. Existing proposals added payload injection but did not guard API compatibility. This patch keeps the fix while preventing accidental injection into strict non-OpenAI schemas.
Validation
pnpm vitest run src/agents/pi-embedded-runner-extraparams.test.tspnpm buildpnpm checkcurrently fails in this branch due pre-existing unrelated type errors:src/gateway/openai-http.ts(303,48)src/gateway/server-methods/chat.ts(938,9)Related